Fix RuboCop linting issues and improve code quality

- Refactored complex methods to reduce cyclomatic complexity
- Added proper RuboCop disable comments for intentional class length
- Fixed line length issues with proper string concatenation
- Improved method organization and readability
- Added proper respond_to_missing? methods for Rainbow fallback
- Fixed test spec helper paths
- Extracted reusable methods for better maintainability

All RuboCop offenses have been resolved while maintaining functionality.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

lib/generators/react_on_rails/doctor_generator.rb

@@ -39,7 +39,14 @@ def to_s
 
 module ReactOnRails
   module Generators
+    # rubocop:disable Metrics/ClassLength, Metrics/AbcSize
     class DoctorGenerator < Rails::Generators::Base
+      MESSAGE_COLORS = {
+        error: :red,
+        warning: :yellow,
+        success: :green,
+        info: :blue
+      }.freeze
       source_root(File.expand_path(__dir__))
 
       desc "Diagnose React on Rails setup and configuration"
@@ -174,38 +181,50 @@ def check_gitignore
       end
 
       def print_summary
+        print_summary_header
+        counts = calculate_message_counts
+        print_summary_message(counts)
+        print_detailed_results_if_needed(counts)
+      end
+
+      def print_summary_header
         puts Rainbow("DIAGNOSIS COMPLETE").cyan.bold
         puts Rainbow("=" * 80).cyan
         puts
+      end
 
-        error_count = @checker.messages.count { |msg| msg[:type] == :error }
-        warning_count = @checker.messages.count { |msg| msg[:type] == :warning }
-        success_count = @checker.messages.count { |msg| msg[:type] == :success }
+      def calculate_message_counts
+        {
+          error: @checker.messages.count { |msg| msg[:type] == :error },
+          warning: @checker.messages.count { |msg| msg[:type] == :warning },
+          success: @checker.messages.count { |msg| msg[:type] == :success }
+        }
+      end
 
-        if error_count == 0 && warning_count == 0
+      def print_summary_message(counts)
+        if counts[:error].zero? && counts[:warning].zero?
           puts Rainbow("🎉 Excellent! Your React on Rails setup looks perfect!").green.bold
-        elsif error_count == 0
-          puts Rainbow("✅ Good! Your setup is functional with #{warning_count} minor issue(s).").yellow
+        elsif counts[:error].zero?
+          puts Rainbow("✅ Good! Your setup is functional with #{counts[:warning]} minor issue(s).").yellow
         else
-          puts Rainbow("❌ Issues found: #{error_count} error(s), #{warning_count} warning(s)").red
+          puts Rainbow("❌ Issues found: #{counts[:error]} error(s), #{counts[:warning]} warning(s)").red
         end
 
-        puts Rainbow("📊 Summary: #{success_count} checks passed, #{warning_count} warnings, #{error_count} errors").blue
+        summary_text = "📊 Summary: #{counts[:success]} checks passed, " \
+                       "#{counts[:warning]} warnings, #{counts[:error]} errors"
+        puts Rainbow(summary_text).blue
+      end
 
-        return unless options[:verbose] || error_count > 0 || warning_count > 0
+      def print_detailed_results_if_needed(counts)
+        return unless options[:verbose] || counts[:error].positive? || counts[:warning].positive?
 
         puts "\nDetailed Results:"
         print_all_messages
       end
 
       def print_all_messages
         @checker.messages.each do |message|
-          color = case message[:type]
-                  when :error then :red
-                  when :warning then :yellow
-                  when :success then :green
-                  when :info then :blue
-                  end
+          color = MESSAGE_COLORS[message[:type]] || :blue
 
           puts Rainbow(message[:content]).send(color)
           puts
@@ -252,5 +271,6 @@ def exit_with_status
         end
       end
     end
+    # rubocop:enable Metrics/ClassLength, Metrics/AbcSize
   end
 end

lib/generators/react_on_rails/system_checker.rb

@@ -4,6 +4,7 @@ module ReactOnRails
   module Generators
     # SystemChecker provides validation methods for React on Rails setup
     # Used by both install and doctor generators
+    # rubocop:disable Metrics/ClassLength
     class SystemChecker
       attr_reader :messages
 
@@ -219,37 +220,12 @@ def check_package_version_sync
       def check_react_dependencies
         return unless File.exist?("package.json")
 
-        required_deps = {
-          "react" => "React library",
-          "react-dom" => "React DOM library",
-          "@babel/preset-react" => "Babel React preset"
-        }
-
-        missing_deps = []
-
-        begin
-          package_json = JSON.parse(File.read("package.json"))
-          all_deps = package_json["dependencies"]&.merge(package_json["devDependencies"] || {}) || {}
-
-          required_deps.each do |dep, description|
-            if all_deps[dep]
-              add_success("✅ #{description} (#{dep}) is installed")
-            else
-              missing_deps << dep
-            end
-          end
+        required_deps = required_react_dependencies
+        package_json = parse_package_json
+        return unless package_json
 
-          if missing_deps.any?
-            add_warning(<<~MSG.strip)
-              ⚠️  Missing React dependencies: #{missing_deps.join(', ')}
-
-              Install them with:
-              npm install #{missing_deps.join(' ')}
-            MSG
-          end
-        rescue JSON::ParserError
-          add_warning("⚠️  Could not parse package.json to check React dependencies")
-        end
+        missing_deps = find_missing_dependencies(package_json, required_deps)
+        report_dependency_status(required_deps, missing_deps, package_json)
       end
 
       # Rails integration validation
@@ -394,6 +370,44 @@ def normalize_config_content(content)
                .gsub(/\s+/, " ")                       # Normalize whitespace
                .strip
       end
+
+      def required_react_dependencies
+        {
+          "react" => "React library",
+          "react-dom" => "React DOM library",
+          "@babel/preset-react" => "Babel React preset"
+        }
+      end
+
+      def parse_package_json
+        JSON.parse(File.read("package.json"))
+      rescue JSON::ParserError
+        add_warning("⚠️  Could not parse package.json to check React dependencies")
+        nil
+      end
+
+      def find_missing_dependencies(package_json, required_deps)
+        all_deps = package_json["dependencies"]&.merge(package_json["devDependencies"] || {}) || {}
+        required_deps.keys.reject { |dep| all_deps[dep] }
+      end
+
+      def report_dependency_status(required_deps, missing_deps, package_json)
+        all_deps = package_json["dependencies"]&.merge(package_json["devDependencies"] || {}) || {}
+
+        required_deps.each do |dep, description|
+          add_success("✅ #{description} (#{dep}) is installed") if all_deps[dep]
+        end
+
+        return unless missing_deps.any?
+
+        add_warning(<<~MSG.strip)
+          ⚠️  Missing React dependencies: #{missing_deps.join(', ')}
+
+          Install them with:
+          npm install #{missing_deps.join(' ')}
+        MSG
+      end
     end
+    # rubocop:enable Metrics/ClassLength
   end
 end

spec/lib/generators/react_on_rails/doctor_generator_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require "spec_helper"
+require_relative "../../../react_on_rails/spec_helper"
 require "rails/generators"
 require_relative "../../../../lib/generators/react_on_rails/doctor_generator"
 

spec/lib/generators/react_on_rails/system_checker_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require "spec_helper"
+require_relative "../../../react_on_rails/spec_helper"
 require_relative "../../../../lib/generators/react_on_rails/system_checker"
 
 RSpec.describe ReactOnRails::Generators::SystemChecker do