linting

Author: AbanoubGhadban

react_on_rails_pro/packages/node-renderer/src/worker.ts

@@ -311,7 +311,7 @@ export default function run(config: Partial<Config>) {
         onUpdateReceived: (obj: unknown) => {
           // Only process updates if we have a render result
           if (!renderResult) {
-            return undefined;
+            return;
           }
 
           try {
@@ -320,7 +320,6 @@ export default function run(config: Partial<Config>) {
             // Log error but don't stop processing
             log.error({ err, msg: 'Error processing update chunk' });
           }
-          return undefined;
         },
 
         onResponseStart: async (response: ResponseResult) => {
@@ -335,7 +334,6 @@ export default function run(config: Partial<Config>) {
           } catch (err) {
             log.error({ err, msg: 'Error ending render sink' });
           }
-          return undefined;
         },
       });
     } catch (err) {

react_on_rails_pro/packages/node-renderer/src/worker/handleIncrementalRenderStream.ts

@@ -18,9 +18,9 @@ export interface IncrementalRenderStreamHandlerOptions {
     raw: NodeJS.ReadableStream | { [Symbol.asyncIterator](): AsyncIterator<Buffer> };
   };
   onRenderRequestReceived: (renderRequest: unknown) => Promise<RenderRequestResult> | RenderRequestResult;
-  onResponseStart: (response: ResponseResult) => Promise<void> | undefined;
-  onUpdateReceived: (updateData: unknown) => Promise<void> | undefined;
-  onRequestEnded: () => Promise<void> | undefined;
+  onResponseStart: (response: ResponseResult) => Promise<void> | void;
+  onUpdateReceived: (updateData: unknown) => Promise<void> | void;
+  onRequestEnded: () => Promise<void> | void;
 }
 
 /**
@@ -64,6 +64,7 @@ export async function handleIncrementalRenderStream(
               console.error(reportedMessage);
               errorReporter.message(reportedMessage);
               // Skip this malformed chunk and continue with next ones
+              // eslint-disable-next-line no-continue
               continue;
             }
           }

react_on_rails_pro/packages/node-renderer/tests/incrementalRender.test.ts

@@ -642,7 +642,7 @@ describe('incremental render NDJSON endpoint', () => {
     // Process each chunk and immediately echo it back
     for (let i = 0; i < chunksToSend.length; i += 1) {
       const chunk = chunksToSend[i];
-      
+
       // Send the chunk
       req.write(`${JSON.stringify(chunk)}\n`);