Commit 13a1aca
Remove misleading TODO comment about shakapacker.yml integration
The TODO referenced automatic detection of server_bundle_output_path from
shakapacker.yml, but this feature was never implemented and may not be
feasible as originally conceived.
Why this TODO is being removed:
1. The referenced feature/shakapacker-yml-integration branch did not contain
the implementation - it only had the foundational work which was already
merged via PRs #1798 and #1815
2. Shakapacker.yml's public_output_path serves a different purpose than
React on Rails' server_bundle_output_path (public webpack output vs
private server bundle security)
3. The current configuration approach is working well
The server bundle security features (server_bundle_output_path and
enforce_private_server_bundles) are fully implemented and tested on master.
Closes #1808
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>1 parent 15c7b5d commit 13a1aca
1 file changed
+0
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | 54 | | |
58 | 55 | | |
59 | 56 | | |
| |||
0 commit comments