Add timeout protection for version checking operations

Extract hardcoded timeout value to VERSION_CHECK_TIMEOUT constant for better maintainability and testability.

Co-authored-by: Abanoub Ghadban <[email protected]>

Author: github-actions[bot]

lib/react_on_rails/dev/process_manager.rb

@@ -5,6 +5,9 @@
 module ReactOnRails
   module Dev
     class ProcessManager
+      # Timeout for version check operations to prevent hanging
+      VERSION_CHECK_TIMEOUT = 5
+
       class << self
         # Check if a process is available and usable in the current execution context
         # This accounts for bundler context where system commands might be intercepted
@@ -49,7 +52,7 @@ def installed_in_current_context?(process)
           # Use system() because that's how we'll actually call it later
           version_flags_for(process).any? do |flag|
             # Add timeout to prevent hanging on version checks
-            Timeout.timeout(5) do
+            Timeout.timeout(VERSION_CHECK_TIMEOUT) do
               system(process, flag, out: File::NULL, err: File::NULL)
             end
           end
@@ -103,7 +106,7 @@ def process_available_in_system?(process)
             # Try version flags to check if process exists outside bundler context
             version_flags_for(process).any? do |flag|
               # Add timeout to prevent hanging on version checks
-              Timeout.timeout(5) do
+              Timeout.timeout(VERSION_CHECK_TIMEOUT) do
                 system(process, flag, out: File::NULL, err: File::NULL)
               end
             end

spec/react_on_rails/dev/process_manager_spec.rb

@@ -19,19 +19,19 @@
 
   describe ".installed?" do
     it "returns true when process is available in current context" do
-      expect(Timeout).to receive(:timeout).with(5).and_yield
+      expect(Timeout).to receive(:timeout).with(described_class::VERSION_CHECK_TIMEOUT).and_yield
       expect_any_instance_of(Kernel).to receive(:system)
         .with("overmind", "--version", out: File::NULL, err: File::NULL).and_return(true)
       expect(described_class).to be_installed("overmind")
     end
 
     it "returns false when process is not available in current context" do
-      expect(Timeout).to receive(:timeout).with(5).and_raise(Errno::ENOENT)
+      expect(Timeout).to receive(:timeout).with(described_class::VERSION_CHECK_TIMEOUT).and_raise(Errno::ENOENT)
       expect(described_class.installed?("nonexistent")).to be false
     end
 
     it "returns false when all version flags fail" do
-      expect(Timeout).to receive(:timeout).with(5).exactly(3).times.and_yield
+      expect(Timeout).to receive(:timeout).with(described_class::VERSION_CHECK_TIMEOUT).exactly(3).times.and_yield
       expect_any_instance_of(Kernel).to receive(:system)
         .with("failing_process", "--version", out: File::NULL, err: File::NULL).and_return(false)
       expect_any_instance_of(Kernel).to receive(:system)
@@ -42,7 +42,7 @@
     end
 
     it "returns true when second version flag succeeds" do
-      expect(Timeout).to receive(:timeout).with(5).twice.and_yield
+      expect(Timeout).to receive(:timeout).with(described_class::VERSION_CHECK_TIMEOUT).twice.and_yield
       expect_any_instance_of(Kernel).to receive(:system)
         .with("foreman", "--version", out: File::NULL, err: File::NULL).and_return(false)
       expect_any_instance_of(Kernel).to receive(:system)
@@ -51,7 +51,7 @@
     end
 
     it "returns false when version check times out" do
-      expect(Timeout).to receive(:timeout).with(5).and_raise(Timeout::Error)
+      expect(Timeout).to receive(:timeout).with(described_class::VERSION_CHECK_TIMEOUT).and_raise(Timeout::Error)
       expect(described_class.installed?("hanging_process")).to be false
     end
   end
@@ -158,7 +158,7 @@
   describe ".process_available_in_system?" do
     it "checks process availability outside bundle context with version flags" do
       expect(described_class).to receive(:with_unbundled_context).and_yield
-      expect(Timeout).to receive(:timeout).with(5).and_yield
+      expect(Timeout).to receive(:timeout).with(described_class::VERSION_CHECK_TIMEOUT).and_yield
       expect_any_instance_of(Kernel).to receive(:system)
         .with("foreman", "--version", out: File::NULL, err: File::NULL).and_return(true)
 
@@ -173,7 +173,7 @@
 
     it "tries multiple version flags before failing" do
       expect(described_class).to receive(:with_unbundled_context).and_yield
-      expect(Timeout).to receive(:timeout).with(5).twice.and_yield
+      expect(Timeout).to receive(:timeout).with(described_class::VERSION_CHECK_TIMEOUT).twice.and_yield
       expect_any_instance_of(Kernel).to receive(:system)
         .with("foreman", "--version", out: File::NULL, err: File::NULL).and_return(false)
       expect_any_instance_of(Kernel).to receive(:system)
@@ -184,7 +184,7 @@
 
     it "returns false when version check times out in system context" do
       expect(described_class).to receive(:with_unbundled_context).and_yield
-      expect(Timeout).to receive(:timeout).with(5).and_raise(Timeout::Error)
+      expect(Timeout).to receive(:timeout).with(described_class::VERSION_CHECK_TIMEOUT).and_raise(Timeout::Error)
 
       expect(described_class.send(:process_available_in_system?, "hanging_process")).to be false
     end