Commit 17750ed
Fix ESLint configuration to prevent false positives in Pro package
Addresses CI failures where ESLint reported deprecated API usage and
unbound method errors in the Pro package that were not actual issues.
Root cause: The pre-commit hook was running ESLint with
`--report-unused-disable-directives --fix`, which removed needed
eslint-disable comments because locally these TypeScript rules weren't
triggering due to project configuration differences between local and CI.
Changes:
1. Disabled problematic rules for Pro package in eslint.config.ts:
- @typescript-eslint/no-deprecated: unmountComponentAtNode is needed
for React < 18 backward compatibility
- @typescript-eslint/unbound-method: method reassignment pattern is
intentional for type safety
2. Removed `--report-unused-disable-directives` from pre-commit hook:
- This flag is meant for CI validation, not local autofixing
- With --fix, it was removing disable directives ESLint thought were
unused, causing CI failures
- Now hook only runs --fix without the validation flag
Why this happened: The typescript-eslint strict rules behave differently
between local development and CI environments. The pre-commit hook
removed eslint-disable comments in a previous commit because the rules
weren't triggering locally, leading to CI failures.
Prevention: By explicitly disabling these rules for the Pro package,
we avoid the need for disable comments entirely and ensure consistent
behavior between local and CI environments.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>1 parent 54695ed commit 17750ed
2 files changed
+6
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
234 | 234 | | |
235 | 235 | | |
236 | 236 | | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
237 | 241 | | |
238 | 242 | | |
239 | 243 | | |
| |||
0 commit comments