Fix ESLint violations in Pro packages

Fixes CI failures in Pro lint-js-and-ruby workflow by addressing:
1. Deprecated tsEslint.config() usage - migrated to flat config array
2. Unnecessary String() conversion in licenseValidator.ts
3. Unused eslint-disable directives in multiple files
4. Properly scoped type-checked rules to TypeScript files only

Changes:
- eslint.config.ts: Removed deprecated tsEslint.config() wrapper, properly spread arrays from compat.extends() and tsEslint.configs
- licenseValidator.ts:237: Removed redundant String() call on already-string value
- vm.ts:74: Removed unused 'no-var' from eslint-disable comment
- buildConsoleReplay.ts:57,68: Removed unused default-param-last directives
- context.ts:4: Removed unused 'no-var' from eslint-disable comment

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

eslint.config.ts

@@ -16,7 +16,7 @@ const compat = new FlatCompat({
   allConfig: js.configs.all,
 });
 
-const config = tsEslint.config([
+const config = [
   // eslint-disable-next-line @typescript-eslint/no-unsafe-argument, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
   includeIgnoreFile(path.resolve(__dirname, '.gitignore')),
   globalIgnores([
@@ -61,7 +61,7 @@ const config = tsEslint.config([
     files: ['**/*.[jt]s', '**/*.[jt]sx', '**/*.[cm][jt]s'],
   },
   js.configs.recommended,
-  compat.extends('eslint-config-shakacode'),
+  ...compat.extends('eslint-config-shakacode'),
   {
     languageOptions: {
       globals: {
@@ -194,11 +194,19 @@ const config = tsEslint.config([
       'import/no-unresolved': 'off',
     },
   },
+  ...tsEslint.configs.strictTypeChecked.map((c) => {
+    // Only apply type-checked rules to TypeScript files
+    if (c.files) {
+      return c;
+    }
+    return {
+      ...c,
+      files: ['**/*.ts', '**/*.tsx', '**/*.mts', '**/*.cts'],
+    };
+  }),
   {
     files: ['**/*.ts{x,}', '**/*.[cm]ts'],
 
-    extends: tsEslint.configs.strictTypeChecked,
-
     languageOptions: {
       parserOptions: {
         projectService: true,
@@ -278,14 +286,20 @@ const config = tsEslint.config([
       'react/no-deprecated': 'off',
     },
   },
+  {
+    ...jest.configs['flat/recommended'],
+    files: ['packages/*/tests/**', '**/*.test.{js,jsx,ts,tsx}'],
+  },
+  {
+    ...jest.configs['flat/style'],
+    files: ['packages/*/tests/**', '**/*.test.{js,jsx,ts,tsx}'],
+  },
+  {
+    ...testingLibrary.configs['flat/dom'],
+    files: ['packages/*/tests/**', '**/*.test.{js,jsx,ts,tsx}'],
+  },
   {
     files: ['packages/*/tests/**', '**/*.test.{js,jsx,ts,tsx}'],
-
-    extends: [
-      jest.configs['flat/recommended'],
-      jest.configs['flat/style'],
-      testingLibrary.configs['flat/dom'],
-    ],
 
     rules: {
       // Allows Jest mocks before import
@@ -306,6 +320,6 @@ const config = tsEslint.config([
   // must be the last config in the array
   // https://github.com/prettier/eslint-plugin-prettier?tab=readme-ov-file#configuration-new-eslintconfigjs
   prettierRecommended,
-]);
+];
 
 export default config;

packages/react-on-rails-pro-node-renderer/src/shared/licenseValidator.ts

@@ -234,7 +234,7 @@ export function getValidatedLicenseData(): LicenseData {
  */
 export function isEvaluation(): boolean {
   const data = getValidatedLicenseData();
-  const plan = String(data.plan || '');
+  const plan = data.plan || '';
   return plan !== 'paid' && !plan.startsWith('paid_');
 }
 

packages/react-on-rails-pro-node-renderer/src/worker/vm.ts

@@ -71,7 +71,7 @@ export type RenderResult = string | Readable | { exceptionMessage: string };
 declare global {
   // This works on node 16+
   // https://stackoverflow.com/questions/35074713/extending-typescript-global-object-in-node-js/68328575#68328575
-  // eslint-disable-next-line vars-on-top, no-var
+  // eslint-disable-next-line vars-on-top
   var ReactOnRails: ROR | undefined;
 }
 

packages/react-on-rails/src/buildConsoleReplay.ts

@@ -54,7 +54,6 @@ export function consoleReplay(
   return lines.join('\n');
 }
 
-/* eslint-disable default-param-last */
 export default function buildConsoleReplay(
   customConsoleHistory: (typeof console)['history'] | undefined = undefined,
   numberOfMessagesToSkip = 0,
@@ -66,4 +65,3 @@ export default function buildConsoleReplay(
   }
   return wrapInScriptTags('consoleReplayLog', consoleReplayJS, nonce);
 }
-/* eslint-enable default-param-last */

packages/react-on-rails/src/context.ts

@@ -1,10 +1,10 @@
 import type { ReactOnRailsInternal, RailsContext } from './types/index.ts';
 
 declare global {
-  /* eslint-disable no-var,vars-on-top,no-underscore-dangle */
+  /* eslint-disable vars-on-top,no-underscore-dangle */
   var ReactOnRails: ReactOnRailsInternal | undefined;
   var __REACT_ON_RAILS_EVENT_HANDLERS_RAN_ONCE__: boolean;
-  /* eslint-enable no-var,vars-on-top,no-underscore-dangle */
+  /* eslint-enable vars-on-top,no-underscore-dangle */
 }
 
 let currentRailsContext: RailsContext | null = null;