Skip to content

Commit 18d19eb

Browse files
Fix: Update RSC config references in server_rendering_js_code.rb
Critical bugfix discovered during code review: - Lines 67-68 were still calling ReactOnRails.configuration instead of ReactOnRailsPro.configuration - Updated to use ReactOnRailsPro.configuration.react_client_manifest_file - Updated to use ReactOnRailsPro.configuration.react_server_client_manifest_file - Extracted config to local variable to fix RuboCop line length violation This ensures RSC manifest file configurations are read from the correct Pro configuration after they were moved from open-source to Pro gem in Phase 2. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent bc8716d commit 18d19eb

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

react_on_rails_pro/lib/react_on_rails_pro/server_rendering_js_code.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,9 @@ def render(props_string, rails_context, redux_stores, react_component_name, rend
6464
"'serverRenderReactComponent'"
6565
end
6666
rsc_params = if ReactOnRailsPro.configuration.enable_rsc_support && render_options.streaming?
67-
react_client_manifest_file = ReactOnRails.configuration.react_client_manifest_file
68-
react_server_client_manifest_file = ReactOnRails.configuration.react_server_client_manifest_file
67+
config = ReactOnRailsPro.configuration
68+
react_client_manifest_file = config.react_client_manifest_file
69+
react_server_client_manifest_file = config.react_server_client_manifest_file
6970
<<-JS
7071
railsContext.reactClientManifestFileName = '#{react_client_manifest_file}';
7172
railsContext.reactServerClientManifestFileName = '#{react_server_client_manifest_file}';

0 commit comments

Comments
 (0)