Skip to content

Commit 1c796c8

Browse files
committed
don't use yalc in a yarn workspace
1 parent f2357b0 commit 1c796c8

File tree

4 files changed

+389
-43
lines changed

4 files changed

+389
-43
lines changed

packages/react-on-rails-pro-node-renderer/package.json

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
2-
"name": "react-on-rails-pro-dummy-placeholder",
2+
"name": "react-on-rails-pro-node-renderer",
33
"version": "16.2.0-beta.11",
4-
"description": "Placeholder package.json for react_on_rails_pro dummy app - actual Pro package is at packages/react-on-rails-pro",
4+
"description": "React on Rails Pro Node Renderer for server-side rendering",
55
"private": true,
66
"directories": {
77
"doc": "docs"
@@ -37,7 +37,6 @@
3737
"node-html-parser": "^7.0.1",
3838
"nps": "^5.9.12",
3939
"pino-pretty": "^13.0.0",
40-
"react-on-rails": "link:.yalc/react-on-rails",
4140
"redis": "^5.0.1",
4241
"sentry-testkit": "^5.0.6",
4342
"touch": "^3.1.0",
@@ -60,17 +59,17 @@
6059
}
6160
},
6261
"scripts": {
63-
"preinstall": "node ./script/preinstall.js",
64-
"postinstall": "test -f post-yarn-install.local && ./post-yarn-install.local || true",
65-
"link-source": "cd ../packages/react-on-rails && yarn && yalc publish",
66-
"test": "nps test",
62+
"build": "yarn run clean && yarn run tsc",
63+
"build-watch": "yarn run clean && yarn run tsc --watch",
64+
"clean": "rm -rf ./lib",
65+
"developing": "nps node-renderer.debug",
66+
"test": "jest tests",
67+
"type-check": "yarn run tsc --noEmit --noErrorTruncation",
6768
"prepack": "nps build.prepack",
6869
"prepare": "nps build.prepack",
69-
"prepublishOnly": "nps build",
70-
"start": "nps",
71-
"developing": "nps node-renderer.debug",
72-
"eslint": "eslint .",
73-
"check": "nps lint && nps format && nps test"
70+
"prepublishOnly": "yarn run build",
71+
"yalc:publish": "yalc publish",
72+
"yalc": "yalc"
7473
},
7574
"repository": {
7675
"type": "git",
@@ -104,10 +103,10 @@
104103
"resetModules": true,
105104
"resetMocks": true,
106105
"roots": [
107-
"../packages/react-on-rails-pro-node-renderer"
106+
"../react-on-rails-pro-node-renderer"
108107
],
109108
"setupFiles": [
110-
"../packages/react-on-rails-pro-node-renderer/tests/helper.ts"
109+
"../react-on-rails-pro-node-renderer/tests/helper.ts"
111110
],
112111
"testEnvironment": "node",
113112
"transform": {

packages/react-on-rails-pro-node-renderer/tests/concurrentHtmlStreaming.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ import { randomUUID } from 'crypto';
22
import { createClient } from 'redis';
33
import parser from 'node-html-parser';
44

5-
// @ts-expect-error TODO: fix later
6-
import { RSCPayloadChunk } from 'react-on-rails';
5+
// eslint-disable-next-line import/no-relative-packages
6+
import { RSCPayloadChunk } from '../../react-on-rails/lib/types';
77
import buildApp from '../src/worker';
88
import config from './testingNodeRendererConfigs';
99
import { makeRequest } from './httpRequestUtils';

packages/react-on-rails-pro-node-renderer/tests/worker.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ import formAutoContent from 'form-auto-content';
22
import fs from 'fs';
33
import querystring from 'querystring';
44
import { createReadStream } from 'fs-extra';
5-
import packageJson from 'react-on-rails-workspace/package.json';
5+
// eslint-disable-next-line import/no-relative-packages
6+
import packageJson from '../../../package.json';
67
import worker, { disableHttp2 } from '../src/worker';
78
import {
89
BUNDLE_TIMESTAMP,

0 commit comments

Comments
 (0)