Convert Ruby gem version format to npm semver format

Ruby gem versions use dots for pre-release versions (e.g., 16.2.0.beta.10)
while npm requires hyphens (16.2.0-beta.10) to match semver spec.

This commit fixes the generator to convert between the two formats so that
beta/RC/alpha versions are installed correctly.

Before this fix:
- Generator would try to install [email protected] (invalid npm version)
- This would fail to match any published version
- yalc link would work, but package.json would have wrong version
- Version checker would then fail due to version mismatch

After this fix:
- Generator converts 16.2.0.beta.10 → 16.2.0-beta.10
- npm installs the correct version
- Version checker validates successfully

The fix also handles both formats as input (dot or hyphen) and normalizes
to the correct npm format.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

lib/generators/react_on_rails/js_dependency_manager.rb

@@ -124,16 +124,32 @@ def add_js_dependencies
 
       def add_react_on_rails_package
         # Use exact version match between gem and npm package for all versions including pre-releases
+        # Ruby gem versions use dots (16.2.0.beta.10) but npm requires hyphens (16.2.0-beta.10)
+        # This method converts between the two formats.
+        #
         # The regex matches:
         # - Stable: 16.2.0
-        # - Beta: 16.2.0-beta.10
-        # - RC: 16.1.0-rc.1
-        # - Alpha: 16.0.0-alpha.5
+        # - Beta (Ruby): 16.2.0.beta.10 or (npm): 16.2.0-beta.10
+        # - RC (Ruby): 16.1.0.rc.1 or (npm): 16.1.0-rc.1
+        # - Alpha (Ruby): 16.0.0.alpha.5 or (npm): 16.0.0-alpha.5
         # This ensures beta/rc versions use the exact version instead of "latest" which would
         # install the latest stable release and cause version mismatches.
-        version_with_optional_prerelease = /\A\d+\.\d+\.\d+(-[a-zA-Z0-9.]+)?\z/
-        react_on_rails_pkg = if ReactOnRails::VERSION.match?(version_with_optional_prerelease)
-                               "react-on-rails@#{ReactOnRails::VERSION}"
+
+        # Accept both dot and hyphen separators for pre-release versions
+        version_with_optional_prerelease = /\A(\d+\.\d+\.\d+)([-.]([a-zA-Z0-9.]+))?\z/
+
+        react_on_rails_pkg = if (match = ReactOnRails::VERSION.match(version_with_optional_prerelease))
+                               base_version = match[1]
+                               prerelease = match[3]
+
+                               # Convert Ruby gem format (dot) to npm semver format (hyphen)
+                               npm_version = if prerelease
+                                               "#{base_version}-#{prerelease}"
+                                             else
+                                               base_version
+                                             end
+
+                               "react-on-rails@#{npm_version}"
                              else
                                puts "WARNING: Unrecognized version format #{ReactOnRails::VERSION}. " \
                                     "Adding the latest react-on-rails NPM module. " \

spec/react_on_rails/generators/js_dependency_manager_spec.rb

@@ -208,19 +208,37 @@ def errors
       expect(mock_manager).to have_received(:add).with(["[email protected]"], exact: true)
     end
 
-    it "adds react-on-rails with version for RC pre-releases" do
+    it "adds react-on-rails with version for RC pre-releases (npm format with hyphen)" do
       stub_const("ReactOnRails::VERSION", "16.0.0-rc.1")
       instance.send(:add_react_on_rails_package)
       expect(mock_manager).to have_received(:add).with(["[email protected]"], exact: true)
     end
 
-    it "adds react-on-rails with version for beta pre-releases" do
+    it "converts Ruby gem beta format to npm format" do
+      stub_const("ReactOnRails::VERSION", "16.2.0.beta.10")
+      instance.send(:add_react_on_rails_package)
+      expect(mock_manager).to have_received(:add).with(["[email protected]"], exact: true)
+    end
+
+    it "converts Ruby gem RC format to npm format" do
+      stub_const("ReactOnRails::VERSION", "16.0.0.rc.1")
+      instance.send(:add_react_on_rails_package)
+      expect(mock_manager).to have_received(:add).with(["[email protected]"], exact: true)
+    end
+
+    it "converts Ruby gem alpha format to npm format" do
+      stub_const("ReactOnRails::VERSION", "16.0.0.alpha.5")
+      instance.send(:add_react_on_rails_package)
+      expect(mock_manager).to have_received(:add).with(["[email protected]"], exact: true)
+    end
+
+    it "accepts npm format beta pre-releases (already with hyphen)" do
       stub_const("ReactOnRails::VERSION", "16.2.0-beta.10")
       instance.send(:add_react_on_rails_package)
       expect(mock_manager).to have_received(:add).with(["[email protected]"], exact: true)
     end
 
-    it "adds react-on-rails with version for alpha releases" do
+    it "accepts npm format alpha releases (already with hyphen)" do
       stub_const("ReactOnRails::VERSION", "16.0.0-alpha.5")
       instance.send(:add_react_on_rails_package)
       expect(mock_manager).to have_received(:add).with(["[email protected]"], exact: true)