Skip to content

Commit 1d42bce

Browse files
justin808claude
andcommitted
Revert pack_generator system call changes to fix test failures
Reverted the array-form system calls back to string form to match the test expectations in pack_generator_spec.rb. This change (commit dabb298) was unrelated to the Shakapacker 9.3.0 upgrade and broke 3 tests: - runs pack generation successfully in verbose mode - runs pack generation successfully in quiet mode - exits with error when pack generation fails The tests expect the old string-based format: system "bundle exec rake react_on_rails:generate_packs" Addresses review comment from @justin808 about unrelated changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 195d04d commit 1d42bce

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

lib/react_on_rails/dev/pack_generator.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,9 @@ def run_rake_task_directly(silent: false)
7373

7474
def run_via_bundle_exec(silent: false)
7575
if silent
76-
system("bundle", "exec", "rake", "react_on_rails:generate_packs", out: File::NULL, err: File::NULL)
76+
system "bundle exec rake react_on_rails:generate_packs > /dev/null 2>&1"
7777
else
78-
system("bundle", "exec", "rake", "react_on_rails:generate_packs")
78+
system "bundle exec rake react_on_rails:generate_packs"
7979
end
8080
end
8181
end

0 commit comments

Comments
 (0)