Fix CI linting and syntax errors

- Fix critical regex syntax error in process_manager.rb (escaped square brackets)
- Consolidate duplicate branch conditions in base_generator.rb and file_manager.rb
- Fix shadowed exception warning in install_generator.rb (use Gem::LoadError only)
- Apply RuboCop auto-corrections for string literals and layout issues
- Improve RSpec spec to avoid stdout/stderr mutation anti-patterns
- Run prettier formatting on all JavaScript/TypeScript files

All RuboCop violations resolved - 134 files inspected, 0 offenses detected.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

lib/generators/react_on_rails/base_generator.rb

@@ -129,10 +129,9 @@ def install_js_dependencies
           run "yarn install"
         elsif File.exist?(File.join(destination_root, "pnpm-lock.yaml"))
           run "pnpm install"
-        elsif File.exist?(File.join(destination_root, "package-lock.json"))
-          run "npm install"
-        elsif File.exist?(File.join(destination_root, "package.json"))
-          # Default to npm if no lock file exists but package.json does
+        elsif File.exist?(File.join(destination_root, "package-lock.json")) ||
+              File.exist?(File.join(destination_root, "package.json"))
+          # Use npm for package-lock.json or as default fallback
           run "npm install"
         end
       end

lib/generators/react_on_rails/install_generator.rb

@@ -121,7 +121,7 @@ def ensure_shakapacker_installed
       def shakapacker_installed?
         Gem::Specification.find_by_name("shakapacker")
         true
-      rescue Gem::MissingSpecError, Gem::LoadError
+      rescue Gem::LoadError
         false
       end
 

lib/react_on_rails/dev/file_manager.rb

@@ -55,14 +55,12 @@ def overmind_running?
         def process_running?(pid)
           Process.kill(0, pid)
           true
-        rescue Errno::ESRCH
+        rescue Errno::ESRCH, ArgumentError, RangeError
+          # Process doesn't exist or invalid PID
           false
         rescue Errno::EPERM
           # Process exists but we don't have permission to signal it
           true
-        rescue ArgumentError, RangeError
-          # Invalid PID (negative, too large, wrong type)
-          false
         end
 
         def remove_file_if_exists(file_path, description)

lib/react_on_rails/dev/process_manager.rb

@@ -5,7 +5,7 @@ module Dev
     class ProcessManager
       class << self
         def installed?(process)
-          IO.popen([process, "-v"]) { |io| io.close }
+          IO.popen([process, "-v"], &:close)
           true
         rescue Errno::ENOENT
           false
@@ -48,11 +48,11 @@ def run_with_process_manager(procfile)
 
         def valid_procfile_path?(procfile)
           # Reject paths with shell metacharacters
-          return false if procfile.match?(/[;&|`$(){}[\]<>]/)
+          return false if procfile.match?(/[;&|`$(){}\[\]<>]/)
 
           # Ensure it's a readable file
           File.readable?(procfile)
-        rescue
+        rescue StandardError
           false
         end
       end

rakelib/run_rspec.rake

@@ -122,10 +122,10 @@ def run_tests_in(dir, options = {})
 
   # Build environment variables as an array for proper spacing
   env_tokens = []
-  env_tokens << options.fetch(:env_vars, '').strip unless options.fetch(:env_vars, '').strip.empty?
+  env_tokens << options.fetch(:env_vars, "").strip unless options.fetch(:env_vars, "").strip.empty?
   env_tokens << "TEST_ENV_COMMAND_NAME=\"#{command_name}\""
   env_tokens << "COVERAGE=true" if ENV["USE_COVERALLS"]
 
-  env_vars = env_tokens.join(' ')
+  env_vars = env_tokens.join(" ")
   sh_in_dir(path.realpath, "#{env_vars} bundle exec rspec #{rspec_args}")
 end

spec/dummy/spec/support/selenium_logger.rb

@@ -39,6 +39,8 @@
         err_msg.include?("This version of ChromeDriver has not been tested with Chrome version")
     end
 
-    raise("JavaScript error#{"s" if clean_errors.length > 0} on the page:\n\n#{clean_errors.join("\n")}") if clean_errors.present?
+    if clean_errors.present?
+      raise("JavaScript error#{'s' unless clean_errors.empty?} on the page:\n\n#{clean_errors.join("\n")}")
+    end
   end
 end

spec/react_on_rails/dev/pack_generator_spec.rb

@@ -4,33 +4,19 @@
 require "react_on_rails/dev/pack_generator"
 
 RSpec.describe ReactOnRails::Dev::PackGenerator do
-  # Suppress stdout/stderr during tests using around hook
-  around do |example|
-    original_stderr = $stderr
-    original_stdout = $stdout
-    begin
-      $stderr = File.open(File::NULL, "w")
-      $stdout = File.open(File::NULL, "w")
-      example.run
-    ensure
-      $stderr = original_stderr
-      $stdout = original_stdout
-    end
-  end
-
   describe ".generate" do
     it "runs pack generation successfully in verbose mode" do
       command = "bundle exec rake react_on_rails:generate_packs"
       allow(Kernel).to receive(:system).with(command).and_return(true)
 
-      expect { described_class.generate(verbose: true) }.not_to raise_error
+      expect { described_class.generate(verbose: true) }.to output.to_stdout_from_any_process
     end
 
     it "runs pack generation successfully in quiet mode" do
       command = "bundle exec rake react_on_rails:generate_packs > /dev/null 2>&1"
       allow(Kernel).to receive(:system).with(command).and_return(true)
 
-      expect { described_class.generate(verbose: false) }.not_to raise_error
+      expect { described_class.generate(verbose: false) }.not_to output.to_stdout_from_any_process
     end
 
     it "exits with error when pack generation fails" do