Refactor validateLicense to void function for clearer API semantics

Author: AbanoubGhadban

react_on_rails_pro/packages/node-renderer/src/master.ts

@@ -7,23 +7,15 @@ import log from './shared/log';
 import { buildConfig, Config, logSanitizedConfig } from './shared/configBuilder';
 import restartWorkers from './master/restartWorkers';
 import * as errorReporter from './shared/errorReporter';
-import { validateLicense, getValidationError } from './shared/licenseValidator';
+import { validateLicense } from './shared/licenseValidator';
 
 const MILLISECONDS_IN_MINUTE = 60000;
 
 export = function masterRun(runningConfig?: Partial<Config>) {
   // Validate license before starting - required in all environments
   log.info('[React on Rails Pro] Validating license...');
-
-  if (validateLicense()) {
-    log.info('[React on Rails Pro] License validation successful');
-  } else {
-    // License validation already calls process.exit(1) in handleInvalidLicense
-    // But we add this for safety in case the validator changes
-    const error = getValidationError() || 'Invalid license';
-    log.error(`[React on Rails Pro] ${error}`);
-    process.exit(1);
-  }
+  validateLicense();
+  log.info('[React on Rails Pro] License validation successful');
 
   // Store config in app state. From now it can be loaded by any module using getConfig():
   const config = buildConfig(runningConfig);

react_on_rails_pro/packages/node-renderer/src/shared/licenseValidator.ts

@@ -19,19 +19,17 @@ let cachedLicenseData: LicenseData | undefined;
 let cachedValidationError: string | undefined;
 
 /**
- * Validates the license and raises an error if invalid.
+ * Validates the license and exits the process if invalid.
  * Caches the result after first validation.
  *
- * @returns true if license is valid
  * @throws Exits process if license is invalid
  */
-export function validateLicense(): boolean {
+export function validateLicense(): void {
   if (cachedValid !== undefined) {
-    return cachedValid;
+    return;
   }
 
   cachedValid = performValidation();
-  return cachedValid;
 }
 
 /**

react_on_rails_pro/packages/node-renderer/tests/licenseValidator.test.ts

@@ -75,7 +75,7 @@ describe('LicenseValidator', () => {
   });
 
   describe('validateLicense', () => {
-    it('returns true for valid license in ENV', () => {
+    it('validates successfully for valid license in ENV', () => {
       const validPayload = {
         sub: '[email protected]',
         iat: Math.floor(Date.now() / 1000),
@@ -86,7 +86,8 @@ describe('LicenseValidator', () => {
       process.env.REACT_ON_RAILS_PRO_LICENSE = validToken;
 
       const module = require('../src/shared/licenseValidator');
-      expect(module.validateLicense()).toBe(true);
+      expect(() => module.validateLicense()).not.toThrow();
+      expect(process.exit).not.toHaveBeenCalled();
     });
 
     it('calls process.exit for expired license', () => {
@@ -192,7 +193,8 @@ describe('LicenseValidator', () => {
       // Reset to pick up the new ENV variable
       reset();
 
-      expect(module.validateLicense()).toBe(true);
+      expect(() => module.validateLicense()).not.toThrow();
+      expect(process.exit).not.toHaveBeenCalled();
     });
 
     it('caches validation result', () => {
@@ -208,13 +210,15 @@ describe('LicenseValidator', () => {
       const module = require('../src/shared/licenseValidator');
 
       // First call
-      expect(module.validateLicense()).toBe(true);
+      module.validateLicense();
+      expect(process.exit).not.toHaveBeenCalled();
 
       // Change ENV (shouldn't affect cached result)
       delete process.env.REACT_ON_RAILS_PRO_LICENSE;
 
-      // Second call should use cache
-      expect(module.validateLicense()).toBe(true);
+      // Second call should use cache and not fail
+      module.validateLicense();
+      expect(process.exit).not.toHaveBeenCalled();
     });
   });