Complete linting fixes for doctor functionality

- Fix Rainbow fallback implementation and method signatures
- Fix self-assignment and shadowed exception issues
- Fix method naming (remove has_/get_ prefixes)
- Add rubocop disable comments for incremental complexity issues
- Update spec tests to match renamed methods

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

lib/react_on_rails/doctor.rb

@@ -8,20 +8,22 @@
   require "rainbow"
 rescue LoadError
   # Fallback if Rainbow is not available - define Kernel-level Rainbow method
+  # rubocop:disable Naming/MethodName
   def Rainbow(text)
     SimpleColorWrapper.new(text)
   end
+  # rubocop:enable Naming/MethodName
 
   class SimpleColorWrapper
     def initialize(text)
       @text = text
     end
 
-    def method_missing(method, *args)
+    def method_missing(_method, *_args)
       self
     end
 
-    def respond_to_missing?(method, include_private = false)
+    def respond_to_missing?(_method, _include_private = false)
       true
     end
 
@@ -331,6 +333,7 @@ def should_show_recommendations?
       checker.errors? || checker.warnings?
     end
 
+    # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
     def print_next_steps
       puts Rainbow("Next Steps:").blue.bold
 
@@ -373,6 +376,7 @@ def print_next_steps
       puts "• Documentation: https://github.com/shakacode/react_on_rails"
       puts
     end
+    # rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
 
     def npm_test_script?
       return false unless File.exist?("package.json")
@@ -398,7 +402,7 @@ def determine_server_bundle_path
       # Get the source path relative to Rails root
       source_path = Shakapacker.config.source_path.to_s
       source_entry_path = Shakapacker.config.source_entry_path.to_s
-      server_bundle_filename = server_bundle_filename
+      bundle_filename = server_bundle_filename
       rails_root = Dir.pwd
 
       # Convert absolute paths to relative paths
@@ -416,11 +420,11 @@ def determine_server_bundle_path
         source_entry_path = source_entry_path.sub("#{source_path}/", "")
       end
 
-      File.join(source_path, source_entry_path, server_bundle_filename)
-    rescue LoadError, NameError, StandardError
-      # Fallback to default paths if Shakapacker is not available or configured
-      server_bundle_filename = get_server_bundle_filename
-      "app/javascript/packs/#{server_bundle_filename}"
+      File.join(source_path, source_entry_path, bundle_filename)
+    rescue StandardError
+      # Handle missing Shakapacker gem or other configuration errors
+      bundle_filename = server_bundle_filename
+      "app/javascript/packs/#{bundle_filename}"
     end
 
     def server_bundle_filename

lib/react_on_rails/system_checker.rb

@@ -387,6 +387,7 @@ def check_version_patterns(npm_version, gem_version)
       MSG
     end
 
+    # rubocop:disable Metrics/CyclomaticComplexity
     def check_gemfile_version_patterns
       gemfile_path = ENV["BUNDLE_GEMFILE"] || "Gemfile"
       return unless File.exist?(gemfile_path)
@@ -417,6 +418,7 @@ def check_gemfile_version_patterns
         # Ignore errors reading Gemfile
       end
     end
+    # rubocop:enable Metrics/CyclomaticComplexity
 
     def report_dependency_versions(package_json)
       all_deps = package_json["dependencies"]&.merge(package_json["devDependencies"] || {}) || {}

spec/lib/react_on_rails/doctor_spec.rb

@@ -28,7 +28,7 @@
 
       # Mock the new server bundle path methods
       allow(doctor).to receive_messages("`": "", determine_server_bundle_path: "app/javascript/packs/server-bundle.js",
-                                        get_server_bundle_filename: "server-bundle.js", has_npm_test_script?: false, has_yarn_test_script?: false)
+                                        server_bundle_filename: "server-bundle.js", npm_test_script?: false, yarn_test_script?: false)
 
       # Mock the checker to avoid actual system calls
       checker = instance_double(ReactOnRails::SystemChecker)