Handle empty inputs correctly

Author: alexeyr

.github/workflows/benchmark.yml

@@ -72,17 +72,17 @@ env:
   FORTIO_VERSION: "1.73.0"
   K6_VERSION: "1.3.0"
   VEGETA_VERSION: "12.13.0"
-  # Benchmark parameters
+  # Benchmark parameters (defaults in bench.rb unless overridden here for CI)
   ROUTES: ${{ github.event.inputs.routes }}
   RATE: ${{ github.event.inputs.rate || 'max' }}
-  DURATION: ${{ github.event.inputs.duration || '30s' }}
-  REQUEST_TIMEOUT: ${{ github.event.inputs.request_timeout || '60s' }}
-  CONNECTIONS: ${{ github.event.inputs.connections || 10 }}
-  MAX_CONNECTIONS: ${{ github.event.inputs.connections || 10 }}
+  DURATION: ${{ github.event.inputs.duration }}
+  REQUEST_TIMEOUT: ${{ github.event.inputs.request_timeout }}
+  CONNECTIONS: ${{ github.event.inputs.connections }}
+  MAX_CONNECTIONS: ${{ github.event.inputs.connections }}
   WEB_CONCURRENCY: ${{ github.event.inputs.web_concurrency || 4 }}
   RAILS_MAX_THREADS: ${{ github.event.inputs.rails_threads || 3 }}
   RAILS_MIN_THREADS: ${{ github.event.inputs.rails_threads || 3 }}
-  TOOLS: ${{ github.event.inputs.tools || 'fortio,vegeta,k6' }}
+  TOOLS: ${{ github.event.inputs.tools }}
 
 jobs:
   benchmark:

spec/performance/bench.rb

@@ -7,23 +7,30 @@
 require "net/http"
 require "uri"
 
+# Helper to get env var with default,
+# treating empty string and "0" as unset since they can come from the benchmark workflow.
+def env_or_default(key, default)
+  value = ENV[key].to_s
+  value.empty? || value == "0" ? default : value
+end
+
 # Benchmark parameters
 PRO = ENV.fetch("PRO", "false") == "true"
 APP_DIR = PRO ? "react_on_rails_pro/spec/dummy" : "spec/dummy"
-ROUTES = ENV.fetch("ROUTES", nil)
-BASE_URL = ENV.fetch("BASE_URL", "localhost:3001")
+ROUTES = env_or_default("ROUTES", nil)
+BASE_URL = env_or_default("BASE_URL", "localhost:3001")
 # requests per second; if "max" will get maximum number of queries instead of a fixed rate
-RATE = ENV.fetch("RATE", "50")
+RATE = env_or_default("RATE", "50")
 # concurrent connections/virtual users
-CONNECTIONS = ENV.fetch("CONNECTIONS", "10").to_i
+CONNECTIONS = env_or_default("CONNECTIONS", 10).to_i
 # maximum connections/virtual users
-MAX_CONNECTIONS = ENV.fetch("MAX_CONNECTIONS", CONNECTIONS).to_i
+MAX_CONNECTIONS = env_or_default("MAX_CONNECTIONS", CONNECTIONS).to_i
 # benchmark duration (duration string like "30s", "1m", "90s")
-DURATION = ENV.fetch("DURATION", "30s")
+DURATION = env_or_default("DURATION", "30s")
 # request timeout (duration string as above)
-REQUEST_TIMEOUT = ENV.fetch("REQUEST_TIMEOUT", "60s")
+REQUEST_TIMEOUT = env_or_default("REQUEST_TIMEOUT", "60s")
 # Tools to run (comma-separated)
-TOOLS = ENV.fetch("TOOLS", "fortio,vegeta,k6").split(",")
+TOOLS = env_or_default("TOOLS", "fortio,vegeta,k6").split(",")
 
 OUTDIR = "bench_results"
 SUMMARY_TXT = "#{OUTDIR}/summary.txt".freeze
@@ -93,11 +100,13 @@ def get_benchmark_routes(app_dir)
 # Get all routes to benchmark
 routes =
   if ROUTES
-    ROUTES.split(",").map(&:strip)
+    ROUTES.split(",").map(&:strip).reject(&:empty?)
   else
     get_benchmark_routes(APP_DIR)
   end
 
+raise "No routes to benchmark" if routes.empty?
+
 validate_rate(RATE)
 validate_positive_integer(CONNECTIONS, "CONNECTIONS")
 validate_positive_integer(MAX_CONNECTIONS, "MAX_CONNECTIONS")