Remove unnecessary build-core-package job and workspace sharing

Since link-source scripts now handle building and yalc publishing:
- Remove build-core-package job (no longer needed)
- Remove all build-core-package dependencies from workflow
- Remove workspace sharing (yalc handles package distribution)
- Keep existing cache strategy for node_modules directories
- Simplify CircleCI workflow to rely on preinstall hooks

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: AbanoubGhadban

.circleci/config.yml

@@ -125,35 +125,13 @@ aliases:
         echo -e "\nInstalled $(google-chrome --version)"
       fi
 
-  # Build core React on Rails package for pro package to use
-  - &build-core-package
-    name: Build core React on Rails package
-    command: |
-      yarn install --frozen-lockfile --no-progress --no-emoji
-      yarn run build
-
 jobs:
-  # Build core React on Rails package
-  build-core-package:
-    docker:
-      - image: &docker_image cimg/ruby:3.3.7-browsers
-    steps:
-      - checkout
-      - run: *print-system-info
-      - run: *build-core-package
-      - persist_to_workspace:
-          root: .
-          paths:
-            - node_package/lib
-
   # Lint all
   lint-js-and-ruby:
     docker:
       - image: &docker_image cimg/ruby:3.3.7-browsers
     steps:
       - checkout
-      - attach_workspace:
-          at: .
       - run: *print-system-info
       - restore_cache: *restore-package-node-modules-cache
       - restore_cache: *restore-package-gem-cache
@@ -180,8 +158,6 @@ jobs:
       - image: *docker_image
     steps:
       - checkout
-      - attach_workspace:
-          at: .
       - run: *print-system-info
       - restore_cache: *restore-package-node-modules-cache
       - run: *install-package-node-modules
@@ -197,8 +173,6 @@ jobs:
       - image: *docker_image
     steps:
       - checkout
-      - attach_workspace:
-          at: .
       - run: *print-system-info
       - restore_cache: *restore-dummy-app-node-modules-cache
       - run: *install-package-node-modules
@@ -215,8 +189,6 @@ jobs:
       - image: *docker_image
     steps:
       - checkout
-      - attach_workspace:
-          at: .
       - run: *print-system-info
       - restore_cache: *restore-package-gem-cache
       - run: *install-package-ruby-gems
@@ -232,8 +204,6 @@ jobs:
       - image: *docker_image
     steps:
       - checkout
-      - attach_workspace:
-          at: .
       - run: *print-system-info
       - restore_cache: *restore-dummy-app-gem-cache
       - run: *install-dummy-app-ruby-gems
@@ -251,8 +221,6 @@ jobs:
       - image: *docker_image
     steps:
       - checkout
-      - attach_workspace:
-          at: .
       - run: *print-system-info
       - restore_cache: *restore-package-node-modules-cache
       - restore_cache: *restore-dummy-app-node-modules-cache
@@ -278,8 +246,6 @@ jobs:
       - image: *docker_image
     steps:
       - checkout
-      - attach_workspace:
-          at: .
       - run: *print-system-info
       - restore_cache: *restore-package-node-modules-cache
       - run: rm -rf react_on_rails_pro/spec/dummy/public/webpack
@@ -302,8 +268,6 @@ jobs:
       - image: *docker_image
     steps:
       - checkout
-      - attach_workspace:
-          at: .
       - run: *print-system-info
       - restore_cache: *restore-package-gem-cache
       - run: *install-package-ruby-gems
@@ -327,8 +291,6 @@ jobs:
       - image: *docker_image
     steps:
       - checkout
-      - attach_workspace:
-          at: .
       - run: *print-system-info
       - restore_cache: *restore-package-gem-cache
       - restore_cache: *restore-package-node-modules-cache
@@ -385,42 +347,30 @@ workflows:
   version: 2
   build-and-test:
     jobs:
-      - build-core-package
-      - install-package-node-packages:
-          requires:
-            - build-core-package
-      - install-package-ruby-gems:
-          requires:
-            - build-core-package
+      - install-package-node-packages
+      - install-package-ruby-gems
       - install-dummy-app-node-packages:
           requires:
             - install-package-node-packages
-      - install-dummy-app-ruby-gems:
-          requires:
-            - build-core-package
+      - install-dummy-app-ruby-gems
       - lint-js-and-ruby:
           requires:
-            - build-core-package
             - install-package-node-packages
             - install-package-ruby-gems
             - install-dummy-app-node-packages
       - build-dummy-app-webpack-test-bundles:
           requires:
-            - build-core-package
             - install-package-node-packages
             - install-dummy-app-node-packages
             - install-dummy-app-ruby-gems
       - package-js-tests:
           requires:
-            - build-core-package
             - install-package-node-packages
             - build-dummy-app-webpack-test-bundles
       - rspec-package-specs:
           requires:
-            - build-core-package
             - install-package-ruby-gems
       - rspec-dummy-app-node-renderer:
           requires:
-            - build-core-package
             - install-package-ruby-gems
             - build-dummy-app-webpack-test-bundles

react_on_rails_pro/package.json

@@ -85,7 +85,7 @@
     "nps": "^5.9.12",
     "pino-pretty": "^13.0.0",
     "prettier": "^3.2.5",
-    "react-on-rails": "file:../",
+    "react-on-rails": "link:.yalc/react-on-rails",
     "redis": "^5.0.1",
     "release-it": "^17.6.0",
     "sentry-testkit": "^5.0.6",
@@ -114,8 +114,9 @@
     "packages/node-renderer/dist"
   ],
   "scripts": {
+    "preinstall": "yarn run link-source && yalc add --link react-on-rails",
     "postinstall": "test -f post-yarn-install.local && ./post-yarn-install.local || true",
-    "link-source": "cd ../ && yarn && yarn run build && cd node_package && yalc publish && cd ../react_on_rails_pro && yarn && yarn run nps build && yalc publish",
+    "link-source": "cd ../ && yarn && yalc publish",
     "test": "nps test",
     "prepack": "nps build.prepack",
     "prepare": "nps build.prepack",

react_on_rails_pro/spec/dummy/package.json

@@ -96,7 +96,7 @@
     "test": "yarn run build:test && yarn run lint && rspec",
     "lint": "cd ../.. && nps lint",
     "preinstall": "yarn run link-source && yalc add --link react-on-rails && yalc add --link @shakacode-tools/react-on-rails-pro-node-renderer",
-    "link-source": "cd ../../../ && yarn && yarn run build && cd node_package && yalc publish && cd ../react_on_rails_pro && yarn && yarn run nps build && yalc publish",
+    "link-source": "cd ../.. && yarn && yarn run nps build && yalc publish",
     "postinstall": "test -f post-yarn-install.local && ./post-yarn-install.local || true",
     "build:test": "rm -rf public/webpack/test && rm -rf ssr-generated && RAILS_ENV=test NODE_ENV=test bin/shakapacker",
     "build:dev": "rm -rf public/webpack/development && rm -rf ssr-generated && RAILS_ENV=development NODE_ENV=development bin/shakapacker",

react_on_rails_pro/spec/dummy/yarn.lock

@@ -5353,8 +5353,9 @@ react-on-rails-rsc@^19.0.2:
     neo-async "^2.6.1"
     webpack-sources "^3.2.0"
 
-"react-on-rails@file:..":
+"react-on-rails@link:.yalc/react-on-rails":
   version "0.0.0"
+  uid ""
 
 react-proptypes@^1.0.0:
   version "1.0.0"

react_on_rails_pro/yarn.lock

@@ -6843,8 +6843,9 @@ react-is@^18.0.0:
   resolved "https://registry.yarnpkg.com/react-is/-/react-is-18.3.1.tgz#e83557dc12eae63a99e003a46388b1dcbb44db7e"
   integrity sha512-/LLMVyas0ljjAtoYiPqYiL8VWXzUUdThrmU5+n20DZv+a+ClRoevUzw5JxU+Ieh5/c87ytoTBV9G1FiKfNJdmg==
 
-"react-on-rails@file:..":
-  version "16.1.1"
+"react-on-rails@link:.yalc/react-on-rails":
+  version "0.0.0"
+  uid ""
 
 readable-stream@^2.2.2:
   version "2.3.8"