Fix shakapacker hook detection to support symbol keys and prevent false positives

Improvements:
- Support both symbol and string keys in config data (shakapacker uses symbols internally)
- Use word boundary regex to prevent matching similar task names
- Add safe navigation operator for better nil handling
- Document why private :data method is accessed
- Add tests for both key types and false positive prevention

This ensures the hook detection works correctly with shakapacker's actual config format.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

lib/react_on_rails/packer_utils.rb

@@ -172,13 +172,18 @@ def self.raise_shakapacker_version_incompatible_for_basic_pack_generation
     def self.shakapacker_precompile_hook_configured?
       return false unless defined?(::Shakapacker)
 
+      # Access config data using private :data method since there's no public API
+      # to access the raw configuration hash needed for hook detection
       config_data = ::Shakapacker.config.send(:data)
-      hooks = config_data.dig("hooks", "precompile")
 
-      return false unless hooks
+      # Try symbol keys first (Shakapacker's internal format), then fall back to string keys
+      hooks = config_data&.dig(:hooks, :precompile) || config_data&.dig("hooks", "precompile")
 
-      # Check if any hook contains the generate_packs rake task
-      Array(hooks).any? { |hook| hook.to_s.include?("react_on_rails:generate_packs") }
+      return false if hooks.nil?
+
+      # Check if any hook contains the generate_packs rake task using word boundary
+      # to avoid false positives from comments or similar strings
+      Array(hooks).any? { |hook| hook.to_s.match?(/\breact_on_rails:generate_packs\b/) }
     rescue StandardError
       false
     end

spec/react_on_rails/packer_utils_spec.rb

@@ -2,6 +2,7 @@
 
 require_relative "spec_helper"
 
+# rubocop:disable Metrics/ModuleLength
 module ReactOnRails
   describe PackerUtils do
     describe ".shakapacker_version_requirement_met?" do
@@ -158,7 +159,15 @@ module ReactOnRails
       end
 
       context "when precompile hook contains react_on_rails:generate_packs" do
-        it "returns true for single hook" do
+        it "returns true for single hook with symbol keys" do
+          allow(mock_config).to receive(:send).with(:data).and_return(
+            { hooks: { precompile: "bundle exec rake react_on_rails:generate_packs" } }
+          )
+
+          expect(described_class.shakapacker_precompile_hook_configured?).to be(true)
+        end
+
+        it "returns true for single hook with string keys" do
           allow(mock_config).to receive(:send).with(:data).and_return(
             { "hooks" => { "precompile" => "bundle exec rake react_on_rails:generate_packs" } }
           )
@@ -168,7 +177,7 @@ module ReactOnRails
 
         it "returns true for hook in array" do
           allow(mock_config).to receive(:send).with(:data).and_return(
-            { "hooks" => { "precompile" => ["bundle exec rake react_on_rails:generate_packs", "echo done"] } }
+            { hooks: { precompile: ["bundle exec rake react_on_rails:generate_packs", "echo done"] } }
           )
 
           expect(described_class.shakapacker_precompile_hook_configured?).to be(true)
@@ -178,7 +187,15 @@ module ReactOnRails
       context "when precompile hook does not contain react_on_rails:generate_packs" do
         it "returns false for different hook" do
           allow(mock_config).to receive(:send).with(:data).and_return(
-            { "hooks" => { "precompile" => "bundle exec rake some_other_task" } }
+            { hooks: { precompile: "bundle exec rake some_other_task" } }
+          )
+
+          expect(described_class.shakapacker_precompile_hook_configured?).to be(false)
+        end
+
+        it "returns false for similar but different task name" do
+          allow(mock_config).to receive(:send).with(:data).and_return(
+            { hooks: { precompile: "bundle exec rake react_on_rails:generate_packs_extra" } }
           )
 
           expect(described_class.shakapacker_precompile_hook_configured?).to be(false)
@@ -191,7 +208,7 @@ module ReactOnRails
         end
 
         it "returns false when precompile hook is nil" do
-          allow(mock_config).to receive(:send).with(:data).and_return({ "hooks" => {} })
+          allow(mock_config).to receive(:send).with(:data).and_return({ hooks: {} })
 
           expect(described_class.shakapacker_precompile_hook_configured?).to be(false)
         end
@@ -238,3 +255,4 @@ module ReactOnRails
     end
   end
 end
+# rubocop:enable Metrics/ModuleLength