Refactor bin/dev to use ReactOnRails::Dev classes with clear Procfile management

This commit significantly refactors the bin/dev development server script to improve
maintainability, testing, and user experience with clear Procfile documentation.

## Key Changes

### 🏗️ **Architecture Improvements**
- **Extracted bin/dev logic** into `ReactOnRails::Dev` module classes:
  - `ServerManager` - Main server orchestration and command routing
  - `ProcessManager` - Overmind/Foreman process management
  - `PackGenerator` - React on Rails pack generation
  - `FileManager` - Cleanup of stale socket/pid files
- **Modular design** allows for easy extension and testing
- **Clean API** for programmatic usage: `ReactOnRails::Dev::ServerManager.start(:mode, "procfile")`

### 📋 **Clear Procfile Management**
- **Explicit Procfile mapping** for each command:
  - `bin/dev` (HMR) → `Procfile.dev`
  - `bin/dev static` → `Procfile.dev-static-assets`
  - `bin/dev prod` → `Procfile.dev-prod-assets`
- **Prominent boxed display** shows which Procfile is being used:
  ```
  ┌──────────────────────────────────────────────────────────┐
  │ 📋 Using Procfile: Procfile.dev                          │
  │ 💡 Access at: http://localhost:3000                      │
  │ 🔧 Customize this file for your app's needs              │
  └──────────────────────────────────────────────────────────┘
  ```
- **Port information** prominently displayed (3000 for dev/static, 3001 for prod)

### ✅ **Fixed Pack Generation**
- **Single pack generation** per mode (eliminates duplication)
- **Clean shakapacker binstubs** - removed React on Rails specific code
- **Proper execution order**: Pack generation → Procfile start
- **Maintainable approach** - no custom webpack binary modifications

### 📚 **Enhanced Documentation**
- **Comprehensive help** shows Procfile mapping and customization options
- **Clear comments** in bin/dev explain customization hierarchy
- **Process manager detection** in installation success message

### 🧪 **Testing Infrastructure**
- **Complete RSpec test suite** for all ReactOnRails::Dev classes
- **Isolated unit tests** with proper mocking
- **Updated existing tests** to work with new architecture

## Breaking Changes
None - bin/dev commands work identically to before.

## Migration Path
Existing bin/dev usage remains unchanged. For advanced customization:
1. Edit appropriate Procfile (recommended)
2. Modify bin/dev script for project-specific behavior
3. Extend ReactOnRails::Dev classes for advanced customization

## Benefits
- **🔧 Clear customization path** via Procfiles
- **🧹 Cleaner codebase** with separated concerns
- **🧪 Testable components** with full RSpec coverage
- **📖 Better documentation** and user guidance
- **⚡ Improved development experience** with prominent UI

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

lib/generators/react_on_rails/adapt_for_older_shakapacker_generator.rb

@@ -7,6 +7,7 @@ module ReactOnRails
   module Generators
     class AdaptForOlderShakapackerGenerator < Rails::Generators::Base
       include GeneratorHelper
+
       Rails::Generators.hide_namespace(namespace)
 
       def change_spelling_to_webpacker

lib/generators/react_on_rails/base_generator.rb

@@ -7,6 +7,7 @@ module ReactOnRails
   module Generators
     class BaseGenerator < Rails::Generators::Base
       include GeneratorHelper
+
       Rails::Generators.hide_namespace(namespace)
       source_root(File.expand_path("templates", __dir__))
 
@@ -33,6 +34,7 @@ def copy_base_files
         base_path = "base/base/"
         base_files = %w[app/controllers/hello_world_controller.rb
                         app/views/layouts/hello_world.html.erb
+                        bin/dev
                         Procfile.dev
                         Procfile.dev-static-assets
                         Procfile.dev-prod-assets]
@@ -258,7 +260,6 @@ def append_to_spec_rails_helper
           if File.exist?(spec_helper)
             add_configure_rspec_to_compile_assets(spec_helper)
           else
-            # rubocop:disable Layout/EmptyLinesAroundArguments
             GeneratorMessages.add_info(
               <<-MSG.strip_heredoc
 
@@ -271,8 +272,6 @@ def append_to_spec_rails_helper
               ReactOnRails::TestHelper.configure_rspec_to_compile_assets(config)
               MSG
             )
-            # rubocop:enable Layout/EmptyLinesAroundArguments
-
           end
         end
       end

lib/generators/react_on_rails/bin/dev

@@ -1,259 +1,44 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
-require "English"
-
-def installed?(process)
-  IO.popen "#{process} -v"
-rescue Errno::ENOENT
-  false
-end
-
-def generate_packs
-  puts "📦 Generating React on Rails packs..."
-  system "bundle exec rake react_on_rails:generate_packs"
-
-  return if $CHILD_STATUS.success?
-
-  puts "❌ Pack generation failed"
-  exit 1
-end
-
-def ensure_procfile(procfile)
-  return if File.exist?(procfile)
-
-  warn <<~MSG
-    ERROR:
-    Please ensure `#{procfile}` exists in your project!
-  MSG
-  exit 1
-end
-
-def cleanup_stale_files
-  cleaned_any = false
-
-  # Check for stale overmind socket files
-  socket_files = [".overmind.sock", "tmp/sockets/overmind.sock"]
-
-  # Only clean up if overmind is not actually running
-  overmind_pids = `pgrep -f "overmind" 2>/dev/null`.split("\n").map(&:to_i)
-
-  if overmind_pids.empty?
-    socket_files.each do |socket_file|
-      if File.exist?(socket_file)
-        puts "   🧹 Cleaning up stale socket: #{socket_file}"
-        File.delete(socket_file) rescue nil
-        cleaned_any = true
-      end
-    end
-  end
-
-  # Check for stale Rails server.pid file
-  server_pid_file = "tmp/pids/server.pid"
-  if File.exist?(server_pid_file)
-    pid = File.read(server_pid_file).to_i
-    # Check if process is actually running
-    begin
-      Process.kill(0, pid)
-      # Process exists, don't clean up
-    rescue Errno::ESRCH
-      # Process doesn't exist, clean up stale pid file
-      puts "   🧹 Cleaning up stale Rails pid file: #{server_pid_file}"
-      File.delete(server_pid_file) rescue nil
-      cleaned_any = true
-    end
-  end
-
-  cleaned_any
-end
-
-def run_with_process_manager(procfile)
-  # Clean up stale files before starting
-  cleanup_stale_files
-
-  if installed?("overmind")
-    system "overmind start -f #{procfile}"
-  elsif installed?("foreman")
-    system "foreman start -f #{procfile}"
-  else
-    warn <<~MSG
-      NOTICE:
-      For this script to run, you need either 'overmind' or 'foreman' installed on your machine. Please try this script after installing one of them.
-    MSG
-    exit 1
-  end
-end
-
-def print_server_info(title, features, port = 3000)
-  puts "#{title}"
-  features.each { |feature| puts "   - #{feature}" }
-  puts ""
-  puts "💡 Access at: http://localhost:#{port}"
-  puts ""
-end
-
-def run_production_like
-  print_server_info(
-    "🏭 Starting production-like development server...",
-    [
-      "Generating React on Rails packs",
-      "Precompiling assets with production optimizations",
-      "Running Rails server on port 3001",
-      "No HMR (Hot Module Replacement)",
-      "CSS extracted to separate files (no FOUC)"
-    ],
-    3001
-  )
-
-  generate_packs
-
-  # Precompile assets in production mode
-  puts "🔨 Precompiling assets..."
-  system "RAILS_ENV=production NODE_ENV=production bundle exec rails assets:precompile"
-
-  if $CHILD_STATUS.success?
-    puts "✅ Assets precompiled successfully"
-    puts "🚀 Starting Rails server in production mode..."
-    puts ""
-    puts "Press Ctrl+C to stop the server"
-    puts "To clean up: rm -rf public/packs && bin/dev"
-    puts ""
-
-    # Start Rails in production mode
-    system "RAILS_ENV=production bundle exec rails server -p 3001"
-  else
-    puts "❌ Asset precompilation failed"
-    exit 1
-  end
-end
-
-def run_static_development
-  print_server_info(
-    "⚡ Starting development server with static assets...",
-    [
-      "Generating React on Rails packs",
-      "Using shakapacker --watch (no HMR)",
-      "CSS extracted to separate files (no FOUC)",
-      "Development environment (source maps, faster builds)",
-      "Auto-recompiles on file changes"
-    ]
-  )
-
-  generate_packs
-
-  procfile = "Procfile.dev-static-assets"
-  ensure_procfile(procfile)
-  run_with_process_manager(procfile)
-end
-
-def run_development
-  generate_packs
-
-  procfile = "Procfile.dev"
-  ensure_procfile(procfile)
-  run_with_process_manager(procfile)
-end
-
-def kill_processes
-  puts "🔪 Killing all development processes..."
-  puts ""
-
-  processes = {
-    "rails" => "Rails server",
-    "node.*react[-_]on[-_]rails" => "React on Rails Node processes",
-    "overmind" => "Overmind process manager",
-    "foreman" => "Foreman process manager",
-    "ruby.*puma" => "Puma server",
-    "webpack-dev-server" => "Webpack dev server",
-    "bin/shakapacker-dev-server" => "Shakapacker dev server"
-  }
-
-  killed_any = false
-
-  processes.each do |pattern, description|
-    pids = `pgrep -f "#{pattern}" 2>/dev/null`.split("\n").map(&:to_i).reject { |pid| pid == Process.pid }
-
-    if pids.any?
-      puts "   ☠️  Killing #{description} (PIDs: #{pids.join(', ')})"
-      pids.each { |pid| Process.kill("TERM", pid) rescue nil }
-      killed_any = true
-    end
-  end
-
-  # Clean up socket and pid files
-  cleanup_files = [
-    ".overmind.sock",
-    "tmp/sockets/overmind.sock",
-    "tmp/pids/server.pid"
-  ]
-
-  cleanup_files.each do |file|
-    if File.exist?(file)
-      puts "   🧹 Removing #{file}"
-      File.delete(file) rescue nil
-      killed_any = true
-    end
-  end
-
-  if killed_any
-    puts ""
-    puts "✅ All processes terminated and sockets cleaned"
-    puts "💡 You can now run 'bin/dev' for a clean start"
-  else
-    puts "   ℹ️  No development processes found running"
-  end
-end
-
-def show_help
-  puts <<~HELP
-    Usage: bin/dev [command]
-
-    Commands:
-      (none) / hmr        Start development server with HMR (default)
-      static              Start development server with static assets (no HMR, no FOUC)
-      production-assets   Start with production-optimized assets (no HMR)
-      prod                Alias for production-assets
-      kill                Kill all development processes for a clean start
-      help                Show this help message
-    #{'  '}
-    HMR Development mode (default):
-    • Hot Module Replacement (HMR) enabled
-    • Automatic React on Rails pack generation
-    • Source maps for debugging
-    • May have Flash of Unstyled Content (FOUC)
-    • Fast recompilation
-    • Access at: http://localhost:3000
-
-    Static development mode:
-    • No HMR (static assets with auto-recompilation)
-    • Automatic React on Rails pack generation
-    • CSS extracted to separate files (no FOUC)
-    • Development environment (faster builds than production)
-    • Source maps for debugging
-    • Access at: http://localhost:3000
-
-    Production-assets mode:
-    • Automatic React on Rails pack generation
-    • Optimized, minified bundles
-    • Extracted CSS files (no FOUC)
-    • No HMR (static assets)
-    • Slower recompilation
-    • Access at: http://localhost:3001
-  HELP
+# ReactOnRails Development Server
+#
+# This script provides a simple interface to the ReactOnRails development
+# server management. The core logic is implemented in ReactOnRails::Dev
+# classes for better maintainability and testing.
+#
+# Each command uses a specific Procfile for process management:
+# - bin/dev (default/hmr): Uses Procfile.dev
+# - bin/dev static: Uses Procfile.dev-static-assets
+# - bin/dev prod: Uses Procfile.dev-prod-assets
+#
+# To customize development environment:
+# 1. Edit the appropriate Procfile to modify which processes run
+# 2. Modify this script for project-specific command-line behavior
+# 3. Extend ReactOnRails::Dev classes in your Rails app for advanced customization
+# 4. Use classes directly: ReactOnRails::Dev::ServerManager.start(:development, "Custom.procfile")
+
+begin
+  require "bundler/setup"
+  require "react_on_rails/dev"
+rescue LoadError
+  # Fallback for when gem is not yet installed
+  puts "Loading ReactOnRails development tools..."
+  require_relative "../../../react_on_rails/dev"
 end
 
 # Main execution
 case ARGV[0]
 when "production-assets", "prod"
-  run_production_like
+  ReactOnRails::Dev::ServerManager.start(:production_like)
 when "static"
-  run_static_development
+  ReactOnRails::Dev::ServerManager.start(:static, "Procfile.dev-static-assets")
 when "kill"
-  kill_processes
+  ReactOnRails::Dev::ServerManager.kill_processes
 when "help", "--help", "-h"
-  show_help
+  ReactOnRails::Dev::ServerManager.show_help
 when "hmr", nil
-  run_development
+  ReactOnRails::Dev::ServerManager.start(:development, "Procfile.dev")
 else
   puts "Unknown argument: #{ARGV[0]}"
   puts "Run 'bin/dev help' for usage information"

lib/generators/react_on_rails/dev_tests_generator.rb

@@ -7,6 +7,7 @@ module ReactOnRails
   module Generators
     class DevTestsGenerator < Rails::Generators::Base
       include GeneratorHelper
+
       Rails::Generators.hide_namespace(namespace)
       source_root(File.expand_path("templates/dev_tests", __dir__))