File tree Expand file tree Collapse file tree 2 files changed +5
-3
lines changed Expand file tree Collapse file tree 2 files changed +5
-3
lines changed Original file line number Diff line number Diff line change @@ -55,7 +55,7 @@ class PlainReactOnRailsHelper
5555 expect ( helper ) . to have_received ( :append_javascript_pack_tag ) . with ( "generated/component_name" , { defer : false } )
5656 else
5757 expect ( helper ) . to have_received ( :append_javascript_pack_tag )
58- . with ( "generated/component_name" , { defer : false , async : true } )
58+ . with ( "generated/component_name" , { defer : false , async : true } )
5959 end
6060 expect ( helper ) . to have_received ( :append_stylesheet_pack_tag ) . with ( "generated/component_name" )
6161 end
Original file line number Diff line number Diff line change @@ -282,7 +282,8 @@ module ReactOnRails
282282 context "when using Shakapacker >= 8.2.0" do
283283 before do
284284 allow ( ReactOnRails ::PackerUtils ) . to receive ( :shakapacker_version_requirement_met? )
285- . with ( [ 8 , 2 , 0 ] ) . and_return ( true )
285+ # TODO: Set to 8.2.0 after it's released and before merging this branch
286+ . with ( [ 8 , 1 , 0 ] ) . and_return ( true )
286287 end
287288
288289 it "defaults to :async" do
@@ -329,7 +330,8 @@ module ReactOnRails
329330 context "when using Shakapacker < 8.2.0" do
330331 before do
331332 allow ( ReactOnRails ::PackerUtils ) . to receive ( :shakapacker_version_requirement_met? )
332- . with ( [ 8 , 2 , 0 ] ) . and_return ( false )
333+ # TODO: Set to 8.2.0 after it's released and before merging this branch
334+ . with ( [ 8 , 1 , 0 ] ) . and_return ( false )
333335 allow ( Rails . logger ) . to receive ( :warn )
334336 end
335337
You can’t perform that action at this time.
0 commit comments