You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Improve CLAUDE.md with testing requirements and clarity
Add critical testing requirements and documentation improvements:
**Testing Requirements:**
- Require local testing before claiming fixes
- Distinguish confirmed fixes from hypothetical fixes
- Document testing limitations when local testing isn't possible
- Provide clear reproduction steps
**Documentation Updates:**
- Clarify Pro changelog location (CHANGELOG_PRO.md at root)
- Add guidance for analyzing CI failures
- Update Pro changelog update commands
- Improve formatting and organization
These improvements help prevent CI iteration loops and ensure more reliable fixes.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
Copy file name to clipboardExpand all lines: CLAUDE.md
+44-3Lines changed: 44 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -29,6 +29,32 @@ Top-level documentation (like README.md, CONTRIBUTING.md) should remain at the r
29
29
30
30
These requirements are non-negotiable. CI will fail if not followed.
31
31
32
+
**CRITICAL - LOCAL TESTING REQUIREMENTS:**
33
+
34
+
1.**NEVER claim a test is "fixed" without running it locally first**
35
+
- If working in Conductor workspace or similar isolated environment, clearly state: "Cannot test locally in isolated workspace"
36
+
- If test requires specific environment (database, Redis, etc.), state: "Requires [X] setup not available in current environment"
37
+
38
+
2.**Distinguish hypothetical fixes from confirmed fixes:**
39
+
- ✅ Use "This fixes..." or "Fixed" ONLY after local verification
40
+
- ⚠️ Use "This SHOULD fix..." or "Proposed fix (UNTESTED)" when you haven't verified
41
+
- 📋 Use "Analysis suggests..." or "Root cause appears to be..." for investigation without fixes
42
+
43
+
3.**When analyzing CI failures:**
44
+
- Clearly mark all analysis as "UNTESTED - requires local reproduction" unless verified
45
+
- Provide exact commands to reproduce and test the fix locally
46
+
- State why you cannot test if applicable (workspace restrictions, missing services, etc.)
47
+
48
+
4.**Prefer local testing over CI iteration:**
49
+
- Don't push "hopeful" fixes and wait for CI feedback
50
+
- Test locally first whenever technically possible
51
+
- Document what you tested and what results you got
52
+
53
+
5.**Document your testing:**
54
+
- Include test commands in commit messages for complex fixes
55
+
- Note in PR descriptions which fixes were tested locally vs. which are hypothetical
56
+
- Explain any testing limitations encountered
57
+
32
58
**🚀 AUTOMATIC: Git hooks are installed automatically during setup**
33
59
34
60
Git hooks will automatically run linting on **all changed files (staged + unstaged + untracked)** before each commit - making it fast while preventing CI failures!
0 commit comments