Commit 36f25fa
Fix Shakapacker version requirement from 8.2.0 to 8.0.0 for basic compatibility
This change separates basic React on Rails functionality from feature-specific
requirements to eliminate unnecessary breaking changes.
## Problem
React on Rails 16 artificially required Shakapacker >= 8.2.0 for ALL functionality,
causing the `:clean` task error when using Shakapacker 8.0.0. The 8.2.0 requirement
is only needed for async script loading, not basic compatibility.
## Solution
1. **Reduced basic compatibility requirement** from 8.2.0 to 8.0.0 in `using_shakapacker_const?`
2. **Added feature-specific methods**:
- `supports_async_loading?` - checks Shakapacker >= 8.2.0 for async script loading
- `supports_auto_registration?` - checks Shakapacker >= 7.0.0 + nested_entries support
3. **Updated configuration logic** to use feature-specific detection
4. **Updated system checker** to use proper feature detection methods
## Impact
- ✅ Fixes Docker build failure: `Don't know how to build task ':clean'`
- ✅ Allows React on Rails 16 to work with Shakapacker 8.0.0 for basic functionality
- ✅ Shows helpful warnings instead of fatal errors for missing features
- ✅ Maintains backward compatibility while enabling gradual upgrades
## Testing
- All existing tests pass
- Added comprehensive test coverage for new methods
- Verified assets:precompile works with Shakapacker 8.0.0
- Confirmed proper `shakapacker:clean` task invocation
Fixes the artificial breaking change that forced unnecessary Shakapacker upgrades.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>1 parent 32d4665 commit 36f25fa
File tree
4 files changed
+100
-6
lines changed- lib/react_on_rails
- spec/react_on_rails
4 files changed
+100
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
180 | 180 | | |
181 | 181 | | |
182 | 182 | | |
183 | | - | |
| 183 | + | |
184 | 184 | | |
185 | 185 | | |
186 | 186 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
59 | 69 | | |
60 | 70 | | |
61 | 71 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
619 | 619 | | |
620 | 620 | | |
621 | 621 | | |
622 | | - | |
623 | | - | |
| 622 | + | |
| 623 | + | |
624 | 624 | | |
625 | | - | |
| 625 | + | |
626 | 626 | | |
627 | 627 | | |
628 | | - | |
| 628 | + | |
629 | 629 | | |
630 | 630 | | |
631 | 631 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
79 | 163 | | |
80 | 164 | | |
0 commit comments