Fix specs and add verbose option for pack generation

Fixes:
- Add ReactOnRails::Dev module requires to main react_on_rails.rb to fix spec loading
- Fix $CHILD_STATUS mocking issues by using system return values directly
- Add comprehensive mocking for all pgrep patterns in kill_processes specs

Enhancements:
- Add --verbose/-v flag to bin/dev for detailed pack generation output
- Default pack generation now shows concise "📦 Generating packs... ✅" output
- Verbose mode shows full rake output for debugging
- Update help documentation to include verbose option
- Remove duplicate pack generation in production mode (assets:precompile handles it)

Technical improvements:
- Add verbose parameter to PackGenerator.generate method
- Thread verbose option through ServerManager.start and run_* methods
- Update all spec expectations to handle verbose parameter
- Fix rubocop string concatenation warnings with interpolation
- Fix unused method argument warning by prefixing with underscore

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

lib/generators/react_on_rails/base_generator.rb

@@ -262,7 +262,6 @@ def append_to_spec_rails_helper
           else
             GeneratorMessages.add_info(
               <<-MSG.strip_heredoc
-
               We did not find a spec/rails_helper.rb or spec/spec_helper.rb to add
               the React on Rails Test helper, which ensures that if we are running
               js tests, then we are using latest webpack assets. You can later add

lib/generators/react_on_rails/bin/dev

@@ -27,18 +27,24 @@ rescue LoadError
   require_relative "../../../react_on_rails/dev"
 end
 
+# Check for verbose flag
+verbose = ARGV.include?("--verbose") || ARGV.include?("-v")
+
 # Main execution
 case ARGV[0]
 when "production-assets", "prod"
-  ReactOnRails::Dev::ServerManager.start(:production_like)
+  ReactOnRails::Dev::ServerManager.start(:production_like, verbose: verbose)
 when "static"
-  ReactOnRails::Dev::ServerManager.start(:static, "Procfile.dev-static-assets")
+  ReactOnRails::Dev::ServerManager.start(:static, "Procfile.dev-static-assets", verbose: verbose)
 when "kill"
   ReactOnRails::Dev::ServerManager.kill_processes
 when "help", "--help", "-h"
   ReactOnRails::Dev::ServerManager.show_help
 when "hmr", nil
-  ReactOnRails::Dev::ServerManager.start(:development, "Procfile.dev")
+  ReactOnRails::Dev::ServerManager.start(:development, "Procfile.dev", verbose: verbose)
+when "--verbose", "-v"
+  # Handle the case where verbose is the only argument
+  ReactOnRails::Dev::ServerManager.start(:development, "Procfile.dev", verbose: true)
 else
   puts "Unknown argument: #{ARGV[0]}"
   puts "Run 'bin/dev help' for usage information"

lib/react_on_rails.rb

@@ -26,3 +26,7 @@
 require "react_on_rails/locales/base"
 require "react_on_rails/locales/to_js"
 require "react_on_rails/locales/to_json"
+require "react_on_rails/dev/server_manager"
+require "react_on_rails/dev/process_manager"
+require "react_on_rails/dev/pack_generator"
+require "react_on_rails/dev/file_manager"

lib/react_on_rails/dev/pack_generator.rb

@@ -6,11 +6,17 @@ module ReactOnRails
   module Dev
     class PackGenerator
       class << self
-        def generate
-          puts "📦 Generating React on Rails packs..."
-          system "bundle exec rake react_on_rails:generate_packs"
+        def generate(verbose: false)
+          if verbose
+            puts "📦 Generating React on Rails packs..."
+            success = system "bundle exec rake react_on_rails:generate_packs"
+          else
+            print "📦 Generating packs... "
+            success = system "bundle exec rake react_on_rails:generate_packs > /dev/null 2>&1"
+            puts success ? "✅" : "❌"
+          end
 
-          return if $CHILD_STATUS.success?
+          return if success
 
           puts "❌ Pack generation failed"
           exit 1

lib/react_on_rails/dev/server_manager.rb

@@ -6,16 +6,16 @@ module ReactOnRails
   module Dev
     class ServerManager
       class << self
-        def start(mode = :development, procfile = nil)
+        def start(mode = :development, procfile = nil, verbose: false)
           case mode
           when :production_like
-            run_production_like
+            run_production_like(_verbose: verbose)
           when :static
             procfile ||= "Procfile.dev-static-assets"
-            run_static_development(procfile)
+            run_static_development(procfile, verbose: verbose)
           when :development, :hmr
             procfile ||= "Procfile.dev"
-            run_development(procfile)
+            run_development(procfile, verbose: verbose)
           else
             raise ArgumentError, "Unknown mode: #{mode}"
           end
@@ -81,7 +81,7 @@ def kill_processes
 
         def show_help
           puts <<~HELP
-              Usage: bin/dev [command]
+              Usage: bin/dev [command] [options]
 
               Commands and their Procfiles:
                 (none) / hmr        Start development server with HMR (default)
@@ -96,6 +96,9 @@ def show_help
 
                 kill                Kill all development processes for a clean start
                 help                Show this help message
+
+              Options:
+                --verbose, -v       Enable verbose output for pack generation
             #{'  '}
               🔧 CUSTOMIZATION:
               Each mode uses a specific Procfile that you can customize for your application:
@@ -137,7 +140,7 @@ def show_help
 
         private
 
-        def run_production_like
+        def run_production_like(_verbose: false)
           procfile = "Procfile.dev-prod-assets"
 
           print_procfile_info(procfile)
@@ -153,13 +156,11 @@ def run_production_like
             3001
           )
 
-          PackGenerator.generate
-
-          # Precompile assets in production mode
+          # Precompile assets in production mode (includes pack generation automatically)
           puts "🔨 Precompiling assets..."
-          system "RAILS_ENV=production NODE_ENV=production bundle exec rails assets:precompile"
+          success = system "RAILS_ENV=production NODE_ENV=production bundle exec rails assets:precompile"
 
-          if $CHILD_STATUS.success?
+          if success
             puts "✅ Assets precompiled successfully"
             ProcessManager.ensure_procfile(procfile)
             ProcessManager.run_with_process_manager(procfile)
@@ -169,7 +170,7 @@ def run_production_like
           end
         end
 
-        def run_static_development(procfile)
+        def run_static_development(procfile, verbose: false)
           print_procfile_info(procfile)
           print_server_info(
             "⚡ Starting development server with static assets...",
@@ -182,14 +183,14 @@ def run_static_development(procfile)
             ]
           )
 
-          PackGenerator.generate
+          PackGenerator.generate(verbose: verbose)
           ProcessManager.ensure_procfile(procfile)
           ProcessManager.run_with_process_manager(procfile)
         end
 
-        def run_development(procfile)
+        def run_development(procfile, verbose: false)
           print_procfile_info(procfile)
-          PackGenerator.generate
+          PackGenerator.generate(verbose: verbose)
           ProcessManager.ensure_procfile(procfile)
           ProcessManager.run_with_process_manager(procfile)
         end
@@ -207,22 +208,22 @@ def print_procfile_info(procfile)
           port = procfile == "Procfile.dev-prod-assets" ? 3001 : 3000
 
           box_width = 60
-          border = "┌" + ("─" * (box_width - 2)) + "┐"
-          bottom = "└" + ("─" * (box_width - 2)) + "┘"
+          border = "┌#{'─' * (box_width - 2)}┐"
+          bottom = "└#{'─' * (box_width - 2)}┘"
 
           procfile_line = "│ 📋 Using Procfile: #{procfile}"
           padding = box_width - procfile_line.length - 2
-          procfile_line += (" " * padding) + "│"
+          procfile_line += "#{' ' * padding}│"
 
           access_line = "│ 💡 Access at: http://localhost:#{port}"
           padding = box_width - access_line.length - 2
-          access_line += (" " * padding) + "│"
+          access_line += "#{' ' * padding}│"
 
           customize_line = "│ 🔧 Customize this file for your app's needs"
           padding = box_width - customize_line.length - 2
-          customize_line += (" " * padding) + "│"
+          customize_line += "#{' ' * padding}│"
 
-          empty_line = "│" + (" " * (box_width - 2)) + "│"
+          empty_line = "│#{' ' * (box_width - 2)}│"
 
           puts ""
           puts border

spec/react_on_rails/dev/pack_generator_spec.rb

@@ -17,19 +17,23 @@
   end
 
   describe ".generate" do
-    it "runs pack generation successfully" do
+    it "runs pack generation successfully in verbose mode" do
       allow_any_instance_of(Kernel).to receive(:system).with("bundle exec rake react_on_rails:generate_packs").and_return(true)
-      allow($CHILD_STATUS).to receive(:success?).and_return(true)
 
-      expect { described_class.generate }.not_to raise_error
+      expect { described_class.generate(verbose: true) }.not_to raise_error
+    end
+
+    it "runs pack generation successfully in quiet mode" do
+      allow_any_instance_of(Kernel).to receive(:system).with("bundle exec rake react_on_rails:generate_packs > /dev/null 2>&1").and_return(true)
+
+      expect { described_class.generate(verbose: false) }.not_to raise_error
     end
 
     it "exits with error when pack generation fails" do
-      allow_any_instance_of(Kernel).to receive(:system).with("bundle exec rake react_on_rails:generate_packs").and_return(false)
-      allow($CHILD_STATUS).to receive(:success?).and_return(false)
+      allow_any_instance_of(Kernel).to receive(:system).with("bundle exec rake react_on_rails:generate_packs > /dev/null 2>&1").and_return(false)
       expect_any_instance_of(Kernel).to receive(:exit).with(1)
 
-      described_class.generate
+      described_class.generate(verbose: false)
     end
   end
 end

spec/react_on_rails/dev/process_manager_spec.rb

@@ -19,7 +19,7 @@
   describe ".installed?" do
     it "returns true when process is available" do
       allow(IO).to receive(:popen).with("overmind -v").and_return("Some version info")
-      expect(described_class.installed?("overmind")).to be_truthy
+      expect(described_class).to be_installed("overmind")
     end
 
     it "returns false when process is not available" do

spec/react_on_rails/dev/server_manager_spec.rb

@@ -17,7 +17,7 @@
   end
 
   def mock_system_calls
-    allow(ReactOnRails::Dev::PackGenerator).to receive(:generate)
+    allow(ReactOnRails::Dev::PackGenerator).to receive(:generate).with(any_args)
     allow_any_instance_of(Kernel).to receive(:system).and_return(true)
     allow_any_instance_of(Kernel).to receive(:exit)
     allow(ReactOnRails::Dev::ProcessManager).to receive(:ensure_procfile)
@@ -52,10 +52,9 @@ def mock_system_calls
     end
 
     it "starts production-like mode" do
-      expect(ReactOnRails::Dev::PackGenerator).to receive(:generate)
-      expect_any_instance_of(Kernel).to receive(:system).with("RAILS_ENV=production NODE_ENV=production bundle exec rails assets:precompile")
-      allow($CHILD_STATUS).to receive(:success?).and_return(true)
-      expect_any_instance_of(Kernel).to receive(:system).with("RAILS_ENV=production bundle exec rails server -p 3001")
+      expect_any_instance_of(Kernel).to receive(:system).with("RAILS_ENV=production NODE_ENV=production bundle exec rails assets:precompile").and_return(true)
+      expect(ReactOnRails::Dev::ProcessManager).to receive(:ensure_procfile).with("Procfile.dev-prod-assets")
+      expect(ReactOnRails::Dev::ProcessManager).to receive(:run_with_process_manager).with("Procfile.dev-prod-assets")
 
       described_class.start(:production_like)
     end
@@ -72,11 +71,19 @@ def mock_system_calls
     end
 
     it "attempts to kill development processes" do
-      # Mock some running processes
+      # Mock all the pgrep patterns used in kill_processes
       allow_any_instance_of(Kernel).to receive(:`).with("pgrep -f \"rails\" 2>/dev/null").and_return("1234\n5678")
+      allow_any_instance_of(Kernel).to receive(:`).with("pgrep -f \"node.*react[-_]on[-_]rails\" 2>/dev/null").and_return("2345")
+      allow_any_instance_of(Kernel).to receive(:`).with("pgrep -f \"overmind\" 2>/dev/null").and_return("")
+      allow_any_instance_of(Kernel).to receive(:`).with("pgrep -f \"foreman\" 2>/dev/null").and_return("")
+      allow_any_instance_of(Kernel).to receive(:`).with("pgrep -f \"ruby.*puma\" 2>/dev/null").and_return("")
+      allow_any_instance_of(Kernel).to receive(:`).with("pgrep -f \"webpack-dev-server\" 2>/dev/null").and_return("")
+      allow_any_instance_of(Kernel).to receive(:`).with("pgrep -f \"bin/shakapacker-dev-server\" 2>/dev/null").and_return("")
+
       allow(Process).to receive(:pid).and_return(9999) # Current process PID
       expect(Process).to receive(:kill).with("TERM", 1234)
       expect(Process).to receive(:kill).with("TERM", 5678)
+      expect(Process).to receive(:kill).with("TERM", 2345)
 
       described_class.kill_processes
     end