fix: remove unused Procfile.dev-static and fix backward compatibility

- Remove unused Procfile.dev-static template and references
- Update base_generator.rb to not copy the unused file
- Update tests to not expect the unused file
- Fix AdaptForOlderShakapackerGenerator to handle new Procfile structure
- Add missing Procfile.dev-prod-assets to backward compatibility generator

Author: ihabadham

lib/generators/react_on_rails/adapt_for_older_shakapacker_generator.rb

@@ -13,7 +13,8 @@ def change_spelling_to_webpacker
         puts "Change spelling to webpacker v7"
         files = %w[
           Procfile.dev
-          Procfile.dev-static
+          Procfile.dev-static-assets
+          Procfile.dev-prod-assets
           config/shakapacker.yml
           config/initializers/react_on_rails.rb
         ]

lib/generators/react_on_rails/base_generator.rb

@@ -31,7 +31,6 @@ def copy_base_files
         base_files = %w[app/controllers/hello_world_controller.rb
                         app/views/layouts/hello_world.html.erb
                         Procfile.dev
-                        Procfile.dev-static
                         Procfile.dev-static-assets
                         Procfile.dev-prod-assets]
         base_templates = %w[config/initializers/react_on_rails.rb]

lib/generators/react_on_rails/templates/base/base/Procfile.dev-static

@@ -19,7 +19,6 @@
     %w[app/controllers/hello_world_controller.rb
        config/initializers/react_on_rails.rb
        Procfile.dev
-       Procfile.dev-static
        Procfile.dev-static-assets
        Procfile.dev-prod-assets].each { |file| assert_file(file) }