Commit 40bb3f2
Security and code quality improvements
Addresses security issues and optimizations identified in code review:
Security Fixes:
- Fix command injection risk in precompile hook by using IO.popen with array
form instead of backticks (spec/dummy/bin/shakapacker-precompile-hook:76)
- Improve regex patterns to exclude commented configuration lines using
negative lookahead to prevent false matches
Code Quality:
- Optimize webpack configuration to process rules in single pass instead of
double iteration, improving build performance
- Combine SCSS loader addition and CSS Modules configuration into one loop
Documentation:
- Add comprehensive CHANGELOG.md entry documenting Shakapacker 9.0.0 upgrade
including configuration changes, precompile hook, and compatibility notes
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>1 parent 0d51136 commit 40bb3f2
File tree
3 files changed
+23
-14
lines changed- spec/dummy
- bin
- config/webpack
3 files changed
+23
-14
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
34 | 43 | | |
35 | 44 | | |
36 | 45 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
65 | | - | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
66 | 67 | | |
67 | 68 | | |
68 | 69 | | |
| |||
71 | 72 | | |
72 | 73 | | |
73 | 74 | | |
74 | | - | |
75 | | - | |
| 75 | + | |
| 76 | + | |
76 | 77 | | |
77 | 78 | | |
78 | 79 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
| 24 | + | |
34 | 25 | | |
35 | 26 | | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
36 | 35 | | |
37 | 36 | | |
38 | 37 | | |
| |||
0 commit comments