rubocop linting

Author: Judahmeek

lib/react_on_rails/helper.rb

@@ -436,7 +436,7 @@ def internal_rsc_react_component(react_component_name, options = {})
       render_options = create_render_options(react_component_name, options)
       json_stream = server_rendered_react_component(render_options)
       json_stream.transform do |chunk|
-        (chunk.to_json + "\n").html_safe
+        "#{chunk.to_json}\n".html_safe
       end
     end
 

lib/react_on_rails/packs_generator.rb

@@ -44,7 +44,9 @@ def create_pack(file_path)
       puts(Rainbow("Generated Packs: #{output_path}").yellow)
     end
 
+    # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
     def first_js_statement_in_code(content)
+      # rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
       return "" if content.nil? || content.empty?
 
       start_index = 0
@@ -81,17 +83,18 @@ def first_js_statement_in_code(content)
       ""
     end
 
-    def is_client_entrypoint?(file_path)
+    def client_entrypoint?(file_path)
       content = File.read(file_path)
       # has "use client" directive. It can be "use client" or 'use client'
       first_js_statement_in_code(content).match?(/^["']use client["'](?:;|\s|$)/)
     end
 
     def pack_file_contents(file_path)
       registered_component_name = component_name(file_path)
-      load_server_components = ReactOnRails::Utils.react_on_rails_pro? && ReactOnRailsPro.configuration.enable_rsc_support
+      load_server_components = ReactOnRails::Utils.react_on_rails_pro? &&
+                               ReactOnRailsPro.configuration.enable_rsc_support
 
-      if load_server_components && !is_client_entrypoint?(file_path)
+      if load_server_components && !client_entrypoint?(file_path)
         import_statement = ""
         rsc_rendering_url_path = ReactOnRailsPro.configuration.rsc_rendering_url_path
         register_call = <<~REGISTER_CALL.strip

spec/dummy/spec/packs_generator_spec.rb

@@ -82,7 +82,7 @@ module ReactOnRails
       it "generated pack for ComponentWithCommonOnly uses common file for pack" do
         pack_content = File.read(component_pack)
 
-        expect(pack_content).to include("#{component_namspec / dummy / spec / packs_generator_spec.rbe}.jsx")
+        expect(pack_content).to include("#{component_name / dummy / spec / packs_generator_spec.rbe}.jsx")
         expect(pack_content).not_to include("#{component_name}.client.jsx")
         expect(pack_content).not_to include("#{component_name}.server.jsx")
       end
@@ -434,7 +434,7 @@ def stub_packer_source_path(packer_source_path:, component_name:)
       end
 
       context "with string directive" do
-        context "on top of the file" do
+        context "when on top of the file" do
           let(:content) do
             <<~JS
               "use client";
@@ -446,13 +446,13 @@ def stub_packer_source_path(packer_source_path:, component_name:)
           it { is_expected.to eq '"use client";' }
         end
 
-        context "on top of the file and one line comment" do
+        context "when on top of the file and one line comment" do
           let(:content) { '"use client"; // const x = 1' }
 
           it { is_expected.to eq '"use client"; // const x = 1' }
         end
 
-        context "after some one-line comments" do
+        context "when after some one-line comments" do
           let(:content) do
             <<~JS
               // First comment
@@ -464,7 +464,7 @@ def stub_packer_source_path(packer_source_path:, component_name:)
           it { is_expected.to eq '"use client";' }
         end
 
-        context "after some multi-line comments" do
+        context "when after some multi-line comments" do
           let(:content) do
             <<~JS
               /* First comment */
@@ -478,7 +478,7 @@ def stub_packer_source_path(packer_source_path:, component_name:)
           it { is_expected.to eq '"use client";' }
         end
 
-        context "after some mixed comments" do
+        context "when after some mixed comments" do
           let(:content) do
             <<~JS
               // First comment
@@ -492,7 +492,7 @@ def stub_packer_source_path(packer_source_path:, component_name:)
           it { is_expected.to eq '"use client";' }
         end
 
-        context "after any non-comment code" do
+        context "when after any non-comment code" do
           let(:content) do
             <<~JS
               // First comment
@@ -506,8 +506,8 @@ def stub_packer_source_path(packer_source_path:, component_name:)
       end
     end
 
-    describe "#is_client_entrypoint?" do
-      subject { described_class.instance.send(:is_client_entrypoint?, "dummy_path.js") }
+    describe "#client_entrypoint?" do
+      subject { described_class.instance.send(:client_entrypoint?, "dummy_path.js") }
 
       before do
         allow(File).to receive(:read).with("dummy_path.js").and_return(content)