refactor: replace direct checks for RSC support with a utility method for improved clarity and maintainability

Author: AbanoubGhadban

lib/react_on_rails/helper.rb

@@ -381,7 +381,7 @@ def rails_context(server_side: true)
         if ReactOnRails::Utils.react_on_rails_pro?
           result[:rorProVersion] = ReactOnRails::Utils.react_on_rails_pro_version
 
-          result[:rscPayloadGenerationUrlPath] = rsc_url if ReactOnRailsPro.configuration.enable_rsc_support
+          result[:rscPayloadGenerationUrlPath] = rsc_url if ReactOnRails::Utils.rsc_support_enabled?
         end
 
         if defined?(request) && request.present?

lib/react_on_rails/packs_generator.rb

@@ -89,8 +89,7 @@ def client_entrypoint?(file_path)
 
     def pack_file_contents(file_path)
       registered_component_name = component_name(file_path)
-      load_server_components = ReactOnRails::Utils.react_on_rails_pro? &&
-                               ReactOnRailsPro.configuration.enable_rsc_support
+      load_server_components = ReactOnRails::Utils.rsc_support_enabled?
 
       if load_server_components && !client_entrypoint?(file_path)
         return <<~FILE_CONTENT.strip
@@ -142,8 +141,7 @@ def generated_server_pack_file_content
         "import #{name} from '#{relative_path(generated_server_bundle_file_path, component_path)}';"
       end
 
-      load_server_components = ReactOnRails::Utils.react_on_rails_pro? &&
-                               ReactOnRailsPro.configuration.enable_rsc_support
+      load_server_components = ReactOnRails::Utils.rsc_support_enabled?
       server_components = component_for_server_registration_to_path.keys.delete_if do |name|
         next true unless load_server_components
 

lib/react_on_rails/utils.rb

@@ -213,6 +213,13 @@ def self.react_on_rails_pro_version
                                     end
     end
 
+    def self.rsc_support_enabled?
+      return false unless react_on_rails_pro?
+
+      rorp_config = ReactOnRailsPro.configuration
+      rorp_config.respond_to?(:enable_rsc_support) && rorp_config.enable_rsc_support
+    end
+
     def self.full_text_errors_enabled?
       ENV["FULL_TEXT_ERRORS"] == "true"
     end

spec/dummy/spec/packs_generator_spec.rb

@@ -220,10 +220,7 @@ def self.configuration
       before do
         stub_packer_source_path(component_name: components_directory,
                                 packer_source_path: packer_source_path)
-        allow(ReactOnRails::Utils).to receive(:react_on_rails_pro?).and_return(true)
-        allow(ReactOnRailsPro.configuration).to receive_messages(
-          enable_rsc_support: true
-        )
+        allow(ReactOnRails::Utils).to receive_messages(react_on_rails_pro?: true, rsc_support_enabled?: true)
       end
 
       context "when common component is not a client entrypoint" do