add a comment

AbanoubGhadban · AbanoubGhadban · commit 45b61ba1553a · 2024-10-13T15:47:48.000+03:00
diff --git a/node_package/src/serverRenderReactComponent.ts b/node_package/src/serverRenderReactComponent.ts
@@ -41,6 +41,8 @@ function processServerRenderHash(result: ServerRenderResult, options: RenderOpti
       const redirectPath = redirectLocation.pathname + redirectLocation.search;
       console.log(`ROUTER REDIRECT: ${options.componentName} to dom node with id: ${options.domNodeId}, redirect to ${redirectPath}`);
     }
+    // For redirects on server rendering, we can't stop Rails from returning the same result.
+    // Possibly, someday, we could have the rails server redirect.
     htmlResult = '';
   } else {
     htmlResult = result.renderedHtml as string;

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,8 @@ function processServerRenderHash(result: ServerRenderResult, options: RenderOpti`
`41`	`41`	`const redirectPath = redirectLocation.pathname + redirectLocation.search;`
`42`	`42`	console.log(`ROUTER REDIRECT: ${options.componentName} to dom node with id: ${options.domNodeId}, redirect to ${redirectPath}`);
`43`	`43`	`}`
	`44`	`+ // For redirects on server rendering, we can't stop Rails from returning the same result.`
	`45`	`+ // Possibly, someday, we could have the rails server redirect.`
`44`	`46`	`htmlResult = '';`
`45`	`47`	`} else {`
`46`	`48`	`htmlResult = result.renderedHtml as string;`