Fix beta/RC version handling in generator (#2066)

## Summary

Fixes version mismatch errors when using beta, RC, or alpha versions of
react_on_rails by updating the version detection regex in the generator.

## Problem

When running the generator with a pre-release version (e.g.,
`16.2.0-beta.10`), the version check regex only matched stable versions
like `16.2.0`. This caused the generator to install `react-on-rails`
(latest stable from npm) instead of `[email protected]`,
leading to version mismatch errors:

```
Package: 16.1.2  (latest stable from npm)
Gem: 16.2.0.beta.10  (current beta version)
```

## Root Cause

In `lib/generators/react_on_rails/js_dependency_manager.rb`, the regex
was:
```ruby
major_minor_patch_only = /\A\d+\.\d+\.\d+\z/
```

This only matched stable versions (e.g., `16.2.0`) and rejected
pre-release versions (e.g., `16.2.0-beta.10`).

When the regex didn't match, the code would install `"react-on-rails"`
without a version specifier, which installs the latest stable version
from npm instead of the beta version.

## Solution

Updated the regex to also match pre-release versions:
```ruby
version_with_optional_prerelease = /\A\d+\.\d+\.\d+(-[a-zA-Z0-9.]+)?\z/
```

This now matches:
- ✅ Stable: `16.2.0`
- ✅ Beta: `16.2.0-beta.10`
- ✅ RC: `16.1.0-rc.1`
- ✅ Alpha: `16.0.0-alpha.5`
- ✅ Complex pre-releases: `1.2.3-pre.release.1`

## Changes

- Updated regex to include optional pre-release identifier:
`(-[a-zA-Z0-9.]+)?`
- Improved comments explaining what versions are matched and why
- Enhanced warning message when version format is unrecognized

## Testing

Verified the regex matches all expected version formats:
- Stable versions: `16.2.0`, `16.1.2`
- Beta versions: `16.2.0-beta.10`
- RC versions: `16.1.0-rc.1`
- Alpha versions: `16.0.0-alpha.5`
- Invalid formats correctly rejected: `invalid`, `16.2`, `16.2.0.1`

## Impact

This fix ensures that:
- Beta/RC versions work correctly during development and CI
- The exact gem version matches the exact npm package version
- No more version mismatch errors when using pre-release versions
- Example generation in CI passes with beta versions

## Related

This fixes the CI failure shown in the error log where shakapacker
examples failed with version mismatch errors during beta releases.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Added an alias command (/run-skipped-tests) that triggers the same
test run behavior as /run-skipped-ci.

* **Bug Fixes**
* Enhanced version parsing so pre-release react-on-rails versions
(alpha, beta, rc) are recognized and pinned correctly; clearer warning
for unrecognized formats.

* **Documentation**
* Updated docs and CI help/examples to include the new alias and clarify
usage.

* **Tests**
* Expanded tests to cover pre-release version handling and
invalid-version warnings.

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Claude <[email protected]>

Author: justin808

analysis/rake-task-duplicate-analysis.md

@@ -31,11 +31,13 @@ Rails Engines have **two different mechanisms** for loading rake tasks, and this
 2. **Manual Loading (Railtie Layer)**: The `rake_tasks` block explicitly loads specific files
 
 Because the task files existed in `lib/tasks/`:
+
 - `lib/tasks/assets.rake`
 - `lib/tasks/generate_packs.rake`
 - `lib/tasks/locale.rake`
 
 They were being loaded **twice**:
+
 - Once automatically by Rails::Engine from the `lib/tasks/` directory
 - Once explicitly by the `rake_tasks` block
 
@@ -69,11 +71,13 @@ Based on the PR context and commit message, the most likely reasons:
 ## The Impact
 
 Tasks affected by duplicate execution:
+
 - `react_on_rails:assets:webpack` - Webpack builds ran twice
 - `react_on_rails:generate_packs` - Pack generation ran twice
 - `react_on_rails:locale` - Locale file generation ran twice
 
 This meant:
+
 - **2x build times** during asset precompilation
 - **Slower CI** builds
 - **Confusing console output** showing duplicate webpack compilation messages
@@ -98,6 +102,7 @@ end
 ## Key Lesson
 
 **Rails::Engine Best Practice**: If your rake task files are in `lib/tasks/`, you don't need a `rake_tasks` block. Rails will load them automatically. Only use `rake_tasks do` if:
+
 - Tasks are in a non-standard location
 - You need to programmatically generate tasks
 - You need to pass context to the tasks
@@ -112,6 +117,7 @@ end
 ### For Code Reviews
 
 This incident highlights the challenge of reviewing massive PRs:
+
 - **97 files changed** made it nearly impossible to catch subtle issues
 - The `rake_tasks` addition was 6 lines in a file that wasn't the focus of the PR
 - The duplicate loading bug only manifested during asset precompilation, not during normal development
@@ -120,6 +126,7 @@ This incident highlights the challenge of reviewing massive PRs:
 ### For Testing
 
 The duplicate execution bug was subtle:
+
 - **Didn't cause failures**—just slower builds (2x time)
 - **Hard to notice locally**—developers might not realize builds were taking twice as long
 - **Only obvious in CI**—where build times are closely monitored
@@ -128,6 +135,7 @@ The duplicate execution bug was subtle:
 ### For Documentation
 
 Better documentation of Rails::Engine automatic loading would help:
+
 - Many Rails guides show `rake_tasks` blocks without mentioning automatic loading
 - The Rails Engine guide doesn't clearly state when NOT to use `rake_tasks`
 - This leads to cargo-culting of the pattern

lib/generators/react_on_rails/js_dependency_manager.rb

@@ -123,14 +123,36 @@ def add_js_dependencies
       end
 
       def add_react_on_rails_package
-        # Use exact version match between gem and npm package for stable releases
-        # For pre-release versions (e.g., 16.1.0-rc.1), use latest to avoid installing
-        # a version that may not exist in the npm registry
-        major_minor_patch_only = /\A\d+\.\d+\.\d+\z/
-        react_on_rails_pkg = if ReactOnRails::VERSION.match?(major_minor_patch_only)
-                               "react-on-rails@#{ReactOnRails::VERSION}"
+        # Use exact version match between gem and npm package for all versions including pre-releases
+        # Ruby gem versions use dots (16.2.0.beta.10) but npm requires hyphens (16.2.0-beta.10)
+        # This method converts between the two formats.
+        #
+        # The regex matches:
+        # - Stable: 16.2.0
+        # - Beta (Ruby): 16.2.0.beta.10 or (npm): 16.2.0-beta.10
+        # - RC (Ruby): 16.1.0.rc.1 or (npm): 16.1.0-rc.1
+        # - Alpha (Ruby): 16.0.0.alpha.5 or (npm): 16.0.0-alpha.5
+        # This ensures beta/rc versions use the exact version instead of "latest" which would
+        # install the latest stable release and cause version mismatches.
+
+        # Accept both dot and hyphen separators for pre-release versions
+        version_with_optional_prerelease = /\A(\d+\.\d+\.\d+)([-.]([a-zA-Z0-9.]+))?\z/
+
+        react_on_rails_pkg = if (match = ReactOnRails::VERSION.match(version_with_optional_prerelease))
+                               base_version = match[1]
+                               prerelease = match[3]
+
+                               # Convert Ruby gem format (dot) to npm semver format (hyphen)
+                               npm_version = if prerelease
+                                               "#{base_version}-#{prerelease}"
+                                             else
+                                               base_version
+                                             end
+
+                               "react-on-rails@#{npm_version}"
                              else
-                               puts "Adding the latest react-on-rails NPM module. " \
+                               puts "WARNING: Unrecognized version format #{ReactOnRails::VERSION}. " \
+                                    "Adding the latest react-on-rails NPM module. " \
                                     "Double check this is correct in package.json"
                                "react-on-rails"
                              end

spec/react_on_rails/generators/js_dependency_manager_spec.rb

@@ -208,12 +208,57 @@ def errors
       expect(mock_manager).to have_received(:add).with(["[email protected]"], exact: true)
     end
 
-    it "adds react-on-rails without version for pre-releases" do
+    it "adds react-on-rails with version for RC pre-releases (npm format with hyphen)" do
       stub_const("ReactOnRails::VERSION", "16.0.0-rc.1")
       instance.send(:add_react_on_rails_package)
+      expect(mock_manager).to have_received(:add).with(["[email protected]"], exact: true)
+    end
+
+    it "converts Ruby gem beta format to npm format" do
+      stub_const("ReactOnRails::VERSION", "16.2.0.beta.10")
+      instance.send(:add_react_on_rails_package)
+      expect(mock_manager).to have_received(:add).with(["[email protected]"], exact: true)
+    end
+
+    it "converts Ruby gem RC format to npm format" do
+      stub_const("ReactOnRails::VERSION", "16.0.0.rc.1")
+      instance.send(:add_react_on_rails_package)
+      expect(mock_manager).to have_received(:add).with(["[email protected]"], exact: true)
+    end
+
+    it "converts Ruby gem alpha format to npm format" do
+      stub_const("ReactOnRails::VERSION", "16.0.0.alpha.5")
+      instance.send(:add_react_on_rails_package)
+      expect(mock_manager).to have_received(:add).with(["[email protected]"], exact: true)
+    end
+
+    it "accepts npm format beta pre-releases (already with hyphen)" do
+      stub_const("ReactOnRails::VERSION", "16.2.0-beta.10")
+      instance.send(:add_react_on_rails_package)
+      expect(mock_manager).to have_received(:add).with(["[email protected]"], exact: true)
+    end
+
+    it "accepts npm format alpha releases (already with hyphen)" do
+      stub_const("ReactOnRails::VERSION", "16.0.0-alpha.5")
+      instance.send(:add_react_on_rails_package)
+      expect(mock_manager).to have_received(:add).with(["[email protected]"], exact: true)
+    end
+
+    it "adds react-on-rails without version for invalid version formats" do
+      stub_const("ReactOnRails::VERSION", "invalid-version")
+      instance.send(:add_react_on_rails_package)
       expect(mock_manager).to have_received(:add).with(["react-on-rails"], exact: true)
     end
 
+    it "warns about invalid version format when version doesn't match semver" do
+      stub_const("ReactOnRails::VERSION", "invalid-version")
+
+      # Capture stdout to verify the warning message
+      expect do
+        instance.send(:add_react_on_rails_package)
+      end.to output(/WARNING: Unrecognized version format invalid-version/).to_stdout
+    end
+
     it "adds warning when add_package fails" do
       allow(mock_manager).to receive(:add).and_return(false)
       instance.package_json = nil