Skip to content

Commit 47c4b49

Browse files
Remove Node version matrix from package-js-tests to match CircleCI
The CircleCI config runs package-js-tests on a single Node version (whatever comes with cimg/ruby:3.3.7-browsers), not multiple versions. Removed the unnecessary matrix strategy that was testing on both Node 20 and 22. Now runs on Node 22 only, matching the single-version behavior of CircleCI. Changes: - Removed strategy.matrix.node-version - Changed from ${{ matrix.node-version }} to fixed node-version: 22 - Updated artifact name from pro-jest-results-node${{ matrix.node-version }} to pro-jest-results 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 28892b1 commit 47c4b49

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

.github/workflows/pro-package-tests.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,6 @@ jobs:
9797
# Jest unit tests for Pro package
9898
package-js-tests:
9999
needs: build-dummy-app-webpack-test-bundles
100-
strategy:
101-
matrix:
102-
node-version: ['20', '22']
103100
runs-on: ubuntu-22.04
104101
env:
105102
REACT_ON_RAILS_PRO_LICENSE: ${{ secrets.REACT_ON_RAILS_PRO_LICENSE }}
@@ -111,7 +108,7 @@ jobs:
111108
- name: Setup Node
112109
uses: actions/setup-node@v4
113110
with:
114-
node-version: ${{ matrix.node-version }}
111+
node-version: 22
115112
cache: yarn
116113
cache-dependency-path: 'react_on_rails_pro/**/yarn.lock'
117114

@@ -160,7 +157,7 @@ jobs:
160157
uses: actions/upload-artifact@v4
161158
if: always()
162159
with:
163-
name: pro-jest-results-node${{ matrix.node-version }}
160+
name: pro-jest-results
164161
path: react_on_rails_pro/jest
165162

166163
# RSpec tests for Pro package

0 commit comments

Comments
 (0)