Skip to content

Commit 4934897

Browse files
justin808claude
justin808
and
claude
committed
Add full-ci label support to all detect-changes workflows
Extended the full-ci label checking mechanism from main.yml to all workflows that use detect-changes pattern. This ensures /run-skipped-ci command works across all CI jobs, not just main tests. Changes: - package-js-tests.yml: Check full-ci label, run Node 20 when label present - lint-js-and-ruby.yml: Check full-ci label before change detection - rspec-package-specs.yml: Check full-ci label, run Ruby 3.2 when label present All workflows now consistently: 1. Check for full-ci label first 2. If present, force all tests to run 3. Otherwise use normal change detection 4. Apply matrix exclude rules based on label presence 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 91b427e commit 4934897

File tree

3 files changed

+56
-4
lines changed

3 files changed

+56
-4
lines changed

‎.github/workflows/lint-js-and-ruby.yml‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,29 @@ jobs:
2323
run_ruby_tests: ${{ steps.detect.outputs.run_ruby_tests }}
2424
run_dummy_tests: ${{ steps.detect.outputs.run_dummy_tests }}
2525
run_generators: ${{ steps.detect.outputs.run_generators }}
26+
has_full_ci_label: ${{ steps.check-label.outputs.result }}
2627
steps:
2728
- uses: actions/checkout@v4
2829
with:
2930
fetch-depth: 0
3031
persist-credentials: false
32+
- name: Check for full-ci label
33+
id: check-label
34+
uses: ./.github/actions/check-full-ci-label
3135
- name: Detect relevant changes
3236
id: detect
3337
run: |
38+
# If full-ci label is present, run everything
39+
if [ "${{ steps.check-label.outputs.result }}" = "true" ]; then
40+
echo "run_lint=true" >> "$GITHUB_OUTPUT"
41+
echo "run_js_tests=true" >> "$GITHUB_OUTPUT"
42+
echo "run_ruby_tests=true" >> "$GITHUB_OUTPUT"
43+
echo "run_dummy_tests=true" >> "$GITHUB_OUTPUT"
44+
echo "run_generators=true" >> "$GITHUB_OUTPUT"
45+
echo "docs_only=false" >> "$GITHUB_OUTPUT"
46+
exit 0
47+
fi
48+
3449
BASE_REF="${{ github.event.pull_request.base.sha || github.event.before || 'origin/master' }}"
3550
script/ci-changes-detector "$BASE_REF"
3651
shell: bash

‎.github/workflows/package-js-tests.yml‎

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,31 +27,49 @@ jobs:
2727
run_ruby_tests: ${{ steps.detect.outputs.run_ruby_tests }}
2828
run_dummy_tests: ${{ steps.detect.outputs.run_dummy_tests }}
2929
run_generators: ${{ steps.detect.outputs.run_generators }}
30+
has_full_ci_label: ${{ steps.check-label.outputs.result }}
3031
steps:
3132
- uses: actions/checkout@v4
3233
with:
3334
# Fetch enough history for change detection (50 commits is usually sufficient for PRs)
3435
fetch-depth: 50
3536
persist-credentials: false
37+
- name: Check for full-ci label
38+
id: check-label
39+
uses: ./.github/actions/check-full-ci-label
3640
- name: Detect relevant changes
3741
id: detect
3842
run: |
43+
# If full-ci label is present, run everything
44+
if [ "${{ steps.check-label.outputs.result }}" = "true" ]; then
45+
echo "run_lint=true" >> "$GITHUB_OUTPUT"
46+
echo "run_js_tests=true" >> "$GITHUB_OUTPUT"
47+
echo "run_ruby_tests=true" >> "$GITHUB_OUTPUT"
48+
echo "run_dummy_tests=true" >> "$GITHUB_OUTPUT"
49+
echo "run_generators=true" >> "$GITHUB_OUTPUT"
50+
echo "docs_only=false" >> "$GITHUB_OUTPUT"
51+
exit 0
52+
fi
53+
3954
BASE_REF="${{ github.event.pull_request.base.sha || github.event.before || 'origin/master' }}"
4055
script/ci-changes-detector "$BASE_REF"
4156
shell: bash
4257

4358
build:
4459
needs: detect-changes
45-
# Run on master OR when JS tests needed on PR (but skip Node 20 on PR)
60+
# Run on master OR when JS tests needed on PR
4661
if: |
4762
(github.ref == 'refs/heads/master' || needs.detect-changes.outputs.run_js_tests == 'true')
4863
strategy:
4964
matrix:
5065
include:
5166
# Always run: Latest Node version (fast feedback on PRs)
5267
- node-version: '22'
53-
# Master only: Minimum supported Node version (full coverage)
68+
# Master and full-ci label: Minimum supported Node version (full coverage)
5469
- node-version: '20'
70+
exclude:
71+
# Skip minimum dependency matrix on regular PRs (run only on master or with full-ci label)
72+
- node-version: ${{ github.event_name == 'pull_request' && github.ref != 'refs/heads/master' && needs.detect-changes.outputs.has_full_ci_label != 'true' && '20' || '' }}
5573
runs-on: ubuntu-22.04
5674
steps:
5775
- uses: actions/checkout@v4

‎.github/workflows/rspec-package-specs.yml‎

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,22 +27,37 @@ jobs:
2727
run_ruby_tests: ${{ steps.detect.outputs.run_ruby_tests }}
2828
run_dummy_tests: ${{ steps.detect.outputs.run_dummy_tests }}
2929
run_generators: ${{ steps.detect.outputs.run_generators }}
30+
has_full_ci_label: ${{ steps.check-label.outputs.result }}
3031
steps:
3132
- uses: actions/checkout@v4
3233
with:
3334
# Fetch enough history for change detection (50 commits is usually sufficient for PRs)
3435
fetch-depth: 50
3536
persist-credentials: false
37+
- name: Check for full-ci label
38+
id: check-label
39+
uses: ./.github/actions/check-full-ci-label
3640
- name: Detect relevant changes
3741
id: detect
3842
run: |
43+
# If full-ci label is present, run everything
44+
if [ "${{ steps.check-label.outputs.result }}" = "true" ]; then
45+
echo "run_lint=true" >> "$GITHUB_OUTPUT"
46+
echo "run_js_tests=true" >> "$GITHUB_OUTPUT"
47+
echo "run_ruby_tests=true" >> "$GITHUB_OUTPUT"
48+
echo "run_dummy_tests=true" >> "$GITHUB_OUTPUT"
49+
echo "run_generators=true" >> "$GITHUB_OUTPUT"
50+
echo "docs_only=false" >> "$GITHUB_OUTPUT"
51+
exit 0
52+
fi
53+
3954
BASE_REF="${{ github.event.pull_request.base.sha || github.event.before || 'origin/master' }}"
4055
script/ci-changes-detector "$BASE_REF"
4156
shell: bash
4257

4358
rspec-package-tests:
4459
needs: detect-changes
45-
# Run on master OR when Ruby tests needed on PR (but skip minimum deps on PR)
60+
# Run on master OR when Ruby tests needed on PR
4661
if: |
4762
(github.ref == 'refs/heads/master' || needs.detect-changes.outputs.run_ruby_tests == 'true')
4863
strategy:
@@ -52,9 +67,13 @@ jobs:
5267
# Always run: Latest versions (fast feedback on PRs)
5368
- ruby-version: '3.4'
5469
dependency-level: 'latest'
55-
# Master only: Minimum supported versions (full coverage)
70+
# Master and full-ci label: Minimum supported versions (full coverage)
5671
- ruby-version: '3.2'
5772
dependency-level: 'minimum'
73+
exclude:
74+
# Skip minimum dependency matrix on regular PRs (run only on master or with full-ci label)
75+
- ruby-version: ${{ github.event_name == 'pull_request' && github.ref != 'refs/heads/master' && needs.detect-changes.outputs.has_full_ci_label != 'true' && '3.2' || '' }}
76+
dependency-level: ${{ github.event_name == 'pull_request' && github.ref != 'refs/heads/master' && needs.detect-changes.outputs.has_full_ci_label != 'true' && 'minimum' || '' }}
5877
env:
5978
BUNDLE_FROZEN: ${{ matrix.dependency-level == 'minimum' && 'false' || 'true' }}
6079
runs-on: ubuntu-22.04

0 commit comments

Comments
 (0)