Skip to content

Commit 4a3eacb

Browse files
committed
Update react_on_rails_pro build paths after node-renderer extraction
After Phase 5 moved the node-renderer from react_on_rails_pro/packages/node-renderer/ to packages/react-on-rails-pro-node-renderer/, all build scripts in the old Pro directory need to reference the new location. ## Changes ### package-scripts.yml - Updated all script paths from packages/node-renderer/ to ../packages/react-on-rails-pro-node-renderer/ - Changed dist/ to lib/ (new output directory name) - Updated paths in: test, check-typescript, node-renderer, build, build.prepack, clean, format.json, renderer ### package.json - Updated exports paths to point to ../packages/react-on-rails-pro-node-renderer/lib/ - Removed bin entry (node-renderer is now a separate package with its own bin) - Updated files array to include new lib directory - Updated jest config: collectCoverageFrom and setupFiles paths ### Configuration files - .gitignore: Updated test tmp directory path - .prettierignore: Updated fixtures path - eslint.config.mjs: Updated all references to node-renderer paths ## Testing ✅ nps build - successfully builds to new location ✅ nps build.prepack - finds built files at new path ✅ Build outputs exist at packages/react-on-rails-pro-node-renderer/lib/ This fixes the CI yalc publish failure that was looking for files at the old path. Related: #2069 (Phase 5 monorepo migration)
1 parent b113fad commit 4a3eacb

File tree

5 files changed

+27
-30
lines changed

5 files changed

+27
-30
lines changed

react_on_rails_pro/.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ junit.xml
4848

4949
node_modules
5050

51-
/packages/node-renderer/tests/tmp
51+
/../packages/react-on-rails-pro-node-renderer/tests/tmp
5252

5353
yarn-debug.*
5454
spec/dummy/client/yarn-debug.log*

react_on_rails_pro/.prettierignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
node_modules
22
**/node_modules/**
3-
packages/node-renderer/tests/fixtures/projects
3+
../packages/react-on-rails-pro-node-renderer/tests/fixtures/projects
44
**/tmp
55
**/public
66
**/package.json

react_on_rails_pro/eslint.config.mjs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ export default defineConfig([
2222
'spec/react_on_rails/dummy-for-generators',
2323
// includes some generated code
2424
'spec/dummy/client/app/packs/server-bundle.js',
25-
'packages/node-renderer/lib/',
26-
'packages/node-renderer/tests/fixtures',
25+
'../packages/react-on-rails-pro-node-renderer/lib/',
26+
'../packages/react-on-rails-pro-node-renderer/tests/fixtures',
2727
'**/node_modules/',
2828
'**/assets/webpack/',
2929
'**/generated/',
@@ -166,7 +166,7 @@ export default defineConfig([
166166
},
167167
},
168168
{
169-
files: ['packages/node-renderer/tests/**', '**/*.test.{js,jsx,ts,tsx}'],
169+
files: ['../packages/react-on-rails-pro-node-renderer/tests/**', '**/*.test.{js,jsx,ts,tsx}'],
170170

171171
extends: [jest.configs['flat/recommended'], jest.configs['flat/style']],
172172

@@ -183,8 +183,8 @@ export default defineConfig([
183183
},
184184
},
185185
{
186-
files: ['packages/node-renderer/src/integrations/**'],
187-
ignores: ['packages/node-renderer/src/integrations/api.ts'],
186+
files: ['../packages/react-on-rails-pro-node-renderer/src/integrations/**'],
187+
ignores: ['../packages/react-on-rails-pro-node-renderer/src/integrations/api.ts'],
188188

189189
rules: {
190190
// Integrations should only use the public integration API

react_on_rails_pro/package-scripts.yml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,38 +2,38 @@ scripts:
22
test:
33
default:
44
description: Run all JS tests
5-
script: jest packages/node-renderer
5+
script: jest ../packages/react-on-rails-pro-node-renderer
66
ci:
77
description: Run all JS tests in CI mode
88
# https://circleci.com/docs/collect-test-data/#jest
9-
script: jest --ci --runInBand --reporters=default --reporters=jest-junit -- packages/node-renderer
9+
script: jest --ci --runInBand --reporters=default --reporters=jest-junit -- ../packages/react-on-rails-pro-node-renderer
1010
debug:
1111
description: Debug all JS tests
12-
script: ndb jest --runInBand packages/node-renderer
12+
script: ndb jest --runInBand ../packages/react-on-rails-pro-node-renderer
1313
check:
1414
description: Run all checks
1515
script: nps lint && nps format.listDifferent && nps test && nps check-typescript
1616
check-typescript:
1717
description: Check for TypeScript errors
18-
script: nps "build --noEmit" && tsc --project packages/node-renderer/tests && cd spec/dummy && yarn run tsc -p ./tsconfig.json --noEmit
18+
script: nps "build --noEmit" && tsc --project ../packages/react-on-rails-pro-node-renderer/tests && cd spec/dummy && yarn run tsc -p ./tsconfig.json --noEmit
1919
fix:
2020
description: Run all code fixes before committing
2121
script: nps eslint.fix && nps format
2222
node-renderer:
2323
default:
2424
description:
25-
script: nps build && node --enable-source-maps packages/node-renderer/dist/default-node-renderer.js
25+
script: nps build && node --enable-source-maps ../packages/react-on-rails-pro-node-renderer/lib/default-node-renderer.js
2626
debug:
2727
description: Debug Node Renderer
28-
script: rm -rf /tmp/react-on-rails-pro-node-renderer-bundles && nps build && RENDERER_LOG_LEVEL=info NODE_DEBUG=ROR node --enable-source-maps packages/node-renderer/dist/default-node-renderer.js
28+
script: rm -rf /tmp/react-on-rails-pro-node-renderer-bundles && nps build && RENDERER_LOG_LEVEL=info NODE_DEBUG=ROR node --enable-source-maps ../packages/react-on-rails-pro-node-renderer/lib/default-node-renderer.js
2929
lint:
3030
description: Run all linters
3131
script: concurrently --prefix "[{name}]" --names "ESLINT, RUBOCOP, PRETTIER" -c "blue,yellow,magenta,orange" "nps eslint" "bundle exec rubocop" "nps format.listDifferent"
3232

3333
build:
3434
default:
3535
description: Build the project
36-
script: echo "building the project" && rm -rf packages/node-renderer/dist && tsc --project packages/node-renderer/src
36+
script: echo "building the project" && rm -rf ../packages/react-on-rails-pro-node-renderer/lib && tsc --project ../packages/react-on-rails-pro-node-renderer/src
3737
prepack:
3838
description: Build the project in the prepack/prepare scripts
3939
# This is necessary when used as a Git dependency since we don't have the dist directory in the repo.
@@ -44,14 +44,14 @@ scripts:
4444
# 3. Check if the project is built now;
4545
# 4. If it failed, print an error message (still follow https://docs.npmjs.com/cli/v8/using-npm/scripts#best-practices).
4646
script: >
47-
[ -f packages/node-renderer/dist/ReactOnRailsProNodeRenderer.js ] ||
47+
[ -f ../packages/react-on-rails-pro-node-renderer/lib/ReactOnRailsProNodeRenderer.js ] ||
4848
(nps build >/dev/null 2>&1 || true) &&
49-
[ -f packages/node-renderer/dist/ReactOnRailsProNodeRenderer.js ] ||
49+
[ -f ../packages/react-on-rails-pro-node-renderer/lib/ReactOnRailsProNodeRenderer.js ] ||
5050
{ echo 'Building react-on-rails-pro-node-renderer seems to have failed!'; }
5151
5252
clean:
5353
description: Clean the project
54-
script: rm -rf packages/node-renderer/dist
54+
script: rm -rf ../packages/react-on-rails-pro-node-renderer/lib
5555

5656
eslint:
5757
default:
@@ -95,15 +95,15 @@ scripts:
9595
json:
9696
default:
9797
description: Run prettier on JSON files.
98-
script: rm -rf packages/node-renderer/tests/tmp && prettier "**/*.json" --write
98+
script: rm -rf ../packages/react-on-rails-pro-node-renderer/tests/tmp && prettier "**/*.json" --write
9999
listDifferent:
100100
description: Check if any JSON files would change by running prettier.
101101
script: prettier "**/*.json" --list-different
102102

103103
renderer:
104104
default:
105105
description: Starts the node renderer.
106-
script: nps build && RENDERER_PORT=3800 RENDERER_SUPPORT_MODULES=TRUE node ./packages/node-renderer/dist/default-node-renderer.js
106+
script: nps build && RENDERER_PORT=3800 RENDERER_SUPPORT_MODULES=TRUE node ../packages/react-on-rails-pro-node-renderer/lib/default-node-renderer.js
107107
debug:
108108
description: Starts the node renderer with debugging enabled. See Node.js V8 --inspector Manager (NiM)
109-
script: nps build && RENDERER_WORKERS_COUNT=1 RENDERER_PORT=3800 RENDERER_SUPPORT_MODULES=TRUE ndb ./packages/node-renderer/dist/default-node-renderer.js
109+
script: nps build && RENDERER_WORKERS_COUNT=1 RENDERER_PORT=3800 RENDERER_SUPPORT_MODULES=TRUE ndb ../packages/react-on-rails-pro-node-renderer/lib/default-node-renderer.js

react_on_rails_pro/package.json

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,15 @@
55
"description": "react-on-rails-pro JavaScript for react_on_rails_pro Ruby gem",
66
"exports": {
77
".": {
8-
"types": "./packages/node-renderer/dist/ReactOnRailsProNodeRenderer.d.ts",
9-
"default": "./packages/node-renderer/dist/ReactOnRailsProNodeRenderer.js"
8+
"types": "../packages/react-on-rails-pro-node-renderer/lib/ReactOnRailsProNodeRenderer.d.ts",
9+
"default": "../packages/react-on-rails-pro-node-renderer/lib/ReactOnRailsProNodeRenderer.js"
1010
},
1111
"./integrations/*": {
12-
"types": "./packages/node-renderer/dist/integrations/*.d.ts",
13-
"default": "./packages/node-renderer/dist/integrations/*.js"
12+
"types": "../packages/react-on-rails-pro-node-renderer/lib/integrations/*.d.ts",
13+
"default": "../packages/react-on-rails-pro-node-renderer/lib/integrations/*.js"
1414
},
1515
"./package.json": "./package.json"
1616
},
17-
"bin": {
18-
"react-on-rails-pro-node-renderer": "packages/node-renderer/dist/default-node-renderer.js"
19-
},
2017
"directories": {
2118
"doc": "docs"
2219
},
@@ -98,7 +95,7 @@
9895
}
9996
},
10097
"files": [
101-
"packages/node-renderer/dist",
98+
"../packages/react-on-rails-pro-node-renderer/lib",
10299
"script/preinstall.js"
103100
],
104101
"scripts": {
@@ -135,15 +132,15 @@
135132
"jest": {
136133
"clearMocks": true,
137134
"collectCoverageFrom": [
138-
"packages/node-renderer/tests/**/*.{js,jsx,ts,tsx}"
135+
"../packages/react-on-rails-pro-node-renderer/tests/**/*.{js,jsx,ts,tsx}"
139136
],
140137
"coverageReporters": [
141138
"lcov"
142139
],
143140
"resetModules": true,
144141
"resetMocks": true,
145142
"setupFiles": [
146-
"./packages/node-renderer/tests/helper.ts"
143+
"../packages/react-on-rails-pro-node-renderer/tests/helper.ts"
147144
],
148145
"testEnvironment": "node",
149146
"transform": {

0 commit comments

Comments
 (0)