Commit 4c93dbb
authored
Fix doctor rake task LoadError with excluded task_helpers (#1795)
Resolves critical LoadError in `rake react_on_rails:doctor` when using the packaged gem.
**Problem:**
- The doctor.rake task (added in 27dba50) required "../../rakelib/task_helpers"
- The rakelib directory has been excluded from gem packaging since 2c04db6 (1.5+ years ago)
- This caused `LoadError: cannot load such file -- rakelib/task_helpers` in packaged gems
**Solution:**
- Remove unnecessary require_relative "../../rakelib/task_helpers" from doctor.rake
- Remove unused include ReactOnRails::TaskHelpers line
- Add test coverage to prevent future regressions
**Impact:**
- ✅ Doctor task now works correctly in packaged gems
- ✅ No functionality lost - TaskHelpers was not actually used
- ✅ Added regression test to ensure rake file loads without missing dependencies
- ✅ All existing tests pass
This fix enables users to run `rake react_on_rails:doctor` successfully in production environments and when using the published gem, restoring critical diagnostic functionality.1 parent f129062 commit 4c93dbb
File tree
2 files changed
+6
-3
lines changed- lib/tasks
- spec/lib/react_on_rails
2 files changed
+6
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | 3 | | |
5 | 4 | | |
6 | 5 | | |
| |||
38 | 37 | | |
39 | 38 | | |
40 | 39 | | |
41 | | - | |
42 | | - | |
43 | 40 | | |
44 | 41 | | |
45 | 42 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
19 | 25 | | |
20 | 26 | | |
21 | 27 | | |
| |||
0 commit comments