Skip to content

Commit 4d00510

Browse files
justin808claude
andcommitted
Re-enable RouterApp components for integration tests
The RouterApp components were temporarily disabled, causing integration tests to fail. Re-enabled them and updated knip config accordingly. Changes: - Renamed RouterApp.*.jsx.skip back to RouterApp.*.jsx - Removed RouterApp-related ignores from knip.ts - Removed react-router-dom from ignoreDependencies The RouterApp.server.jsx already has the correct import for react-router-dom v6 (react-router-dom/server.js). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 6a924fc commit 4d00510

File tree

3 files changed

+0
-8
lines changed

3 files changed

+0
-8
lines changed

knip.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -112,12 +112,6 @@ const config: KnipConfig = {
112112
'**/app-react16/**/*',
113113
// Playwright support files and helpers - generated by cypress-on-rails gem
114114
'e2e/playwright/support/**',
115-
// Temporarily disabled RouterApp components due to react-router-dom version mismatch
116-
'client/app/components/RouterFirstPage.jsx',
117-
'client/app/components/RouterLayout.jsx',
118-
'client/app/components/RouterSecondPage.jsx',
119-
'client/app/routes/routes.jsx',
120-
'client/app/startup/RouterApp.*.jsx.skip',
121115
],
122116
project: ['**/*.{js,cjs,mjs,jsx,ts,cts,mts,tsx}!', 'config/webpack/*.js'],
123117
paths: {
@@ -154,8 +148,6 @@ const config: KnipConfig = {
154148
'url-loader',
155149
// Transitive dependency of shakapacker but listed as direct dependency
156150
'webpack-merge',
157-
// Temporarily disabled due to version mismatch (v5 installed but v6 expected)
158-
'react-router-dom',
159151
],
160152
},
161153
},

0 commit comments

Comments
 (0)