Skip to content

Commit 4ec6490

Browse files
justin808claude
andcommitted
Fix script/convert for new monorepo structure
The script/convert tool is used by CI 'minimum' dependency tests to downgrade to minimum supported versions (Ruby 3.2, Node 20, Shakapacker 8.2.0, React 18). After the monorepo restructure (PR #2112), the script was failing because it was looking for spec/dummy/package.json at the old root location, but these files are now under react_on_rails/spec/dummy/ and react_on_rails_pro/spec/dummy/. Updated all file path references: - spec/dummy/package.json → react_on_rails/spec/dummy/package.json - spec/dummy/config/shakapacker.yml → react_on_rails/spec/dummy/config/shakapacker.yml Fixes CI failure: https://github.com/shakacode/react_on_rails/actions/runs/19624872033/job/56191736323 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent efbb07c commit 4ec6490

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

script/convert

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ def move(old_path, new_path)
1515
end
1616

1717
# Keep shakapacker.yml since we're using Shakapacker 8+
18-
# move("../spec/dummy/config/shakapacker.yml", "../spec/dummy/config/webpacker.yml")
18+
# move("../react_on_rails/spec/dummy/config/shakapacker.yml", "../react_on_rails/spec/dummy/config/webpacker.yml")
1919

2020
# Shakapacker - use version with async script loading support (8.2.0+)
2121
gsub_file_content("../Gemfile.development_dependencies", /gem "shakapacker", "[^"]*"/, 'gem "shakapacker", "8.2.0"')
22-
gsub_file_content("../spec/dummy/package.json", /"shakapacker": "[^"]*",/, '"shakapacker": "8.2.0",')
22+
gsub_file_content("../react_on_rails/spec/dummy/package.json", /"shakapacker": "[^"]*",/, '"shakapacker": "8.2.0",')
2323

2424
# The below packages don't work on the oldest supported Node version and aren't needed there anyway
2525
# Note: All dev dependencies remain in root package.json even after workspace migration
@@ -36,8 +36,8 @@ gsub_file_content("../package.json", /,(\s*})/, "\\1")
3636
# Switch to minimum supported React version (React 18 since we removed PropTypes)
3737
gsub_file_content("../package.json", /"react": "[^"]*",/, '"react": "18.0.0",')
3838
gsub_file_content("../package.json", /"react-dom": "[^"]*",/, '"react-dom": "18.0.0",')
39-
gsub_file_content("../spec/dummy/package.json", /"react": "[^"]*",/, '"react": "18.0.0",')
40-
gsub_file_content("../spec/dummy/package.json", /"react-dom": "[^"]*",/, '"react-dom": "18.0.0",')
39+
gsub_file_content("../react_on_rails/spec/dummy/package.json", /"react": "[^"]*",/, '"react": "18.0.0",')
40+
gsub_file_content("../react_on_rails/spec/dummy/package.json", /"react-dom": "[^"]*",/, '"react-dom": "18.0.0",')
4141
gsub_file_content(
4242
"../packages/react-on-rails-pro/package.json",
4343
/"test:non-rsc": "(?:\\"|[^"])*",/,

0 commit comments

Comments
 (0)