Clarify method naming: rename generated_assets_full_path → public_assets_full_path

- Add new `public_assets_full_path` method to be explicit about public asset paths
- Keep `generated_assets_full_path` as backwards-compatible deprecated alias
- Update internal references to use clearer `public_assets_full_path` method
- Addresses naming ambiguity concern about whether paths are public or private
- Prepares for future evolution toward simplified public-only asset resolution

This improvement clarifies the distinction between:
- Public asset paths (client bundles, manifests) → public_assets_full_path
- Private asset paths (server bundles with enforcement) → server_bundle_private_path

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

lib/react_on_rails/utils.rb

@@ -103,7 +103,7 @@ def self.bundle_js_file_path(bundle_name)
         # Default to the non-hashed name in the specified output directory, which, for legacy
         # React on Rails, this is the output directory picked up by the asset pipeline.
         # For Shakapacker, this is the public output path defined in the (shaka/web)packer.yml file.
-        File.join(generated_assets_full_path, bundle_name)
+        File.join(public_assets_full_path, bundle_name)
       end
     end
 
@@ -124,7 +124,7 @@ def self.bundle_js_file_path(bundle_name)
       fallback_locations << File.join("public", "packs", bundle_name)
 
       # 3. Generated assets path (for legacy setups)
-      fallback_locations << File.join(generated_assets_full_path, bundle_name)
+      fallback_locations << File.join(public_assets_full_path, bundle_name)
 
       fallback_locations.uniq!
 
@@ -176,7 +176,7 @@ def self.react_client_manifest_file_path
       @react_client_manifest_path = if ReactOnRails::PackerUtils.using_packer?
                                       ReactOnRails::PackerUtils.asset_uri_from_packer(file_name)
                                     else
-                                      File.join(generated_assets_full_path, file_name)
+                                      File.join(public_assets_full_path, file_name)
                                     end
     end
 
@@ -191,7 +191,7 @@ def self.react_server_client_manifest_file_path
               "react_server_client_manifest_file is nil, ensure it is set in your configuration"
       end
 
-      @react_server_manifest_path = File.join(generated_assets_full_path, asset_name)
+      @react_server_manifest_path = File.join(public_assets_full_path, asset_name)
     end
 
     def self.running_on_windows?
@@ -233,14 +233,19 @@ def self.using_packer_source_path_is_not_defined_and_custom_node_modules?
         ReactOnRails.configuration.node_modules_location.present?
     end
 
-    def self.generated_assets_full_path
+    def self.public_assets_full_path
       if ReactOnRails::PackerUtils.using_packer?
         ReactOnRails::PackerUtils.packer_public_output_path
       else
         File.expand_path(ReactOnRails.configuration.generated_assets_dir)
       end
     end
 
+    # DEPRECATED: Use public_assets_full_path for clarity about public vs private asset paths
+    def self.generated_assets_full_path
+      public_assets_full_path
+    end
+
     def self.gem_available?(name)
       Gem.loaded_specs[name].present?
     rescue Gem::LoadError