Complete removal of all packer_type references and restore documentation fix

- Remove packer_type method from PackerUtils
- Replace all ReactOnRails::PackerUtils.packer_type calls with hardcoded 'shakapacker'
- Update generator templates to use static values instead of ERB variables
- Fix test mocking to use PackerUtils.precompile? instead of direct Shakapacker calls
- Remove dynamic require statements in test files
- Restore documentation fix for RuboCop command (lost in force push)

This completes the simplification of the codebase by removing the dynamic
packer_type abstraction since we now only support Shakapacker.

Co-authored-by: Justin Gordon <[email protected]>

Author: justin808

docs/contributor-info/linters.md

@@ -10,7 +10,7 @@ If you haven't tried the autofix options for `eslint` and `rubocop`, you're seri
 2. **Rubocop:** Be sure to be in the correct directory where you have Ruby files, usually the top level of your Rails project.
 
 ```bash
-rubocop -a
+bundle exec rubocop -A
 ```
 
 3. **ESLint:** Be sure to be in the correct directory where you have JS files.

lib/generators/react_on_rails/base_generator.rb

@@ -41,7 +41,7 @@ def copy_base_files
         base_templates = %w[config/initializers/react_on_rails.rb]
         base_files.each { |file| copy_file("#{base_path}#{file}", file) }
         base_templates.each do |file|
-          template("#{base_path}/#{file}.tt", file, { packer_type: ReactOnRails::PackerUtils.packer_type })
+          template("#{base_path}/#{file}.tt", file)
         end
       end
 

lib/generators/react_on_rails/templates/base/base/config/initializers/react_on_rails.rb.tt

@@ -24,8 +24,8 @@ ReactOnRails.configure do |config|
   # to automatically refresh your webpack assets on every test run.
   #
   # Alternately, you can remove the `ReactOnRails::TestHelper.configure_rspec_to_compile_assets`
-  # and set the config/<%= config[:packer_type] %>.yml option for test to true.
-  config.build_test_command = "RAILS_ENV=test bin/<%= config[:packer_type] %>"
+  # and set the config/shakapacker.yml option for test to true.
+  config.build_test_command = "RAILS_ENV=test bin/shakapacker"
 
   ################################################################################
   ################################################################################

lib/react_on_rails/configuration.rb

@@ -251,8 +251,8 @@ def adjust_precompile_task
         # We set it very big so that it is not used, and then clean just
         # removes files older than 1 hour.
         versions = 100_000
-        puts "Invoking task #{ReactOnRails::PackerUtils.packer_type}:clean from React on Rails"
-        Rake::Task["#{ReactOnRails::PackerUtils.packer_type}:clean"].invoke(versions)
+        puts "Invoking task shakapacker:clean from React on Rails"
+        Rake::Task["shakapacker:clean"].invoke(versions)
       }
 
       if Rake::Task.task_defined?("assets:precompile")
@@ -275,14 +275,14 @@ def error_if_using_packer_and_generated_assets_dir_not_match_public_output_path
 
       if File.expand_path(generated_assets_dir) == packer_public_output_path.to_s
         Rails.logger.warn("You specified generated_assets_dir in `config/initializers/react_on_rails.rb` " \
-                          "with #{ReactOnRails::PackerUtils.packer_type}. " \
+                          "with Shakapacker. " \
                           "Remove this line from your configuration file.")
       else
         msg = <<~MSG
-          Error configuring /config/initializers/react_on_rails.rb: You are using #{ReactOnRails::PackerUtils.packer_type}
+          Error configuring /config/initializers/react_on_rails.rb: You are using Shakapacker
           and your specified value for generated_assets_dir = #{generated_assets_dir}
           that does not match the value for public_output_path specified in
-          #{ReactOnRails::PackerUtils.packer_type}.yml = #{packer_public_output_path}. You should remove the configuration
+          shakapacker.yml = #{packer_public_output_path}. You should remove the configuration
           value for "generated_assets_dir" from your config/initializers/react_on_rails.rb file.
         MSG
         raise ReactOnRails::Error, msg
@@ -314,11 +314,11 @@ def configure_generated_assets_dirs_deprecation
       if ReactOnRails::PackerUtils.using_packer?
         packer_public_output_path = ReactOnRails::PackerUtils.packer_public_output_path
         # rubocop:disable Layout/LineLength
-        packer_name = ReactOnRails::PackerUtils.packer_type&.upcase_first
+        packer_name = "Shakapacker"
 
         Rails.logger.warn "Error configuring config/initializers/react_on_rails. Define neither the generated_assets_dirs nor " \
                           "the generated_assets_dir when using #{packer_name}. This is defined by " \
-                          "public_output_path specified in #{ReactOnRails::PackerUtils.packer_type}.yml = #{packer_public_output_path}."
+                          "public_output_path specified in shakapacker.yml = #{packer_public_output_path}."
         # rubocop:enable Layout/LineLength
         return
       end
@@ -363,17 +363,16 @@ def raise_missing_components_subdirectory
     end
 
     def compile_command_conflict_message
-      packer_name = ReactOnRails::PackerUtils.packer_type.upcase_first
-      packer_type = ReactOnRails::PackerUtils.packer_type
+      packer_name = "Shakapacker"
       <<~MSG
 
         React on Rails and #{packer_name} error in configuration!
         In order to use config/react_on_rails.rb config.build_production_command,
-        you must edit config/#{packer_type}.yml to include this value in the default configuration:
-        '#{packer_type}_precompile: false'
+        you must edit config/shakapacker.yml to include this value in the default configuration:
+        'shakapacker_precompile: false'
 
         Alternatively, remove the config/react_on_rails.rb config.build_production_command and the
-        default bin/#{packer_type} script will be used for assets:precompile.
+        default bin/shakapacker script will be used for assets:precompile.
 
       MSG
     end

lib/react_on_rails/packer_utils.rb

@@ -9,10 +9,6 @@ def self.using_packer?
       @using_packer = ReactOnRails::Utils.gem_available?("shakapacker")
     end
 
-    def self.packer_type
-      using_packer? ? "shakapacker" : nil
-    end
-
     def self.packer
       return nil unless using_packer?
 
@@ -120,7 +116,7 @@ def self.check_manifest_not_cached
       msg = <<-MSG.strip_heredoc
           ERROR: you have enabled cache_manifest in the #{Rails.env} env when using the
           ReactOnRails::TestHelper.configure_rspec_to_compile_assets helper
-          To fix this: edit your config/#{packer_type}.yml file and set cache_manifest to false for test.
+          To fix this: edit your config/shakapacker.yml file and set cache_manifest to false for test.
       MSG
       puts wrap_message(msg)
       exit!
@@ -141,7 +137,7 @@ def self.webpack_assets_status_checker
     def self.raise_nested_entries_disabled
       msg = <<~MSG
         **ERROR** ReactOnRails: `nested_entries` is configured to be disabled in shakapacker. Please update \
-        config/#{packer_type}.yml to enable nested entries. for more information read
+        config/shakapacker.yml to enable nested entries. for more information read
         https://www.shakacode.com/react-on-rails/docs/guides/file-system-based-automated-bundle-generation.md#enable-nested_entries-for-shakapacker
       MSG
 

lib/react_on_rails/test_helper.rb

@@ -89,7 +89,7 @@ def self.ensure_assets_compiled(webpack_assets_status_checker: nil,
           if ReactOnRails::PackerUtils.using_packer? &&
              ReactOnRails::Utils.using_packer_source_path_is_not_defined_and_custom_node_modules?
             msg = <<-MSG.strip_heredoc
-              WARNING: Define config/#{ReactOnRails::PackerUtils.packer_type}.yml to include sourcePath to configure
+              WARNING: Define config/shakapacker.yml to include sourcePath to configure
               the location of your JavaScript source for React on Rails.
               Default location of #{source_path} is used.
             MSG

lib/react_on_rails/test_helper/webpack_assets_compiler.rb

@@ -16,7 +16,7 @@ def compile_assets
 
             React on Rails is aborting your test run
 
-            If you wish to use the config/#{ReactOnRails::PackerUtils.packer_type}.yml compile option for tests
+            If you wish to use the config/shakapacker.yml compile option for tests
             them remove your call to the ReactOnRails test helper.
           MSG
           puts Rainbow(msg).red

spec/dummy/spec/rake/assets_precompile_rake_spec.rb

@@ -15,7 +15,7 @@
 
     ReactOnRails.configure do |config|
       config.build_production_command = "RAILS_ENV=production NODE_ENV=production /
-      bin/#{ReactOnRails::PackerUtils.packer_type}"
+      bin/shakapacker"
     end
 
     expect do

spec/react_on_rails/configuration_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require_relative "spec_helper"
-require ReactOnRails::PackerUtils.packer_type
 
 # rubocop:disable Metrics/ModuleLength
 
@@ -78,9 +77,7 @@ module ReactOnRails
     describe ".build_production_command" do
       context "when using Shakapacker 8" do
         it "fails when \"shakapacker_precompile\" is truly and \"build_production_command\" is truly" do
-          allow(ReactOnRails::PackerUtils).to receive(:using_packer?).and_return(true)
-          allow(Shakapacker).to receive_message_chain("config.shakapacker_precompile?")
-            .and_return(true)
+          allow(ReactOnRails::PackerUtils).to receive_messages(using_packer?: true, precompile?: true)
           expect do
             ReactOnRails.configure do |config|
               config.build_production_command = "RAILS_ENV=production NODE_ENV=production bin/shakapacker"
@@ -89,9 +86,7 @@ module ReactOnRails
         end
 
         it "doesn't fail when \"shakapacker_precompile\" is falsy and \"build_production_command\" is truly" do
-          allow(ReactOnRails::PackerUtils).to receive(:using_packer?).and_return(true)
-          allow(Shakapacker).to receive_message_chain("config.shakapacker_precompile?")
-            .and_return(false)
+          allow(ReactOnRails::PackerUtils).to receive_messages(using_packer?: true, precompile?: false)
           expect do
             ReactOnRails.configure do |config|
               config.build_production_command = "RAILS_ENV=production NODE_ENV=production bin/shakapacker"
@@ -100,18 +95,14 @@ module ReactOnRails
         end
 
         it "doesn't fail when \"shakapacker_precompile\" is truly and \"build_production_command\" is falsy" do
-          allow(ReactOnRails::PackerUtils).to receive(:using_packer?).and_return(true)
-          allow(Shakapacker).to receive_message_chain("config.shakapacker_precompile?")
-            .and_return(true)
+          allow(ReactOnRails::PackerUtils).to receive_messages(using_packer?: true, precompile?: true)
           expect do
             ReactOnRails.configure {} # rubocop:disable-line Lint/EmptyBlock
           end.not_to raise_error
         end
 
         it "doesn't fail when \"shakapacker_precompile\" is falsy and \"build_production_command\" is falsy" do
-          allow(ReactOnRails::PackerUtils).to receive(:using_packer?).and_return(true)
-          allow(Shakapacker).to receive_message_chain("config.shakapacker_precompile?")
-            .and_return(false)
+          allow(ReactOnRails::PackerUtils).to receive_messages(using_packer?: true, precompile?: false)
           expect do
             ReactOnRails.configure {} # rubocop:disable-line Lint/EmptyBlock
           end.not_to raise_error

spec/react_on_rails/utils_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require_relative "spec_helper"
-require ReactOnRails::PackerUtils.packer_type
 
 # rubocop:disable Metrics/ModuleLength, Metrics/BlockLength
 module ReactOnRails
@@ -30,7 +29,6 @@ module ReactOnRails
 
       # We don't need to mock anything here because the shakapacker gem is already installed and will be used by default
       it "uses shakapacker" do
-        expect(ReactOnRails::PackerUtils.packer_type).to eq("shakapacker")
         expect(ReactOnRails::PackerUtils.packer).to eq(::Shakapacker)
       end
     end
@@ -44,7 +42,6 @@ module ReactOnRails
 
       it "does not use packer" do
         expect(ReactOnRails::PackerUtils.using_packer?).to be(false)
-        expect(ReactOnRails::PackerUtils.packer_type).to be_nil
         expect(ReactOnRails::PackerUtils.packer).to be_nil
       end
     end