Address review comments: Enforce immediate_hydration fallback for non-Pro users

This commit addresses several issues identified in code review:

1. Fixed immediate_hydration logic in RenderOptions
   - Non-Pro users setting immediate_hydration: true now get false enforced
   - Previously returned true despite warning about fallback
   - Added explicit return false to match warning message behavior

2. Added warning logic to redux_store methods
   - Both helper.rb and controller.rb now warn non-Pro users
   - Enforces fallback by overriding to false when Pro license missing
   - Provides consistent behavior with react_component helper

3. Updated test expectations
   - render_options_spec.rb now expects false (not true) for non-Pro users
   - Added comprehensive redux_store tests for warning behavior
   - Tests cover all three scenarios: true, false, and nil values

4. Clarified CHANGELOG.md
   - Explicitly states fallback is enforced (value overridden to false)
   - Covers both components and stores in the migration notes

All tests passing and RuboCop clean.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

CHANGELOG.md

@@ -67,7 +67,7 @@ Changes since the last non-beta release.
   - Pro users: No action needed - immediate hydration is now enabled automatically for optimal performance
   - Non-Pro users: No action needed - standard hydration behavior continues to work as before
   - Component-level overrides: You can still override behavior per-component using `react_component("MyComponent", immediate_hydration: false)` or `redux_store("MyStore", immediate_hydration: true)`
-  - If a non-Pro user explicitly sets `immediate_hydration: true` on a component, a warning will be logged and the component will fall back to standard hydration
+  - If a non-Pro user explicitly sets `immediate_hydration: true` on a component or store, a warning will be logged and it will be enforced to fall back to standard hydration (the value will be overridden to `false`)
 
   [PR 1997](https://github.com/shakacode/react_on_rails/pull/1997) by [AbanoubGhadban](https://github.com/AbanoubGhadban).
 

lib/react_on_rails/controller.rb

@@ -15,7 +15,18 @@ module Controller
     # Be sure to include view helper `redux_store_hydration_data` at the end of your layout or view
     # or else there will be no client side hydration of your stores.
     def redux_store(store_name, props: {}, immediate_hydration: nil)
-      immediate_hydration = ReactOnRails::Utils.react_on_rails_pro? if immediate_hydration.nil?
+      # If non-Pro user explicitly sets immediate_hydration: true, warn and override to false
+      if immediate_hydration == true && !ReactOnRails::Utils.react_on_rails_pro?
+        Rails.logger.warn <<~WARNING
+          [REACT ON RAILS] Warning: immediate_hydration: true requires a React on Rails Pro license.
+          Store '#{store_name}' will fall back to standard hydration behavior.
+          Visit https://www.shakacode.com/react-on-rails-pro/ for licensing information.
+        WARNING
+        immediate_hydration = false
+      elsif immediate_hydration.nil?
+        immediate_hydration = ReactOnRails::Utils.react_on_rails_pro?
+      end
+
       redux_store_data = { store_name: store_name,
                            props: props,
                            immediate_hydration: immediate_hydration }

lib/react_on_rails/helper.rb

@@ -158,7 +158,17 @@ def react_component_hash(component_name, options = {})
     #    immediate_hydration: nil -- React on Rails Pro (licensed) feature. When nil (default), Pro users
     #                        get immediate hydration, non-Pro users don't. Can be explicitly overridden.
     def redux_store(store_name, props: {}, defer: false, immediate_hydration: nil)
-      immediate_hydration = ReactOnRails::Utils.react_on_rails_pro? if immediate_hydration.nil?
+      # If non-Pro user explicitly sets immediate_hydration: true, warn and override to false
+      if immediate_hydration == true && !ReactOnRails::Utils.react_on_rails_pro?
+        Rails.logger.warn <<~WARNING
+          [REACT ON RAILS] Warning: immediate_hydration: true requires a React on Rails Pro license.
+          Store '#{store_name}' will fall back to standard hydration behavior.
+          Visit https://www.shakacode.com/react-on-rails-pro/ for licensing information.
+        WARNING
+        immediate_hydration = false
+      elsif immediate_hydration.nil?
+        immediate_hydration = ReactOnRails::Utils.react_on_rails_pro?
+      end
 
       redux_store_data = { store_name: store_name,
                            props: props,

lib/react_on_rails/react_component/render_options.rb

@@ -98,13 +98,14 @@ def logging_on_server
       def immediate_hydration
         explicit_value = options[:immediate_hydration]
 
-        # Warn if non-Pro user explicitly sets immediate_hydration: true
+        # If non-Pro user explicitly sets immediate_hydration: true, warn and override to false
         if explicit_value == true && !ReactOnRails::Utils.react_on_rails_pro?
           Rails.logger.warn <<~WARNING
             [REACT ON RAILS] Warning: immediate_hydration: true requires a React on Rails Pro license.
             Component '#{react_component_name}' will fall back to standard hydration behavior.
             Visit https://www.shakacode.com/react-on-rails-pro/ for licensing information.
           WARNING
+          return false # Force fallback to standard hydration
         end
 
         options.fetch(:immediate_hydration) do

spec/dummy/spec/helpers/react_on_rails_helper_spec.rb

@@ -431,6 +431,43 @@ def helper.append_javascript_pack_tag(name, **options)
     it {
       expect(expect(store).target).to script_tag_be_included(react_store_script)
     }
+
+    context "without Pro license" do
+      before do
+        allow(ReactOnRails::Utils).to receive(:react_on_rails_pro?).and_return(false)
+      end
+
+      context "with immediate_hydration option set to true (not recommended)" do
+        it "returns false for immediate_hydration and logs a warning" do
+          expect(Rails.logger).to receive(:warn).with(/immediate_hydration: true requires a React on Rails Pro license/)
+
+          result = redux_store("reduxStore", props: props, immediate_hydration: true)
+
+          # Verify that the store tag does NOT have immediate hydration enabled
+          expect(result).not_to include('data-immediate-hydration="true"')
+        end
+      end
+
+      context "with immediate_hydration option set to false" do
+        it "returns false for immediate_hydration without warning" do
+          expect(Rails.logger).not_to receive(:warn)
+
+          result = redux_store("reduxStore", props: props, immediate_hydration: false)
+
+          # Verify that the store tag does NOT have immediate hydration enabled
+          expect(result).not_to include('data-immediate-hydration="true"')
+        end
+      end
+
+      context "without immediate_hydration option (nil)" do
+        it "defaults to false for non-Pro users" do
+          result = redux_store("reduxStore", props: props)
+
+          # Verify that the store tag does NOT have immediate hydration enabled
+          expect(result).not_to include('data-immediate-hydration="true"')
+        end
+      end
+    end
   end
 
   describe "#server_render_js", :js, type: :system do

spec/react_on_rails/react_component/render_options_spec.rb

@@ -209,15 +209,15 @@ def the_attrs(react_component_name: "App", options: {})
       end
 
       context "with immediate_hydration option set to true (not recommended)" do
-        it "returns true but logs a warning" do
+        it "returns false and logs a warning (enforces fallback)" do
           options = { immediate_hydration: true }
           attrs = the_attrs(options: options)
 
           expect(Rails.logger).to receive(:warn).with(/immediate_hydration: true requires a React on Rails Pro license/)
 
           opts = described_class.new(**attrs)
 
-          expect(opts.immediate_hydration).to be true
+          expect(opts.immediate_hydration).to be false
         end
       end