Fix CI lint failures and address review feedback

- Fix prettier formatting in test files
- Fix ESLint errors in demo components (unreachable code, line length)
- Remove issue references from demo component text
- Guard cleanup() against double-ending resultStream by delegating
  to endResultStream() which has writableEnded check
- Use bare `raise` instead of `raise e` to preserve original backtrace

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: AbanoubGhadban

packages/react-on-rails-pro-node-renderer/tests/handleStreamError.test.ts

@@ -22,7 +22,9 @@ describe('handleStreamError', () => {
     source.destroy(new Error('something went wrong during rendering'));
 
     await new Promise((resolve) => setTimeout(resolve, 50));
-    expect(onError).toHaveBeenCalledWith(expect.objectContaining({ message: 'something went wrong during rendering' }));
+    expect(onError).toHaveBeenCalledWith(
+      expect.objectContaining({ message: 'something went wrong during rendering' }),
+    );
 
     const streamEnded = await Promise.race([
       new Promise<'ended'>((resolve) => {

packages/react-on-rails-pro-node-renderer/tests/streamErrorHang.test.ts

@@ -162,9 +162,7 @@ describe('streaming render error handling - E2E', () => {
     expect(timedOut).toBe(false);
 
     // The error IS reported
-    expect(errorReporter.message).toHaveBeenCalledWith(
-      expect.stringContaining('mid-stream rendering error'),
-    );
+    expect(errorReporter.message).toHaveBeenCalledWith(expect.stringContaining('mid-stream rendering error'));
   }, 10000);
 
   it('HTTP response completes when rendering stream errors before any data', async () => {
@@ -173,9 +171,7 @@ describe('streaming render error handling - E2E', () => {
     // The response completes gracefully
     expect(timedOut).toBe(false);
 
-    expect(errorReporter.message).toHaveBeenCalledWith(
-      expect.stringContaining('immediate rendering error'),
-    );
+    expect(errorReporter.message).toHaveBeenCalledWith(expect.stringContaining('immediate rendering error'));
   }, 10000);
 
   it('HTTP response completes normally when stream ends without errors', async () => {

packages/react-on-rails-pro/src/injectRSCPayload.ts

@@ -326,12 +326,7 @@ export default function injectRSCPayload(
    */
   htmlStream.on('end', () => {
     const cleanup = () => {
-      if (flushTimeout) {
-        clearTimeout(flushTimeout);
-      }
-
-      flush();
-      resultStream.end();
+      endResultStream();
     };
 
     if (!rscPromise) {

react_on_rails_pro/app/helpers/react_on_rails_pro_helper.rb

@@ -445,7 +445,7 @@ def consumer_stream_async(on_complete:)
       rescue StandardError
         # Already resolved, safe to ignore
       end
-      raise e
+      raise
     end
 
     # Wait for and return the first chunk (blocking)

react_on_rails_pro/spec/dummy/client/app/ror-auto-load-components/StreamErrorDemo.jsx

@@ -11,11 +11,13 @@ const AlwaysFailsAsync = () => {
 
 const StreamErrorDemo = () => (
   <div style={{ fontFamily: 'sans-serif', padding: '20px' }}>
-    <h1>Stream Error Demo (Issue #2402)</h1>
-    <p>This component demonstrates the streaming hang bug.</p>
+    <h1>Stream Error Demo</h1>
+    <p>This component demonstrates stream error handling during SSR.</p>
     <p>The header above renders immediately as part of the shell.</p>
     <hr />
-    <Suspense fallback={<div style={{ color: 'orange' }}>Loading async content (will error after 2s)...</div>}>
+    <Suspense
+      fallback={<div style={{ color: 'orange' }}>Loading async content (will error after 2s)...</div>}
+    >
       <AlwaysFailsAsync />
     </Suspense>
     <hr />

react_on_rails_pro/spec/dummy/client/app/ror-auto-load-components/StreamShellErrorDemo.jsx

@@ -1,9 +1,5 @@
-import React from 'react';
-
 const StreamShellErrorDemo = () => {
   throw new Error('Component crashed immediately during shell render!');
-
-  return <div>This will never render</div>;
 };
 
 export default StreamShellErrorDemo;