Use node 16 to run oldes tests

Author: AbanoubGhadban

.github/workflows/main.yml

@@ -28,7 +28,7 @@ jobs:
     - name: Setup Node
       uses: actions/setup-node@v4
       with:
-        node-version: ${{ matrix.versions == 'oldest' && '18' || '20' }}
+        node-version: ${{ matrix.versions == 'oldest' && '16' || '20' }}
     - name: Print system information
       run: |
         echo "Linux release: "; cat /etc/issue
@@ -104,7 +104,7 @@ jobs:
     - name: Setup Node
       uses: actions/setup-node@v4
       with:
-        node-version: ${{ matrix.versions == 'oldest' && '18' || '20' }}
+        node-version: ${{ matrix.versions == 'oldest' && '16' || '20' }}
     - name: Print system information
       run: |
         echo "Linux release: "; cat /etc/issue

.github/workflows/package-js-tests.yml

@@ -45,4 +45,5 @@ jobs:
       run: yarn test
     # TODO: Remove this once we made these tests compatible with React 19
     - name: Run JS unit tests for Renderer package with React 18 (for tests not compatible with React 19)
+      if: matrix.versions == 'newest'
       run: yarn test:react-18

jest.config.js

@@ -12,5 +12,7 @@ module.exports = {
       }
     : {
         'react-server-dom-webpack/client': '<rootDir>/node_package/tests/emptyForTesting.js',
+        '^@testing-library/dom$': '<rootDir>/node_package/tests/emptyForTesting.js',
+        '^@testing-library/react$': '<rootDir>/node_package/tests/emptyForTesting.js',
       },
 };

script/convert

@@ -15,8 +15,10 @@ File.rename(old_config, new_config)
 
 gsub_file_content("../Gemfile.development_dependencies", 'gem "shakapacker", "8.0.0"', 'gem "shakapacker", "6.6.0"')
 
-# Knip doesn't work on the oldest supported Node version and isn't needed there anyway
+# The following packages don't work on the oldest supported Node version and aren't needed there anyway
 gsub_file_content("../package.json", /"knip": "[^"]*",/, "")
+gsub_file_content("../package.json", %r{"@testing-library/dom": "[^"]*",}, "")
+gsub_file_content("../package.json", %r{"@testing-library/react": "[^"]*",}, "")
 
 gsub_file_content("../spec/dummy/package.json", '"shakapacker": "8.0.0",', '"shakapacker": "6.6.0",')