Skip to content

Commit 62e9f01

Browse files
justin808claude
andcommitted
Fix RuboCop violations and update documentation
- Fix duplicate and incomplete test cases in utils_spec.rb - Update configuration.md to reflect correct default for server_bundle_output_path - Add clarification about enforce_private_server_bundles enforcement 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 52b8cf3 commit 62e9f01

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

docs/guides/configuration.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,11 +131,12 @@ ReactOnRails.configure do |config|
131131

132132
# Directory where server bundles will be output during build process.
133133
# This allows organizing server-side rendering assets separately from client assets.
134-
# Default is nil (disabled). Set to "ssr-generated" or your preferred directory to enable.
134+
# Default is "ssr-generated". Set to your preferred directory path as needed.
135135
# config.server_bundle_output_path = "ssr-generated"
136136

137137
# When enabled, enforces that server bundles are only loaded from private, designated locations
138138
# to prevent potential security risks from loading untrusted server-side code.
139+
# When enabled, server_bundle_output_path must point to a private location outside the public directory.
139140
# Default is false for backward compatibility.
140141
config.enforce_private_server_bundles = false
141142

spec/react_on_rails/utils_spec.rb

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -160,12 +160,6 @@ def mock_dev_server_running
160160
expect(result).to eq(standard_path)
161161
end
162162

163-
it "returns environment-specific path when no bundle exists anywhere" do
164-
allow(File).to receive(:exist?).and_call_original
165-
allow(File).to receive(:exist?).and_return(false)
166-
167-
end
168-
169163
it "returns environment-specific path when no bundle exists anywhere" do
170164
allow(File).to receive(:exist?).and_call_original
171165
allow(File).to receive(:exist?).and_return(false)

0 commit comments

Comments
 (0)