Skip to content

Commit 6629532

Browse files
justin808claude
andcommitted
Fix: Update documentation paths and ESM imports
- Update MIGRATION_QUICK_REFERENCE.md to reflect completed phases - Fix documentation path references (remove .conductor/surabaya-v1 prefix) - Add .js extensions to ESM imports in ReactOnRailsProNodeRenderer - Apply Prettier formatting to eslint.config.ts and test fixtures All changes are formatting fixes and path corrections with no functional impact. RuboCop: 0 offenses, ESLint: clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent c2f0e5b commit 6629532

File tree

4 files changed

+18
-18
lines changed

4 files changed

+18
-18
lines changed

.claude/docs/analysis/MIGRATION_QUICK_REFERENCE.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
```
66
Phase 1: Pre-Merger Preparation ✅ COMPLETE
77
Phase 2: Git Repository Merger ✅ COMPLETE (PR #1824)
8-
Phase 3: Pre-Monorepo Structure Prep 🔄 IN PROGRESS
9-
Phase 4: Final Monorepo Restructuring ⏳ PLANNED
10-
Phase 5: CI/CD & Tooling Unification ⏳ PLANNED
8+
Phase 3: Pre-Monorepo Structure Prep ✅ COMPLETE
9+
Phase 4: Final Monorepo Restructuring ✅ COMPLETE
10+
Phase 5: Pro Node Renderer Package ✅ COMPLETE (PR #2069)
1111
Phase 6: Documentation & Polish ⏳ PLANNED
1212
Phase 7: Post-Migration Cleanup ⏳ PLANNED
1313
```
@@ -185,10 +185,10 @@ cd packages/react-on-rails && yarn build
185185
## Documentation References
186186

187187
- 📖 **Main Plan**: `/docs/MONOREPO_MERGER_PLAN.md`
188-
- 🔍 **Detailed Analysis**: `/.conductor/surabaya-v1/.claude/docs/analysis/MONOREPO_MIGRATION_ANALYSIS.md`
188+
- 🔍 **Detailed Analysis**: `/.claude/docs/analysis/MONOREPO_MIGRATION_ANALYSIS.md`
189189
- 📝 **Contributing Guide**: `/CONTRIBUTING.md`
190-
- ⚙️ **Path Management**: `/.conductor/surabaya-v1/.claude/docs/managing-file-paths.md`
191-
- 🏗️ **Build Scripts**: `/.conductor/surabaya-v1/.claude/docs/testing-build-scripts.md`
190+
- ⚙️ **Path Management**: `/.claude/docs/managing-file-paths.md`
191+
- 🏗️ **Build Scripts**: `/.claude/docs/testing-build-scripts.md`
192192

193193
## Next Actions
194194

eslint.config.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -258,15 +258,6 @@ const config = tsEslint.config([
258258
'import/extensions': 'off',
259259
},
260260
},
261-
{
262-
files: ['packages/react-on-rails-pro-node-renderer/tests/**/*'],
263-
rules: {
264-
// Allow non-null assertions in tests - they're acceptable for test data
265-
'@typescript-eslint/no-non-null-assertion': 'off',
266-
// Some tests validate error conditions without explicit assertions
267-
'jest/expect-expect': 'off',
268-
},
269-
},
270261
{
271262
files: ['**/app-react16/**/*'],
272263
rules: {
@@ -289,6 +280,15 @@ const config = tsEslint.config([
289280
'testing-library/no-node-access': 'off',
290281
},
291282
},
283+
{
284+
files: ['packages/react-on-rails-pro-node-renderer/tests/**/*'],
285+
rules: {
286+
// Allow non-null assertions in tests - they're acceptable for test data
287+
'@typescript-eslint/no-non-null-assertion': 'off',
288+
// Some tests validate error conditions without explicit assertions
289+
'jest/expect-expect': 'off',
290+
},
291+
},
292292
// must be the last config in the array
293293
// https://github.com/prettier/eslint-plugin-prettier?tab=readme-ov-file#configuration-new-eslintconfigjs
294294
prettierRecommended,

packages/react-on-rails-pro-node-renderer/src/ReactOnRailsProNodeRenderer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,10 @@ and for "@fastify/..." dependencies in your package.json. Consider removing them
3838
log.info('Running renderer in single process mode (workersCount: 0)');
3939
}
4040

41-
const worker = require('./worker') as typeof import('./worker.js');
41+
const worker = require('./worker.js') as typeof import('./worker.js');
4242
await worker.default(config).ready();
4343
} else {
44-
const master = require('./master') as typeof import('./master.js');
44+
const master = require('./master.js') as typeof import('./master.js');
4545
master.default(config);
4646
}
4747
/* eslint-enable global-require,@typescript-eslint/no-require-imports */

packages/react-on-rails-pro-node-renderer/tests/fixtures/projects/friendsandguests/1a7fe417/listingsShowRenderingRequest.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)