remove options parameter from registerServerComponent and update related tests

Author: AbanoubGhadban

lib/react_on_rails/packs_generator.rb

@@ -93,14 +93,10 @@ def pack_file_contents(file_path)
                                ReactOnRailsPro.configuration.enable_rsc_support
 
       if load_server_components && !client_entrypoint?(file_path)
-        rsc_payload_generation_url_path = ReactOnRailsPro.configuration.rsc_payload_generation_url_path
-
         return <<~FILE_CONTENT.strip
           import registerServerComponent from 'react-on-rails/registerServerComponent/client';
 
-          registerServerComponent({
-            rscPayloadGenerationUrlPath: "#{rsc_payload_generation_url_path}",
-          }, "#{registered_component_name}")
+          registerServerComponent("#{registered_component_name}");
         FILE_CONTENT
       end
 

node_package/src/registerServerComponent/client.tsx

@@ -1,7 +1,7 @@
 import * as React from 'react';
 import ReactOnRails from '../ReactOnRails.client.ts';
 import RSCRoute from '../RSCRoute.ts';
-import { ReactComponentOrRenderFunction, RegisterServerComponentOptions } from '../types/index.ts';
+import { ReactComponentOrRenderFunction } from '../types/index.ts';
 import WrapServerComponentRenderer from '../wrapServerComponentRenderer/client.tsx';
 
 /**
@@ -29,14 +29,12 @@ import WrapServerComponentRenderer from '../wrapServerComponentRenderer/client.t
  *
  * @example
  * ```js
- * registerServerComponent({
- *   rscPayloadGenerationUrlPath: '/rsc_payload'
- * }, 'ServerComponent1', 'ServerComponent2');
+ * registerServerComponent('ServerComponent1', 'ServerComponent2');
  *
  * // When ServerComponent1 renders, it will fetch from: /rsc_payload/ServerComponent1
  * ```
  */
-const registerServerComponent = (options: RegisterServerComponentOptions, ...componentNames: string[]) => {
+const registerServerComponent = (...componentNames: string[]) => {
   const componentsWrappedInRSCRoute: Record<string, ReactComponentOrRenderFunction> = {};
   for (const name of componentNames) {
     componentsWrappedInRSCRoute[name] = WrapServerComponentRenderer((props: unknown) => (

node_package/src/types/index.ts

@@ -162,10 +162,6 @@ export interface RegisteredComponent {
   isRenderer: boolean;
 }
 
-export interface RegisterServerComponentOptions {
-  rscPayloadGenerationUrlPath: string;
-}
-
 export type ItemRegistrationCallback<T> = (component: T) => void;
 
 interface Params {

node_package/tests/registerServerComponent.client.test.jsx

@@ -62,7 +62,7 @@ enableFetchMocks();
     const { stream, push } = createNodeReadableStream();
     window.fetchMock.mockResolvedValue(new Response(stream));
 
-    registerServerComponent({}, 'TestComponent');
+    registerServerComponent('TestComponent');
     const railsContext = {
       rscPayloadGenerationUrl: rscPayloadGenerationUrlPath,
       componentSpecificMetadata: {
@@ -172,7 +172,7 @@ enableFetchMocks();
       chunk1 = JSON.stringify(JSON.parse(fs.readFileSync(path.join(chunksDirectory, 'chunk1.json'), 'utf8')));
       chunk2 = JSON.stringify(JSON.parse(fs.readFileSync(path.join(chunksDirectory, 'chunk2.json'), 'utf8')));
 
-      registerServerComponent({}, 'TestComponent');
+      registerServerComponent('TestComponent');
       railsContext = {
         rscPayloadGenerationUrl: 'rsc-render',
         componentSpecificMetadata: {

spec/dummy/spec/packs_generator_spec.rb

@@ -24,7 +24,7 @@ module ReactOnRails
     before do
       stub_const("ReactOnRailsPro", Class.new do
         def self.configuration
-          @configuration ||= Struct.new(:enable_rsc_support, :rsc_payload_generation_url_path).new(false, nil)
+          @configuration ||= Struct.new(:enable_rsc_support).new(false)
         end
       end)
       ReactOnRails.configuration.server_bundle_js_file = server_bundle_js_file
@@ -216,15 +216,13 @@ def self.configuration
 
     context "when RSC support is enabled" do
       let(:components_directory) { "ReactServerComponents" }
-      let(:rsc_payload_generation_url_path) { "/rsc" }
 
       before do
         stub_packer_source_path(component_name: components_directory,
                                 packer_source_path: packer_source_path)
         allow(ReactOnRails::Utils).to receive(:react_on_rails_pro?).and_return(true)
         allow(ReactOnRailsPro.configuration).to receive_messages(
-          enable_rsc_support: true,
-          rsc_payload_generation_url_path: rsc_payload_generation_url_path
+          enable_rsc_support: true
         )
       end
 
@@ -240,9 +238,7 @@ def self.configuration
           expected_content = <<~CONTENT.strip
             import registerServerComponent from 'react-on-rails/registerServerComponent/client';
 
-            registerServerComponent({
-              rscPayloadGenerationUrlPath: "#{rsc_payload_generation_url_path}",
-            }, "#{component_name}")
+            registerServerComponent("#{component_name}");
           CONTENT
 
           expect(pack_content).to eq(expected_content)
@@ -276,9 +272,7 @@ def self.configuration
           expected_content = <<~CONTENT.strip
             import registerServerComponent from 'react-on-rails/registerServerComponent/client';
 
-            registerServerComponent({
-              rscPayloadGenerationUrlPath: "#{rsc_payload_generation_url_path}",
-            }, "#{component_name}")
+            registerServerComponent("#{component_name}");
           CONTENT
 
           expect(pack_content).to eq(expected_content)