fix: Fix ESLint configuration and pre-commit hook for Pro package

This fix addresses two issues:

1. **ESLint configuration**: The `packages/react-on-rails-pro/**/*` files
   were being linted with strict TypeScript rules that don't work for Pro
   package code because it uses internal React on Rails APIs with complex
   types that can't be resolved in the monorepo setup. Added ESLint config
   overrides to disable problematic rules for Pro package files.

2. **Pre-commit hook**: The `bin/lefthook/eslint-lint` script was looking
   for Pro files at `react_on_rails_pro/` (the old Pro gem directory) but
   not at `packages/react-on-rails-pro/` (the new monorepo Pro package).
   Updated the script to properly handle both directories since they use
   different ESLint configurations.

Changes:
- Updated eslint.config.ts to disable import resolution and unsafe type
  rules for packages/react-on-rails-pro files (placed after TypeScript
  config to ensure rules are properly applied)
- Updated bin/lefthook/eslint-lint to lint packages/react-on-rails-pro
  files with the root ESLint config
- Removed now-unnecessary eslint-disable comments from Pro package files

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

bin/lefthook/eslint-lint

@@ -10,50 +10,56 @@ if [ -z "$files" ]; then
   exit 0
 fi
 
-# Separate files into root and Pro directories
-root_files=$(echo "$files" | grep -v '^react_on_rails_pro/' || true)
-pro_files=$(echo "$files" | grep '^react_on_rails_pro/' || true)
+# Separate files into different directories
+# react_on_rails_pro/ has its own ESLint config
+# packages/react-on-rails-pro/ uses root ESLint config
+react_on_rails_pro_files=$(echo "$files" | grep '^react_on_rails_pro/' || true)
+packages_pro_files=$(echo "$files" | grep '^packages/react-on-rails-pro/' || true)
+root_files=$(echo "$files" | grep -v '^react_on_rails_pro/' | grep -v '^packages/react-on-rails-pro/' || true)
 
 exit_code=0
 
-# Lint root files
-if [ -n "$root_files" ]; then
+# Lint root files (includes packages/react-on-rails-pro)
+root_and_packages_pro_files="$root_files $packages_pro_files"
+root_and_packages_pro_files=$(echo "$root_and_packages_pro_files" | xargs)  # trim whitespace
+
+if [ -n "$root_and_packages_pro_files" ]; then
   if [ "$CONTEXT" = "all-changed" ]; then
     echo "🔍 ESLint on root changed files:"
   else
     echo "🔍 ESLint on root $CONTEXT files:"
   fi
-  printf "  %s\n" $root_files
+  printf "  %s\n" $root_and_packages_pro_files
 
-  if ! yarn run eslint $root_files --report-unused-disable-directives --fix; then
+  if ! yarn run eslint $root_and_packages_pro_files --report-unused-disable-directives --fix; then
     exit_code=1
   fi
 
   # Re-stage files if running on staged or all-changed context
   if [ "$CONTEXT" = "staged" ] || [ "$CONTEXT" = "all-changed" ]; then
-    echo $root_files | xargs -r git add
+    echo $root_and_packages_pro_files | xargs -r git add
   fi
 fi
 
-# Lint Pro files (using Pro's ESLint config)
-if [ -n "$pro_files" ]; then
+# Lint react_on_rails_pro files (using Pro gem's ESLint config)
+if [ -n "$react_on_rails_pro_files" ]; then
   if [ "$CONTEXT" = "all-changed" ]; then
-    echo "🔍 ESLint on Pro changed files:"
+    echo "🔍 ESLint on react_on_rails_pro changed files:"
   else
-    echo "🔍 ESLint on Pro $CONTEXT files:"
+    echo "🔍 ESLint on react_on_rails_pro $CONTEXT files:"
   fi
-  printf "  %s\n" $pro_files
+  printf "  %s\n" $react_on_rails_pro_files
 
   # Strip react_on_rails_pro/ prefix for running in Pro directory
-  pro_files_relative=$(echo "$pro_files" | sed 's|^react_on_rails_pro/||')
+  react_on_rails_pro_files_relative=$(echo "$react_on_rails_pro_files" | sed 's|^react_on_rails_pro/||')
 
-  if ! (cd react_on_rails_pro && yarn run eslint $pro_files_relative --report-unused-disable-directives --fix); then
+  if ! (cd react_on_rails_pro && yarn run eslint $react_on_rails_pro_files_relative --report-unused-disable-directives --fix); then
     exit_code=1
   fi
 
   # Re-stage files if running on staged or all-changed context
   if [ "$CONTEXT" = "staged" ] || [ "$CONTEXT" = "all-changed" ]; then
-    echo $pro_files | xargs -r git add
+    echo $react_on_rails_pro_files | xargs -r git add
   fi
 fi
 

eslint.config.ts

@@ -158,14 +158,6 @@ const config = tsEslint.config([
       'import/extensions': ['error', 'ignorePackages'],
     },
   },
-  {
-    files: ['packages/react-on-rails-pro/**/*'],
-    rules: {
-      // Disable import/named for pro package - can't resolve monorepo workspace imports
-      // TypeScript compiler validates these imports
-      'import/named': 'off',
-    },
-  },
   {
     files: ['**/*.server.ts', '**/*.server.tsx'],
     plugins: {
@@ -228,6 +220,22 @@ const config = tsEslint.config([
       '@typescript-eslint/restrict-template-expressions': 'off',
     },
   },
+  {
+    files: ['packages/react-on-rails-pro/**/*'],
+    rules: {
+      // Disable import rules for pro package - can't resolve monorepo workspace imports
+      // TypeScript compiler validates these imports
+      'import/named': 'off',
+      'import/no-unresolved': 'off',
+      // Disable unsafe type rules - Pro package uses internal APIs with complex types
+      '@typescript-eslint/no-unsafe-assignment': 'off',
+      '@typescript-eslint/no-unsafe-call': 'off',
+      '@typescript-eslint/no-unsafe-member-access': 'off',
+      '@typescript-eslint/no-unsafe-return': 'off',
+      '@typescript-eslint/no-unsafe-argument': 'off',
+      '@typescript-eslint/no-redundant-type-constituents': 'off',
+    },
+  },
   {
     files: ['**/app-react16/**/*'],
     rules: {

packages/react-on-rails-pro/tests/SuspenseHydration.test.tsx

@@ -128,12 +128,11 @@ async function renderAndHydrate() {
   };
 
   const writeSecondChunk = async () => {
-    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
     let { done, value } = await reader.read();
     let decoded = '';
     while (!done) {
       decoded += new TextDecoder().decode(value as Buffer);
-      // eslint-disable-next-line no-await-in-loop, @typescript-eslint/no-unsafe-assignment
+      // eslint-disable-next-line no-await-in-loop
       ({ done, value } = await reader.read());
     }