Fix ESLint errors caught by stricter type checking

- Replace deprecated tsEslint.config() with defineConfig() from eslint/config
- Remove redundant String() call in licenseValidator.ts
- Fix redundant type constituents in union types:
  - Remove unnecessary | undefined from optional property return types
  - Simplify BaseFullObjectType to avoid duplicate key union
- Remove unused eslint-disable directives that are no longer needed

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

eslint.config.ts

@@ -1,5 +1,5 @@
 import path from 'node:path';
-import { globalIgnores } from 'eslint/config';
+import { defineConfig, globalIgnores } from 'eslint/config';
 import jest from 'eslint-plugin-jest';
 import prettierRecommended from 'eslint-plugin-prettier/recommended';
 import testingLibrary from 'eslint-plugin-testing-library';
@@ -16,7 +16,7 @@ const compat = new FlatCompat({
   allConfig: js.configs.all,
 });
 
-const config = tsEslint.config([
+const config = defineConfig([
   // eslint-disable-next-line @typescript-eslint/no-unsafe-argument, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
   includeIgnoreFile(path.resolve(__dirname, '.gitignore')),
   globalIgnores([

packages/react-on-rails-pro-node-renderer/src/shared/licenseValidator.ts

@@ -234,7 +234,7 @@ export function getValidatedLicenseData(): LicenseData {
  */
 export function isEvaluation(): boolean {
   const data = getValidatedLicenseData();
-  const plan = String(data.plan || '');
+  const plan = data.plan ?? '';
   return plan !== 'paid' && !plan.startsWith('paid_');
 }
 

packages/react-on-rails-pro-node-renderer/src/worker/vm.ts

@@ -71,7 +71,7 @@ export type RenderResult = string | Readable | { exceptionMessage: string };
 declare global {
   // This works on node 16+
   // https://stackoverflow.com/questions/35074713/extending-typescript-global-object-in-node-js/68328575#68328575
-  // eslint-disable-next-line vars-on-top, no-var
+  // eslint-disable-next-line vars-on-top
   var ReactOnRails: ROR | undefined;
 }
 

packages/react-on-rails/src/base/client.ts

@@ -167,7 +167,7 @@ Fix: Use only react-on-rails OR react-on-rails-pro, not both.`);
       }
     },
 
-    option<K extends keyof ReactOnRailsOptions>(key: K): ReactOnRailsOptions[K] | undefined {
+    option<K extends keyof ReactOnRailsOptions>(key: K): ReactOnRailsOptions[K] {
       return this.options[key];
     },
 

packages/react-on-rails/src/base/full.ts

@@ -24,12 +24,11 @@ export type ReactOnRailsFullSpecificFunctions = Pick<
 /**
  * Full object type that includes all base methods plus real SSR implementations.
  * Derived from ReactOnRailsInternal by picking base methods and SSR methods.
+ * Note: BaseClientObjectType already includes serverRenderReactComponent and handleError,
+ * so ReactOnRailsFullSpecificFunctions is a subset.
  * @public
  */
-export type BaseFullObjectType = Pick<
-  ReactOnRailsInternal,
-  keyof BaseClientObjectType | keyof ReactOnRailsFullSpecificFunctions
->;
+export type BaseFullObjectType = Pick<ReactOnRailsInternal, keyof BaseClientObjectType>;
 
 export function createBaseFullObject(
   registries: Parameters<typeof createBaseClientObject>[0],

packages/react-on-rails/src/buildConsoleReplay.ts

@@ -16,7 +16,7 @@ declare global {
  * @internal Exported for tests and for Ruby helper to wrap with nonce
  */
 export function consoleReplay(
-  customConsoleHistory: (typeof console)['history'] | undefined = undefined,
+  customConsoleHistory: (typeof console)['history'] = undefined,
   numberOfMessagesToSkip = 0,
 ): string {
   // console.history is a global polyfill used in server rendering.
@@ -54,9 +54,8 @@ export function consoleReplay(
   return lines.join('\n');
 }
 
-/* eslint-disable default-param-last */
 export default function buildConsoleReplay(
-  customConsoleHistory: (typeof console)['history'] | undefined = undefined,
+  customConsoleHistory: (typeof console)['history'] = undefined,
   numberOfMessagesToSkip = 0,
   nonce?: string,
 ): string {
@@ -66,4 +65,3 @@ export default function buildConsoleReplay(
   }
   return wrapInScriptTags('consoleReplayLog', consoleReplayJS, nonce);
 }
-/* eslint-enable default-param-last */

packages/react-on-rails/src/context.ts

@@ -1,10 +1,10 @@
 import type { ReactOnRailsInternal, RailsContext } from './types/index.ts';
 
 declare global {
-  /* eslint-disable no-var,vars-on-top,no-underscore-dangle */
+  /* eslint-disable vars-on-top,no-underscore-dangle */
   var ReactOnRails: ReactOnRailsInternal | undefined;
   var __REACT_ON_RAILS_EVENT_HANDLERS_RAN_ONCE__: boolean;
-  /* eslint-enable no-var,vars-on-top,no-underscore-dangle */
+  /* eslint-enable vars-on-top,no-underscore-dangle */
 }
 
 let currentRailsContext: RailsContext | null = null;

packages/react-on-rails/src/types/index.ts

@@ -362,7 +362,7 @@ export interface ReactOnRailsInternal extends ReactOnRails {
    * @param key
    * @returns option value
    */
-  option<K extends keyof ReactOnRailsOptions>(key: K): ReactOnRailsOptions[K] | undefined;
+  option<K extends keyof ReactOnRailsOptions>(key: K): ReactOnRailsOptions[K];
   /**
    * Allows retrieval of the store generator by name. This is used internally by ReactOnRails after
    * a Rails form loads to prepare stores.

react_on_rails/spec/dummy/client/app/components/HelloWorldRedux.jsx

@@ -19,7 +19,7 @@ export default class HelloWorldRedux extends React.Component {
 
   handleChange() {
     const name = this.nameDomRef.value;
-    // eslint-disable-next-line react/destructuring-assignment
+
     this.props.actions.updateName(name);
   }
 

react_on_rails/spec/dummy/client/app/startup/HelloWorldES5.jsx

@@ -12,7 +12,6 @@ const HelloWorldES5 = createReactClass({
   },
 
   getInitialState() {
-    // eslint-disable-next-line react/destructuring-assignment
     return this.props.helloWorldData;
   },