make utils rspec test run using the packer installed on CI

Author: AbanoubGhadban

.github/workflows/rspec-package-specs.yml

@@ -47,6 +47,9 @@ jobs:
         git config user.email "[email protected]"
         git config user.name "Your Name"
         git commit -am "stop generators from complaining about uncommitted code"
+    - name: Set packer version environment variable
+      run: |
+        echo "CI_PACKER_VERSION=${{ matrix.versions == 'oldest' && 'old' || 'new' }}" >> $GITHUB_ENV
     - name: Run rspec tests
       run: bundle exec rspec spec/react_on_rails
     - name: Store test results

script/convert

@@ -14,6 +14,7 @@ new_config = File.expand_path("../spec/dummy/config/webpacker.yml", __dir__)
 File.rename(old_config, new_config)
 
 gsub_file_content("../Gemfile.development_dependencies", 'gem "shakapacker", "8.0.0"', 'gem "shakapacker", "6.6.0"')
+gsub_file_content("../Gemfile.development_dependencies", 'gem "webpacker", "6.0.0.rc.6"', '')
 
 gsub_file_content("../spec/dummy/package.json", '"shakapacker": "8.0.0",', '"shakapacker": "6.6.0",')
 

spec/react_on_rails/utils_spec.rb

@@ -6,6 +6,18 @@
 # rubocop:disable Metrics/ModuleLength, Metrics/BlockLength
 module ReactOnRails
   RSpec.describe Utils do
+    # Github Actions already run rspec tests two times, once with shakapacker and once with webpacker.
+    # If rspec tests are run locally, we want to test both packers.
+    # If rspec tests are run in CI, we want to test the packer specified in the CI_PACKER_VERSION environment variable.
+    # Check script/convert and .github/workflows/rspec-package-specs.yml for more details.
+    PACKERS_TO_TEST = if ENV["CI_PACKER_VERSION"] == "old"
+                        ["webpacker"]
+                      elsif ENV["CI_PACKER_VERSION"] == "new"
+                        ["shakapacker"]
+                      else
+                        ["shakapacker", "webpacker"]
+                      end
+
     shared_context "with packer enabled" do
       before do
         allow(ReactOnRails).to receive_message_chain(:configuration, :generated_assets_dir)
@@ -196,7 +208,7 @@ def mock_dev_server_running
         end
       end
 
-      ["shakapacker", "webpacker"].each do |packer_type|
+      PACKERS_TO_TEST.each do |packer_type|
         describe ".server_bundle_js_file_path with #{packer_type} enabled" do
           let(:packer_public_output_path) { Pathname.new("public/webpack/development") }
           include_context "with #{packer_type} enabled"