Refactor: Update test mocks to use public_bundles_full_path

- Replace all instances of generated_assets_full_path with public_bundles_full_path in utils_spec.rb
- Ensures consistency in method naming across test cases
- Aligns with recent changes for clearer asset path handling

This change enhances clarity and maintains alignment with the updated method naming conventions.

Author: AbanoubGhadban

CHANGELOG.md

@@ -26,6 +26,7 @@ Changes since the last non-beta release.
 #### New Features
 
 - **Server Bundle Security**: Added new configuration options for enhanced server bundle security and organization:
+
   - `server_bundle_output_path`: Configurable directory (relative to the Rails root) for server bundle output (default: "ssr-generated"). If set to `nil`, the server bundle will be loaded from the same public directory as client bundles.
   - `enforce_private_server_bundles`: When enabled, ensures server bundles are only loaded from private directories outside the public folder (default: false for backward compatibility)
 
@@ -34,10 +35,17 @@ Changes since the last non-beta release.
   - If `server_bundle_output_path` is not set, the server bundle falls back to the client bundle directory (typically the public output path).
   - If `enforce_private_server_bundles` is enabled:
     - The server bundle will only be loaded from the private directory specified by `server_bundle_output_path`.
-    - If the bundle is not found there, it will *not* fall back to the public directory.
+    - If the bundle is not found there, it will _not_ fall back to the public directory.
   - If `enforce_private_server_bundles` is not enabled and the bundle is not found in the private directory, it will fall back to the public directory.
   - This logic ensures that, when strict enforcement is enabled, server bundles are never loaded from public directories, improving security and clarity of bundle resolution.
 
+#### API Improvements
+
+- **Method Naming Clarification**: Added `public_bundles_full_path` method to clarify bundle path handling:
+  - `public_bundles_full_path`: New method specifically for webpack bundles in public directories
+  - `generated_assets_full_path`: Now deprecated (backwards-compatible alias)
+  - This eliminates confusion between webpack bundles and general Rails public assets
+
 #### Security Enhancements
 
 - **Private Server Bundle Enforcement**: When `enforce_private_server_bundles` is enabled, server bundles bypass public directory fallbacks and are only loaded from designated private locations

spec/react_on_rails/utils_spec.rb

@@ -650,7 +650,7 @@ def mock_dev_server_running
       context "when in development environment" do
         before do
           allow(Rails.env).to receive(:development?).and_return(true)
-          allow(described_class).to receive(:generated_assets_full_path)
+          allow(described_class).to receive(:public_bundles_full_path)
             .and_return("/path/to/generated/assets")
         end
 
@@ -670,7 +670,7 @@ def mock_dev_server_running
 
       context "when not in development environment" do
         before do
-          allow(described_class).to receive(:generated_assets_full_path)
+          allow(described_class).to receive(:public_bundles_full_path)
             .and_return("/path/to/generated/assets")
         end
 
@@ -690,7 +690,7 @@ def mock_dev_server_running
 
       context "with different manifest file names" do
         before do
-          allow(described_class).to receive(:generated_assets_full_path)
+          allow(described_class).to receive(:public_bundles_full_path)
             .and_return("/path/to/generated/assets")
         end
 
@@ -715,7 +715,7 @@ def mock_dev_server_running
         before do
           allow(ReactOnRails.configuration).to receive(:react_server_client_manifest_file)
             .and_return(nil)
-          allow(described_class).to receive(:generated_assets_full_path)
+          allow(described_class).to receive(:public_bundles_full_path)
             .and_return("/path/to/generated/assets")
         end