Commit 6c44c87
Fix console replay double-wrapping bug and update Node.js version
Critical fixes addressing code review findings:
1. Console Replay Bug Fix:
- Reverted streamingUtils.ts to use buildConsoleReplay instead of consoleReplay
- The consoleReplay function returns unwrapped JavaScript
- buildConsoleReplay properly wraps the JS in <script> tags
- This was causing test failures in renderer_console_logging_spec.rb
- Root cause: commit 0f8a81f introduced this regression
2. Node.js Version Update:
- Updated CI from 22.11.0 to 22.12.x
- V8 bug referenced in issue #56010 was fixed in 22.12.0
- Pinning to 22.12.x gets the fix while staying on latest LTS patch
Testing:
- bundle exec rubocop: ✅ no offenses
- yarn run lint: ✅ passing
- yarn start format.listDifferent: ✅ all files formatted correctly
Related:
- Addresses critical issues found in code review
- Fixes Pro Node Renderer console logging test failures
- Improves CI stability with V8 bug fix
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>1 parent 0e04a06 commit 6c44c87
File tree
2 files changed
+8
-8
lines changed- .github/workflows
- packages/react-on-rails-pro/src
2 files changed
+8
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
| 98 | + | |
99 | 99 | | |
100 | | - | |
| 100 | + | |
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
| |||
193 | 193 | | |
194 | 194 | | |
195 | 195 | | |
196 | | - | |
| 196 | + | |
197 | 197 | | |
198 | | - | |
| 198 | + | |
199 | 199 | | |
200 | 200 | | |
201 | 201 | | |
| |||
392 | 392 | | |
393 | 393 | | |
394 | 394 | | |
395 | | - | |
| 395 | + | |
396 | 396 | | |
397 | | - | |
| 397 | + | |
398 | 398 | | |
399 | 399 | | |
400 | 400 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
115 | | - | |
| 115 | + | |
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
| |||
0 commit comments