Commit 705f5f8
Address additional RBS review suggestions
Minor improvements:
- Fix env vars concatenation for robustness with complex variables
- Document Configuration RBS signature in test (sig/react_on_rails/configuration.rbs:4)
- Add timeout (60s) to Open3.capture3 commands to prevent hung processes in CI
- Document why Pro package omits Steep tasks (doesn't use Steep type checker)
Files modified:
- rakelib/run_rspec.rake: Improve env vars handling for DISABLE_TURBOLINKS
- rakelib/rbs.rake: Add timeout parameter to Open3.capture3 calls
- react_on_rails_pro/rakelib/rbs.rake: Add comment explaining Steep omission + timeout
- spec/react_on_rails/rbs_runtime_checking_spec.rb: Document RBS signature location
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>1 parent 271e094 commit 705f5f8
File tree
4 files changed
+13
-3
lines changed- rakelib
- react_on_rails_pro/rakelib
- spec/react_on_rails
4 files changed
+13
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
45 | 46 | | |
46 | 47 | | |
47 | 48 | | |
48 | | - | |
| 49 | + | |
| 50 | + | |
49 | 51 | | |
50 | 52 | | |
51 | 53 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
70 | 74 | | |
71 | 75 | | |
72 | 76 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
5 | 7 | | |
6 | 8 | | |
7 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
| 19 | + | |
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
| |||
0 commit comments