Skip to content

Commit 70cfbf6

Browse files
justin808claude
andcommitted
Fix knip configuration for pnpm migration
- Remove @babel/runtime and mini-css-extract-plugin from ignoreDependencies (now properly detected by knip with pnpm) - Restore missing ignoreDependencies for dummy app React components - Keep disableHttp2 export ignore for test utilities 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 0f74293 commit 70cfbf6

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

knip.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -177,10 +177,6 @@ const config: KnipConfig = {
177177
'@rescript/react',
178178
// The Babel plugin fails to detect it
179179
'babel-plugin-transform-react-remove-prop-types',
180-
// Required by @babel/plugin-transform-runtime for polyfills
181-
'@babel/runtime',
182-
// Used in webpack server config to filter out MiniCssExtractPlugin
183-
'mini-css-extract-plugin',
184180
// This one is weird. It's long-deprecated and shouldn't be necessary.
185181
// Probably need to update the Webpack config.
186182
'node-libs-browser',
@@ -193,6 +189,14 @@ const config: KnipConfig = {
193189
'sass-resources-loader',
194190
'style-loader',
195191
'url-loader',
192+
// Used in ignored client/app components (dynamically loaded by React on Rails)
193+
'create-react-class',
194+
'react-helmet',
195+
'@types/react-helmet',
196+
'react-redux',
197+
'react-router-dom',
198+
// Transitive dependency of shakapacker but listed as direct dependency
199+
'webpack-merge',
196200
],
197201
},
198202
},

0 commit comments

Comments
 (0)