adjust eslint config to work with e2e-tests

Author: AbanoubGhadban

packages/react-on-rails-pro/tsconfig.json

@@ -3,5 +3,5 @@
   "compilerOptions": {
     "outDir": "./lib"
   },
-  "include": ["src/**/*"],
+  "include": ["src/**/*"]
 }

react_on_rails_pro/eslint.config.mjs

@@ -196,6 +196,24 @@ export default defineConfig([
       ],
     },
   },
+  {
+    files: ['spec/dummy/e2e-tests/*'],
+
+    rules: {
+      'no-empty-pattern': [
+        'error',
+        {
+          allowObjectPatternsAsParameters: true,
+        },
+      ],
+    },
+  },
+  {
+    files: ['spec/dummy/e2e-tests/*'],
+    rules: {
+      'react-hooks/rules-of-hooks': ['off'],
+    },
+  },
   // must be the last config in the array
   // https://github.com/prettier/eslint-plugin-prettier?tab=readme-ov-file#configuration-new-eslintconfigjs
   prettierRecommended,

react_on_rails_pro/spec/dummy/e2e-tests/streaming.spec.ts

@@ -1,4 +1,4 @@
-import { expect, test } from '@playwright/test';
+import { expect } from '@playwright/test';
 import {
   redisReceiverPageController,
   redisReceiverPageTest,
@@ -57,9 +57,7 @@ import {
     await page.click('.toggle-button');
     const fallbackElements = page.getByText(/Waiting for the key "Item\d"/);
     await expect(fallbackElements).toHaveCount(5);
-    for (const el of await fallbackElements.all()) {
-      await expect(el).toBeVisible();
-    }
+    await Promise.all((await fallbackElements.all()).map((el) => expect(el).toBeVisible()));
     await matchPageSnapshot('stage0');
 
     await sendRedisItemValue(0, 'Incremental Value1');
@@ -82,14 +80,14 @@ import {
 redisReceiverInsideRouterPageTest(
   'no RSC payload request is made when the page is server side rendered',
   async ({ getNetworkRequests }) => {
-    await expect(await getNetworkRequests(/rsc_payload/)).toHaveLength(0);
+    expect(await getNetworkRequests(/rsc_payload/)).toHaveLength(0);
   },
 );
 
 redisReceiverPageAfterNavigationTest(
   'RSC payload request is made on navigation',
   async ({ getNetworkRequests }) => {
-    await expect(await getNetworkRequests(/rsc_payload/)).toHaveLength(1);
+    expect(await getNetworkRequests(/rsc_payload/)).toHaveLength(1);
   },
 );
 
@@ -100,6 +98,6 @@ redisReceiverPageController(
 
     await expect(page.getByText('Post 1')).toBeVisible();
     await expect(page.getByText('Toggle')).toBeVisible();
-    await expect(await getNetworkRequests(/rsc_payload/)).toHaveLength(1);
+    expect(await getNetworkRequests(/rsc_payload/)).toHaveLength(1);
   },
 );

react_on_rails_pro/spec/dummy/tsconfig.json

@@ -7,5 +7,11 @@
     "strict": true,
     "skipLibCheck": true
   },
-  "include": ["client/**/*.ts", "client/**/*.tsx", "client/**/*.d.ts", "e2e-tests/*"]
+  "include": [
+    "client/**/*.ts",
+    "client/**/*.tsx",
+    "client/**/*.d.ts",
+    "e2e-tests/*",
+    "./playwright.config.ts"
+  ]
 }