Add tests for Pro and open source attribution comments in rendered output

Author: AbanoubGhadban

react_on_rails_pro/spec/dummy/spec/helpers/react_on_rails_pro_helper_spec.rb

@@ -13,7 +13,7 @@ def render_to_string(*args); end
   def response; end
 end
 
-describe ReactOnRailsProHelper, type: :helper do
+describe ReactOnRailsProHelper do
   # In order to test the pro helper, we need to load the methods from the regular helper.
   # I couldn't see any easier way to do this.
   include ReactOnRails::Helper
@@ -695,4 +695,45 @@ def render_cached_random_value(cache_key)
       end
     end
   end
+
+  describe "attribution comment in stream_react_component" do
+    include StreamingTestHelpers
+
+    let(:component_name) { "TestComponent" }
+    let(:props) { { test: "data" } }
+    let(:component_options) { { prerender: true, id: "#{component_name}-react-component-0" } }
+    let(:chunks) do
+      [
+        { html: "<div>Test Content</div>", consoleReplayScript: "" }
+      ]
+    end
+
+    before do
+      @rorp_rendering_fibers = []
+      ReactOnRailsPro::Request.instance_variable_set(:@connection, nil)
+      original_httpx_plugin = HTTPX.method(:plugin)
+      allow(HTTPX).to receive(:plugin) do |*args|
+        original_httpx_plugin.call(:mock_stream).plugin(*args)
+      end
+      clear_stream_mocks
+
+      mock_streaming_response(%r{http://localhost:3800/bundles/[a-f0-9]{32}-test/render/[a-f0-9]{32}}, 200,
+                              count: 1) do |yielder|
+        chunks.each do |chunk|
+          yielder.call("#{chunk.to_json}\n")
+        end
+      end
+    end
+
+    it "includes the Pro attribution comment in the rendered output" do
+      result = stream_react_component(component_name, props: props, **component_options)
+      expect(result).to include("<!-- Powered by React on Rails Pro (c) ShakaCode")
+    end
+
+    it "includes the attribution comment only once" do
+      result = stream_react_component(component_name, props: props, **component_options)
+      comment_count = result.scan("<!-- Powered by React on Rails Pro").length
+      expect(comment_count).to eq(1)
+    end
+  end
 end

spec/dummy/spec/helpers/react_on_rails_helper_spec.rb

@@ -674,5 +674,136 @@ def self.pro_attribution_comment; end
       end
     end
   end
+
+  describe "attribution comment inclusion in rendered output" do
+    let(:props) { { name: "Test" } }
+
+    before do
+      allow(SecureRandom).to receive(:uuid).and_return(0)
+    end
+
+    describe "#react_component" do
+      context "when React on Rails Pro is installed" do
+        before do
+          allow(ReactOnRails::Utils).to receive(:react_on_rails_pro?).and_return(true)
+          allow(ReactOnRailsPro::Utils).to receive(:pro_attribution_comment)
+            .and_return("<!-- Powered by React on Rails Pro (c) ShakaCode | Licensed -->")
+        end
+
+        it "includes the Pro attribution comment in the rendered output" do
+          result = react_component("App", props: props)
+          expect(result).to include("<!-- Powered by React on Rails Pro (c) ShakaCode | Licensed -->")
+        end
+
+        it "includes the attribution comment only once" do
+          result = react_component("App", props: props)
+          comment_count = result.scan("<!-- Powered by React on Rails Pro").length
+          expect(comment_count).to eq(1)
+        end
+      end
+
+      context "when React on Rails Pro is NOT installed" do
+        before do
+          allow(ReactOnRails::Utils).to receive(:react_on_rails_pro?).and_return(false)
+        end
+
+        it "includes the open source attribution comment in the rendered output" do
+          result = react_component("App", props: props)
+          expect(result).to include("<!-- Powered by React on Rails (c) ShakaCode | Open Source -->")
+        end
+
+        it "includes the attribution comment only once" do
+          result = react_component("App", props: props)
+          comment_count = result.scan("<!-- Powered by React on Rails").length
+          expect(comment_count).to eq(1)
+        end
+      end
+    end
+
+    describe "#redux_store" do
+      context "when React on Rails Pro is installed" do
+        before do
+          allow(ReactOnRails::Utils).to receive(:react_on_rails_pro?).and_return(true)
+          allow(ReactOnRailsPro::Utils).to receive(:pro_attribution_comment)
+            .and_return("<!-- Powered by React on Rails Pro (c) ShakaCode | Licensed -->")
+        end
+
+        it "includes the Pro attribution comment in the rendered output" do
+          result = redux_store("TestStore", props: props)
+          expect(result).to include("<!-- Powered by React on Rails Pro (c) ShakaCode | Licensed -->")
+        end
+
+        it "includes the attribution comment only once" do
+          result = redux_store("TestStore", props: props)
+          comment_count = result.scan("<!-- Powered by React on Rails Pro").length
+          expect(comment_count).to eq(1)
+        end
+      end
+
+      context "when React on Rails Pro is NOT installed" do
+        before do
+          allow(ReactOnRails::Utils).to receive(:react_on_rails_pro?).and_return(false)
+        end
+
+        it "includes the open source attribution comment in the rendered output" do
+          result = redux_store("TestStore", props: props)
+          expect(result).to include("<!-- Powered by React on Rails (c) ShakaCode | Open Source -->")
+        end
+
+        it "includes the attribution comment only once" do
+          result = redux_store("TestStore", props: props)
+          comment_count = result.scan("<!-- Powered by React on Rails").length
+          expect(comment_count).to eq(1)
+        end
+      end
+    end
+
+    describe "#react_component_hash" do
+      before do
+        allow(ReactOnRails::ServerRenderingPool).to receive(:server_render_js_with_console_logging).and_return(
+          "html" => { "componentHtml" => "<div>Test</div>", "title" => "Test Title" },
+          "consoleReplayScript" => ""
+        )
+        allow(ReactOnRails::ServerRenderingJsCode).to receive(:js_code_renderer)
+          .and_return(ReactOnRails::ServerRenderingJsCode)
+      end
+
+      context "when React on Rails Pro is installed" do
+        before do
+          allow(ReactOnRails::Utils).to receive(:react_on_rails_pro?).and_return(true)
+          allow(ReactOnRailsPro::Utils).to receive(:pro_attribution_comment)
+            .and_return("<!-- Powered by React on Rails Pro (c) ShakaCode | Licensed -->")
+        end
+
+        it "includes the Pro attribution comment in the componentHtml" do
+          result = react_component_hash("App", props: props, prerender: true)
+          expect(result["componentHtml"]).to include("<!-- Powered by React on Rails Pro (c) ShakaCode | Licensed -->")
+        end
+
+        it "includes the attribution comment only once" do
+          result = react_component_hash("App", props: props, prerender: true)
+          comment_count = result["componentHtml"].scan("<!-- Powered by React on Rails Pro").length
+          expect(comment_count).to eq(1)
+        end
+      end
+
+      context "when React on Rails Pro is NOT installed" do
+        before do
+          allow(ReactOnRails::Utils).to receive(:react_on_rails_pro?).and_return(false)
+        end
+
+        it "includes the open source attribution comment in the componentHtml" do
+          result = react_component_hash("App", props: props, prerender: true)
+          expect(result["componentHtml"]).to include("<!-- Powered by React on Rails (c) ShakaCode | Open Source -->")
+        end
+
+        it "includes the attribution comment only once" do
+          result = react_component_hash("App", props: props, prerender: true)
+          comment_count = result["componentHtml"].scan("<!-- Powered by React on Rails").length
+          expect(comment_count).to eq(1)
+        end
+      end
+    end
+  end
 end
 # rubocop:enable Metrics/BlockLength